From: Stephen Warren <swarren@wwwdotorg.org>
To: Eric Anholt <eric@anholt.net>
Cc: linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Lee Jones <lee@kernel.org>,
Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@baylibre.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree.
Date: Mon, 21 Sep 2015 19:19:47 -0700 [thread overview]
Message-ID: <5600BAC3.70506@wwwdotorg.org> (raw)
In-Reply-To: <1441923750-19404-4-git-send-email-eric@anholt.net>
On 09/10/2015 03:22 PM, Eric Anholt wrote:
> These will be used for enabling UART1, SPI1, and SPI2.
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> + aux_clocks: aux-clocks@0x7e215004 {
> + compatible = "brcm,bcm2835-aux-clock";
> + #clock-cells = <1>;
> + reg = <0x7e215004 0x4>;
Actually, I take back the ack on this patch. This HW module has two
registers. The reg property should include both of those registers so
that if SW needs to start using the other register at some time in the
future, the entire set of registers is already represented in DT.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree.
Date: Mon, 21 Sep 2015 19:19:47 -0700 [thread overview]
Message-ID: <5600BAC3.70506@wwwdotorg.org> (raw)
In-Reply-To: <1441923750-19404-4-git-send-email-eric@anholt.net>
On 09/10/2015 03:22 PM, Eric Anholt wrote:
> These will be used for enabling UART1, SPI1, and SPI2.
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> + aux_clocks: aux-clocks at 0x7e215004 {
> + compatible = "brcm,bcm2835-aux-clock";
> + #clock-cells = <1>;
> + reg = <0x7e215004 0x4>;
Actually, I take back the ack on this patch. This HW module has two
registers. The reg property should include both of those registers so
that if SW needs to start using the other register at some time in the
future, the entire set of registers is already represented in DT.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Eric Anholt <eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
Cc: linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-rpi-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Lee Jones <lee-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Mike Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree.
Date: Mon, 21 Sep 2015 19:19:47 -0700 [thread overview]
Message-ID: <5600BAC3.70506@wwwdotorg.org> (raw)
In-Reply-To: <1441923750-19404-4-git-send-email-eric-WhKQ6XTQaPysTnJN9+BGXg@public.gmane.org>
On 09/10/2015 03:22 PM, Eric Anholt wrote:
> These will be used for enabling UART1, SPI1, and SPI2.
> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
> + aux_clocks: aux-clocks@0x7e215004 {
> + compatible = "brcm,bcm2835-aux-clock";
> + #clock-cells = <1>;
> + reg = <0x7e215004 0x4>;
Actually, I take back the ack on this patch. This HW module has two
registers. The reg property should include both of those registers so
that if SW needs to start using the other register at some time in the
future, the entire set of registers is already represented in DT.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-09-22 2:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-10 22:22 BCM2835 auxiliary peripheral clocks Eric Anholt
2015-09-10 22:22 ` Eric Anholt
2015-09-10 22:22 ` [PATCH 1/3] clk: bcm2835: Add bindings for the auxiliary peripheral clock gates Eric Anholt
2015-09-10 22:22 ` Eric Anholt
2015-09-10 22:22 ` Eric Anholt
2015-09-10 22:22 ` [PATCH 2/3] clk: bcm2835: Add a driver " Eric Anholt
2015-09-10 22:22 ` Eric Anholt
2015-09-11 10:24 ` Martin Sperl
2015-09-11 10:24 ` Martin Sperl
2015-09-11 10:24 ` Martin Sperl
2015-09-22 2:11 ` Stephen Warren
2015-09-22 2:11 ` Stephen Warren
2015-10-02 0:19 ` Stephen Boyd
2015-10-02 0:19 ` Stephen Boyd
2015-09-10 22:22 ` [PATCH 3/3] ARM: bcm2835: Add the auxiliary clocks to the device tree Eric Anholt
2015-09-10 22:22 ` Eric Anholt
2015-09-22 2:12 ` Stephen Warren
2015-09-22 2:12 ` Stephen Warren
2015-09-22 2:12 ` Stephen Warren
2015-09-22 2:19 ` Stephen Warren [this message]
2015-09-22 2:19 ` Stephen Warren
2015-09-22 2:19 ` Stephen Warren
2015-09-28 19:26 ` Eric Anholt
2015-09-28 19:26 ` Eric Anholt
2015-09-28 19:49 ` Stephen Warren
2015-09-28 19:49 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5600BAC3.70506@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=devicetree@vger.kernel.org \
--cc=eric@anholt.net \
--cc=lee@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.