All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Rustad <mrustad@gmail.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter
Date: Mon, 21 Sep 2015 22:03:42 -0700	[thread overview]
Message-ID: <5600E12E.4040005@gmail.com> (raw)
In-Reply-To: <5600D5A2.70403@redhat.com>

On 9/21/15 9:14 PM, Jarod Wilson wrote:
> Just switching to adapter->io_addr everywhere seems to not work as 
> noted above. :\ Note that I'm also chasing this from the other end 
> with the author of the pci patches that seem to have triggered this, 
> so the real bug might be over in pci-land, but hardening against 
> explosions in igb still seems like a worthwhile effort here.

My understanding is that there can be problems if too many writes to a
removed device happen. That is why ixgbe avoids doing that by testing
for removal in some places. The io_addr does get used in the transmit
path simply to avoid adding a test to that hot path. That approach
seems to be working well for ixgbe.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 867 bytes
Desc: OpenPGP digital signature
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20150921/cb90f123/attachment.asc>

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rustad <mrustad@gmail.com>
To: Jarod Wilson <jarod@redhat.com>,
	Alexander Duyck <alexander.duyck@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org
Subject: Re: [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter
Date: Mon, 21 Sep 2015 22:03:42 -0700	[thread overview]
Message-ID: <5600E12E.4040005@gmail.com> (raw)
In-Reply-To: <5600D5A2.70403@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 712 bytes --]

On 9/21/15 9:14 PM, Jarod Wilson wrote:
> Just switching to adapter->io_addr everywhere seems to not work as 
> noted above. :\ Note that I'm also chasing this from the other end 
> with the author of the pci patches that seem to have triggered this, 
> so the real bug might be over in pci-land, but hardening against 
> explosions in igb still seems like a worthwhile effort here.

My understanding is that there can be problems if too many writes to a
removed device happen. That is why ixgbe avoids doing that by testing
for removal in some places. The io_addr does get used in the transmit
path simply to avoid adding a test to that hot path. That approach
seems to be working well for ixgbe.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 867 bytes --]

  reply	other threads:[~2015-09-22  5:03 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 17:11 [Intel-wired-lan] [PATCH] igb: add more checks for disconnected adapter Jarod Wilson
2015-09-21 17:11 ` Jarod Wilson
2015-09-21 17:11 ` Jarod Wilson
2015-09-21 21:57 ` [Intel-wired-lan] " Alexander Duyck
2015-09-21 21:57   ` Alexander Duyck
2015-09-21 21:57   ` Alexander Duyck
2015-09-22  4:14   ` Jarod Wilson
2015-09-22  4:14     ` Jarod Wilson
2015-09-22  5:03     ` Mark Rustad [this message]
2015-09-22  5:03       ` Mark Rustad
2015-09-22  5:21     ` Alexander Duyck
2015-09-22  5:21       ` Alexander Duyck
2015-10-06 21:50       ` Jarod Wilson
2015-10-06 21:50         ` Jarod Wilson
2015-10-06 21:52         ` [Intel-wired-lan] [PATCH] igb: improve handling of disconnected adapters Jarod Wilson
2015-10-06 21:52           ` Jarod Wilson
2015-10-06 21:52           ` Jarod Wilson
2015-10-06 22:09           ` [Intel-wired-lan] " kbuild test robot
2015-10-06 22:09             ` kbuild test robot
2015-10-06 22:59           ` [Intel-wired-lan] " Alexander Duyck
2015-10-06 22:59             ` Alexander Duyck
2015-10-06 22:59             ` Alexander Duyck
2015-10-07 13:21             ` [Intel-wired-lan] [PATCH v3] " Jarod Wilson
2015-10-07 13:21               ` Jarod Wilson
2015-10-07 13:21               ` Jarod Wilson
2015-10-07 15:03               ` [Intel-wired-lan] " Alexander Duyck
2015-10-07 15:03                 ` Alexander Duyck
2015-10-07 15:03                 ` Alexander Duyck
2015-10-13  6:10               ` [Intel-wired-lan] " Jeff Kirsher
2015-10-13  6:10                 ` Jeff Kirsher
2015-10-19 15:52                 ` [Intel-wired-lan] [PATCH v2] " Jarod Wilson
2015-10-19 15:52                   ` Jarod Wilson
2015-11-20  4:40                   ` [Intel-wired-lan] " Brown, Aaron F
2015-11-20  4:40                     ` Brown, Aaron F

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5600E12E.4040005@gmail.com \
    --to=mrustad@gmail.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.