* [PATCH] serial_core: support native endianness
@ 2015-09-22 11:34 Max Filippov
2015-09-22 11:45 ` Jiri Slaby
0 siblings, 1 reply; 2+ messages in thread
From: Max Filippov @ 2015-09-22 11:34 UTC (permalink / raw)
To: linux-serial; +Cc: Greg Kroah-Hartman, Jiri Slaby, linux-kernel, Max Filippov
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
drivers/tty/serial/serial_core.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index f368520..84b5695 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -1826,8 +1826,8 @@ uart_get_console(struct uart_port *ports, int nr, struct console *co)
* @options: ptr for <options> field; NULL if not present (out)
*
* Decodes earlycon kernel command line parameters of the form
- * earlycon=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
- * console=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
+ * earlycon=<name>,io|mmio|mmio32|mmio32be|mmio32native,<addr>,<options>
+ * console=<name>,io|mmio|mmio32|mmio32be|mmio32native,<addr>,<options>
*
* The optional form
* earlycon=<name>,0x<addr>,<options>
@@ -1848,6 +1848,10 @@ int uart_parse_earlycon(char *p, unsigned char *iotype, unsigned long *addr,
} else if (strncmp(p, "mmio32be,", 9) == 0) {
*iotype = UPIO_MEM32BE;
p += 9;
+ } else if (strncmp(p, "mmio32native,", 13) == 0) {
+ *iotype = IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) ?
+ UPIO_MEM32BE : UPIO_MEM32;
+ p += 13;
} else if (strncmp(p, "io,", 3) == 0) {
*iotype = UPIO_PORT;
p += 3;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] serial_core: support native endianness
2015-09-22 11:34 [PATCH] serial_core: support native endianness Max Filippov
@ 2015-09-22 11:45 ` Jiri Slaby
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Slaby @ 2015-09-22 11:45 UTC (permalink / raw)
To: Max Filippov, linux-serial; +Cc: Greg Kroah-Hartman, linux-kernel
On 09/22/2015, 01:34 PM, Max Filippov wrote:
NACK until you provide a useful commit log including description why
this is needed.
> Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
> ---
> drivers/tty/serial/serial_core.c | 8 ++++++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
> index f368520..84b5695 100644
> --- a/drivers/tty/serial/serial_core.c
> +++ b/drivers/tty/serial/serial_core.c
> @@ -1826,8 +1826,8 @@ uart_get_console(struct uart_port *ports, int nr, struct console *co)
> * @options: ptr for <options> field; NULL if not present (out)
> *
> * Decodes earlycon kernel command line parameters of the form
> - * earlycon=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> - * console=<name>,io|mmio|mmio32|mmio32be,<addr>,<options>
> + * earlycon=<name>,io|mmio|mmio32|mmio32be|mmio32native,<addr>,<options>
> + * console=<name>,io|mmio|mmio32|mmio32be|mmio32native,<addr>,<options>
> *
> * The optional form
> * earlycon=<name>,0x<addr>,<options>
> @@ -1848,6 +1848,10 @@ int uart_parse_earlycon(char *p, unsigned char *iotype, unsigned long *addr,
> } else if (strncmp(p, "mmio32be,", 9) == 0) {
> *iotype = UPIO_MEM32BE;
> p += 9;
> + } else if (strncmp(p, "mmio32native,", 13) == 0) {
> + *iotype = IS_ENABLED(CONFIG_CPU_BIG_ENDIAN) ?
> + UPIO_MEM32BE : UPIO_MEM32;
> + p += 13;
> } else if (strncmp(p, "io,", 3) == 0) {
> *iotype = UPIO_PORT;
> p += 3;
>
thanks,
--
js
suse labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-22 11:45 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-22 11:34 [PATCH] serial_core: support native endianness Max Filippov
2015-09-22 11:45 ` Jiri Slaby
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.