From: yangyingliang@huawei.com (Yang Yingliang)
To: linux-arm-kernel@lists.infradead.org
Subject: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for cpu hotplug
Date: Wed, 23 Sep 2015 12:16:00 +0800 [thread overview]
Message-ID: <56022780.1030308@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1509222050300.5606@nanos>
On 2015/9/23 2:54, Thomas Gleixner wrote:
> On Sat, 19 Sep 2015, Yang Yingliang wrote:
>
>> Add irq_migrate_all_off_this_cpu() into kernel/irq/migration.c.
>
> This doesn't make any sense at all.
>
> You just reuse the existing file to stick your new code into it
> without reusing a single bit in that file. Aside of that it's
> unconditionally compiled, which means all existing users of
> CONFIG_GENERIC_PENDING_IRQ are burdened with pointless code.
>
> The right thing to do is:
>
> Add that code to a new file: kernel/irq/cpuhotplug.c and make that
> depend on CONFIG_GENERIC_IRQ_MIGRATION.
How about add #ifdef CONFIG_CPU_HOTPLUG around new code
in kernel/irq/migration.c ?
Thanks,
Yang
WARNING: multiple messages have this Message-ID (diff)
From: Yang Yingliang <yangyingliang@huawei.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Jiang Liu <jiang.liu@linux.intel.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
Russell King - ARM Linux <linux@arm.linux.org.uk>,
Hanjun Guo <hanjun.guo@linaro.org>
Subject: Re: [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for cpu hotplug
Date: Wed, 23 Sep 2015 12:16:00 +0800 [thread overview]
Message-ID: <56022780.1030308@huawei.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1509222050300.5606@nanos>
On 2015/9/23 2:54, Thomas Gleixner wrote:
> On Sat, 19 Sep 2015, Yang Yingliang wrote:
>
>> Add irq_migrate_all_off_this_cpu() into kernel/irq/migration.c.
>
> This doesn't make any sense at all.
>
> You just reuse the existing file to stick your new code into it
> without reusing a single bit in that file. Aside of that it's
> unconditionally compiled, which means all existing users of
> CONFIG_GENERIC_PENDING_IRQ are burdened with pointless code.
>
> The right thing to do is:
>
> Add that code to a new file: kernel/irq/cpuhotplug.c and make that
> depend on CONFIG_GENERIC_IRQ_MIGRATION.
How about add #ifdef CONFIG_CPU_HOTPLUG around new code
in kernel/irq/migration.c ?
Thanks,
Yang
next prev parent reply other threads:[~2015-09-23 4:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-19 3:05 [RFC PATCH v5 0/4] arm/arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-19 3:05 ` Yang Yingliang
2015-09-19 3:05 ` [RFC PATCH v5 1/4] genirq: introduce CONFIG_GENERIC_IRQ_MIGRATION Yang Yingliang
2015-09-19 3:05 ` Yang Yingliang
2015-09-22 18:49 ` Marc Zyngier
2015-09-22 18:49 ` Marc Zyngier
2015-09-19 3:05 ` [RFC PATCH v5 2/4] genirq: add irq_migrate_all_off_this_cpu() for cpu hotplug Yang Yingliang
2015-09-19 3:05 ` Yang Yingliang
2015-09-22 18:48 ` Marc Zyngier
2015-09-22 18:48 ` Marc Zyngier
2015-09-22 18:54 ` Thomas Gleixner
2015-09-22 18:54 ` Thomas Gleixner
2015-09-23 4:16 ` Yang Yingliang [this message]
2015-09-23 4:16 ` Yang Yingliang
2015-09-23 8:02 ` Thomas Gleixner
2015-09-23 8:02 ` Thomas Gleixner
2015-09-19 3:05 ` [RFC PATCH v5 3/4] arm64: fix a migrating irq bug when hotplug cpu Yang Yingliang
2015-09-19 3:05 ` Yang Yingliang
2015-09-22 18:44 ` Marc Zyngier
2015-09-22 18:44 ` Marc Zyngier
2015-09-19 3:05 ` [RFC PATCH v5 4/4] arm: " Yang Yingliang
2015-09-19 3:05 ` Yang Yingliang
2015-09-22 18:50 ` Marc Zyngier
2015-09-22 18:50 ` Marc Zyngier
2015-09-22 18:34 ` [RFC PATCH v5 0/4] arm/arm64: " Will Deacon
2015-09-22 18:34 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56022780.1030308@huawei.com \
--to=yangyingliang@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.