Re: [PATCH v6 11/29] xen/x86: add bitmap of enabled emulated devices

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 23/09/15 13:42, Roger Pau Monné wrote:
> El 16/09/15 a les 12.10, Jan Beulich ha escrit:
>>>>> On 04.09.15 at 14:08, <roger.pau@citrix.com> wrote:
>>> --- a/xen/include/asm-x86/domain.h
>>> +++ b/xen/include/asm-x86/domain.h
>>> @@ -387,8 +387,21 @@ struct arch_domain
>>>       bool_t mem_access_emulate_enabled;
>>>   
>>>       struct monitor_write_data *event_write_data;
>>> +
>>> +    /* Emulated devices enabled bitmap. */
>>> +    uint32_t emulation_flags;
>>>   } __cacheline_aligned;
>>>   
>>> +#define has_vlapic(d)       ((d)->arch.emulation_flags & XEN_X86_EMU_LAPIC)
>>> +#define has_vhpet(d)        ((d)->arch.emulation_flags & XEN_X86_EMU_HPET)
>>> +#define has_vpmtimer(d)     ((d)->arch.emulation_flags & XEN_X86_EMU_PMTIMER)
>>> +#define has_vrtc(d)         ((d)->arch.emulation_flags & XEN_X86_EMU_RTC)
>>> +#define has_vioapic(d)      ((d)->arch.emulation_flags & XEN_X86_EMU_IOAPIC)
>>> +#define has_vpic(d)         ((d)->arch.emulation_flags & XEN_X86_EMU_PIC)
>>> +#define has_vpmu(d)         ((d)->arch.emulation_flags & XEN_X86_EMU_PMU)
>>> +#define has_vvga(d)         ((d)->arch.emulation_flags & XEN_X86_EMU_VGA)
>>> +#define has_viommu(d)       ((d)->arch.emulation_flags & XEN_X86_EMU_IOMMU)
>> And btw, now that I saw a few uses of these - do they really all need
>> to be has_v*() instead of just has_*()? Together with the macros taking
>> a domain pointer it's quite obvious that talk is about virtual devices...
> IMHO, I prefer to have the "v" prefix, because that's how they are named
> inside of Xen, so it's more clear that we are actually disabling them,
> but I'm not going to fight for it.

I personally think it is clearer having the v in the name.

~Andrew