Re: [PATCH v6 11/29] xen/x86: add bitmap of enabled emulated devices

[Andrew Cooper <andrew.cooper3@citrix.com>]

On 04/09/15 14:55, Jan Beulich wrote:
>>>> On 04.09.15 at 15:51, <roger.pau@citrix.com> wrote:
>> El 04/09/15 a les 14.25, Wei Liu ha escrit:
>>> On Fri, Sep 04, 2015 at 02:08:50PM +0200, Roger Pau Monne wrote:
>>>> diff --git a/xen/arch/x86/domain.c b/xen/arch/x86/domain.c
>>>> index 045f6ff..fe9504f 100644
>>>> --- a/xen/arch/x86/domain.c
>>>> +++ b/xen/arch/x86/domain.c
>>>> @@ -555,6 +555,29 @@ int arch_domain_create(struct domain *d, unsigned int
>> domcr_flags,
>>>>                  d->domain_id);
>>>>       }
>>>>   
>>>> +    if ( is_hvm_domain(d) )
>>>> +    {
>>>> +        uint32_t emulation_mask = (XEN_X86_EMU_LAPIC | XEN_X86_EMU_HPET |
>>>> +                                   XEN_X86_EMU_PMTIMER | XEN_X86_EMU_RTC |
>>>> +                                   XEN_X86_EMU_IOAPIC | XEN_X86_EMU_PIC |
>>>> +                                   XEN_X86_EMU_PMU | XEN_X86_EMU_VGA |
>>>> +                                   XEN_X86_EMU_IOMMU);
>>> This is repetitive. Could you consolidate all these to
>>>
>>>    #define XEN_X86_EMU_ALL ...
>>>
>>> ?
>> That sounds fine, I would place it in the public header where all the
>> XEN_X86_EMU_* are defined. I will wait for Andrew's opinion, since he
>> already acked this patch.
> This doesn't belong in the public ABI, so if at all it should be added
> there inside #ifdef __XEN__. Alternatively (and perhaps preferably)
> this would go into another (internal) header.

Agreed.

Having an ALL mask will be useful for checking invalid values, but this 
logic is going to get a bit more complicated as soon as we see about 
introducing situations which permit the use of the vLAPIC, and I don't 
see the ALL mask being useful anywhere else.

I am not fussed either way.

~Andrew