From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luis@debethencourt.com>,
linux-kernel@vger.kernel.org
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver
Date: Thu, 24 Sep 2015 10:17:53 +0000 [thread overview]
Message-ID: <5603CDD1.7030709@ti.com> (raw)
In-Reply-To: <20150918184457.GA32636@goodgumbo.baconseed.org>
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
On 18/09/15 21:44, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hello,
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
>
> Thanks,
> Luis
>
> drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> index 90cbc4c..c581231 100644
> --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = {
> { .compatible = "omapdss,sony,acx565akm", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, acx565akm_of_match);
>
> static struct spi_driver acx565akm_driver = {
> .driver = {
>
Thanks, queued for 4.3 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luis@debethencourt.com>,
linux-kernel@vger.kernel.org
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver
Date: Thu, 24 Sep 2015 13:17:53 +0300 [thread overview]
Message-ID: <5603CDD1.7030709@ti.com> (raw)
In-Reply-To: <20150918184457.GA32636@goodgumbo.baconseed.org>
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
On 18/09/15 21:44, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hello,
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
>
> Thanks,
> Luis
>
> drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> index 90cbc4c..c581231 100644
> --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = {
> { .compatible = "omapdss,sony,acx565akm", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, acx565akm_of_match);
>
> static struct spi_driver acx565akm_driver = {
> .driver = {
>
Thanks, queued for 4.3 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luis@debethencourt.com>,
<linux-kernel@vger.kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
<linux-omap@vger.kernel.org>, <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver
Date: Thu, 24 Sep 2015 13:17:53 +0300 [thread overview]
Message-ID: <5603CDD1.7030709@ti.com> (raw)
In-Reply-To: <20150918184457.GA32636@goodgumbo.baconseed.org>
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
On 18/09/15 21:44, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
>
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hello,
>
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
>
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
>
> Thanks,
> Luis
>
> drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> index 90cbc4c..c581231 100644
> --- a/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> +++ b/drivers/video/fbdev/omap2/displays-new/panel-sony-acx565akm.c
> @@ -898,6 +898,7 @@ static const struct of_device_id acx565akm_of_match[] = {
> { .compatible = "omapdss,sony,acx565akm", },
> {},
> };
> +MODULE_DEVICE_TABLE(of, acx565akm_of_match);
>
> static struct spi_driver acx565akm_driver = {
> .driver = {
>
Thanks, queued for 4.3 fixes.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-09-24 10:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 18:44 [PATCH] omapdss: acx565akm: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-18 18:44 ` Luis de Bethencourt
2015-09-24 10:17 ` Tomi Valkeinen [this message]
2015-09-24 10:17 ` Tomi Valkeinen
2015-09-24 10:17 ` Tomi Valkeinen
2015-09-24 11:37 ` Tomi Valkeinen
2015-09-24 11:37 ` Tomi Valkeinen
2015-09-24 11:37 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5603CDD1.7030709@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=luis@debethencourt.com \
--cc=plagnioj@jcrosoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.