All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luis@debethencourt.com>,
	linux-kernel@vger.kernel.org
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Wolfram Sang <wsa@the-dreams.de>,
	linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: mb862xx: Fix module autoload for OF platform driver
Date: Thu, 24 Sep 2015 10:18:08 +0000	[thread overview]
Message-ID: <5603CDE0.5050708@ti.com> (raw)
In-Reply-To: <20150918184609.GA32729@goodgumbo.baconseed.org>

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]



On 18/09/15 21:46, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> index 9b8bebd..f9ec5c0 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> @@ -831,6 +831,7 @@ static struct of_device_id of_platform_mb862xx_tbl[] = {
>  	{ .compatible = "fujitsu,coral", },
>  	{ /* end */ }
>  };
> +MODULE_DEVICE_TABLE(of, of_platform_mb862xx_tbl);
>  
>  static struct platform_driver of_platform_mb862xxfb_driver = {
>  	.driver = {
> 

Thanks, queued for 4.3 fixes.

Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Luis de Bethencourt <luis@debethencourt.com>,
	<linux-kernel@vger.kernel.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
	Wolfram Sang <wsa@the-dreams.de>, <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] video: fbdev: mb862xx: Fix module autoload for OF platform driver
Date: Thu, 24 Sep 2015 13:18:08 +0300	[thread overview]
Message-ID: <5603CDE0.5050708@ti.com> (raw)
In-Reply-To: <20150918184609.GA32729@goodgumbo.baconseed.org>

[-- Attachment #1: Type: text/plain, Size: 1253 bytes --]



On 18/09/15 21:46, Luis de Bethencourt wrote:
> This platform driver has a OF device ID table but the OF module
> alias information is not created so module autoloading won't work.
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hello,
> 
> This patch adds the missing MODULE_DEVICE_TABLE() for OF to export
> that information so modules have the correct aliases built-in and
> autoloading works correctly.
> 
> A longer explanation by Javier Canillas can be found here:
> https://lkml.org/lkml/2015/7/30/519
> 
> Thanks,
> Luis
> 
>  drivers/video/fbdev/mb862xx/mb862xxfbdrv.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> index 9b8bebd..f9ec5c0 100644
> --- a/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> +++ b/drivers/video/fbdev/mb862xx/mb862xxfbdrv.c
> @@ -831,6 +831,7 @@ static struct of_device_id of_platform_mb862xx_tbl[] = {
>  	{ .compatible = "fujitsu,coral", },
>  	{ /* end */ }
>  };
> +MODULE_DEVICE_TABLE(of, of_platform_mb862xx_tbl);
>  
>  static struct platform_driver of_platform_mb862xxfb_driver = {
>  	.driver = {
> 

Thanks, queued for 4.3 fixes.

Tomi


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2015-09-24 10:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 18:46 [PATCH] video: fbdev: mb862xx: Fix module autoload for OF platform driver Luis de Bethencourt
2015-09-18 18:46 ` Luis de Bethencourt
2015-09-24 10:18 ` Tomi Valkeinen [this message]
2015-09-24 10:18   ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5603CDE0.5050708@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luis@debethencourt.com \
    --cc=plagnioj@jcrosoft.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.