* [PATCH] gnutls: cleanup buildpaths from gnutls.pc
@ 2015-09-24 11:04 wenzong.fan
2015-09-24 11:49 ` Jussi Kukkonen
0 siblings, 1 reply; 6+ messages in thread
From: wenzong.fan @ 2015-09-24 11:04 UTC (permalink / raw)
To: openembedded-core
From: Wenzong Fan <wenzong.fan@windriver.com>
* gnutls.pc:
-L/path/to/tmp/sysroots/qemux86-64/lib64 -> -L/lib64
Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
---
meta/recipes-support/gnutls/gnutls.inc | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta/recipes-support/gnutls/gnutls.inc b/meta/recipes-support/gnutls/gnutls.inc
index e9b138a..0a5e663 100644
--- a/meta/recipes-support/gnutls/gnutls.inc
+++ b/meta/recipes-support/gnutls/gnutls.inc
@@ -38,6 +38,11 @@ PACKAGECONFIG ??= "zlib"
PACKAGECONFIG[tpm] = "--with-tpm, --without-tpm, trousers"
PACKAGECONFIG[zlib] = "--with-zlib, --without-zlib, zlib"
+do_install_append() {
+ # cleanup buildpaths from gnutls.pc
+ sed -i -e 's#${STAGING_DIR_HOST}##g' ${D}${libdir}/pkgconfig/gnutls.pc
+}
+
PACKAGES =+ "${PN}-openssl ${PN}-xx"
FILES_${PN}-dev += "${bindir}/gnutls-cli-debug"
--
1.9.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc
2015-09-24 11:04 [PATCH] gnutls: cleanup buildpaths from gnutls.pc wenzong.fan
@ 2015-09-24 11:49 ` Jussi Kukkonen
2015-09-24 11:55 ` Burton, Ross
2015-09-25 4:48 ` wenzong fan
0 siblings, 2 replies; 6+ messages in thread
From: Jussi Kukkonen @ 2015-09-24 11:49 UTC (permalink / raw)
To: wenzong.fan; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 1365 bytes --]
On 24 September 2015 at 14:04, <wenzong.fan@windriver.com> wrote:
> From: Wenzong Fan <wenzong.fan@windriver.com>
>
> * gnutls.pc:
> -L/path/to/tmp/sysroots/qemux86-64/lib64 -> -L/lib64
>
I'm not seeing this problem and gnutls.pc.in file looks ok to me. Any idea
how I could reproduce this?
Jussi
Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com>
> ---
> meta/recipes-support/gnutls/gnutls.inc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-support/gnutls/gnutls.inc
> b/meta/recipes-support/gnutls/gnutls.inc
> index e9b138a..0a5e663 100644
> --- a/meta/recipes-support/gnutls/gnutls.inc
> +++ b/meta/recipes-support/gnutls/gnutls.inc
> @@ -38,6 +38,11 @@ PACKAGECONFIG ??= "zlib"
> PACKAGECONFIG[tpm] = "--with-tpm, --without-tpm, trousers"
> PACKAGECONFIG[zlib] = "--with-zlib, --without-zlib, zlib"
>
> +do_install_append() {
> + # cleanup buildpaths from gnutls.pc
> + sed -i -e 's#${STAGING_DIR_HOST}##g'
> ${D}${libdir}/pkgconfig/gnutls.pc
> +}
> +
> PACKAGES =+ "${PN}-openssl ${PN}-xx"
>
> FILES_${PN}-dev += "${bindir}/gnutls-cli-debug"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
[-- Attachment #2: Type: text/html, Size: 2356 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc
2015-09-24 11:49 ` Jussi Kukkonen
@ 2015-09-24 11:55 ` Burton, Ross
2015-09-25 10:21 ` wenzong fan
2015-09-25 4:48 ` wenzong fan
1 sibling, 1 reply; 6+ messages in thread
From: Burton, Ross @ 2015-09-24 11:55 UTC (permalink / raw)
To: wenzong fan; +Cc: Patches and discussions about the oe-core layer
[-- Attachment #1: Type: text/plain, Size: 519 bytes --]
On 24 September 2015 at 12:49, Jussi Kukkonen <jussi.kukkonen@intel.com>
wrote:
> I'm not seeing this problem and gnutls.pc.in file looks ok to me. Any
> idea how I could reproduce this?
>
Also, just sedding them out of the resulting file seems suboptimal compared
to finding out where the path is coming from and fixing that, so it would
be good to see an analysis as to where the path comes from. Last timeI
fixed a number of those it exposed real problems or bad assumptions in the
makefiles.
Ross
[-- Attachment #2: Type: text/html, Size: 995 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc
2015-09-24 11:55 ` Burton, Ross
@ 2015-09-25 10:21 ` wenzong fan
2015-09-25 10:52 ` Burton, Ross
0 siblings, 1 reply; 6+ messages in thread
From: wenzong fan @ 2015-09-25 10:21 UTC (permalink / raw)
To: Burton, Ross; +Cc: Patches and discussions about the oe-core layer
On 09/24/2015 07:55 PM, Burton, Ross wrote:
>
> On 24 September 2015 at 12:49, Jussi Kukkonen <jussi.kukkonen@intel.com
> <mailto:jussi.kukkonen@intel.com>> wrote:
>
> I'm not seeing this problem and gnutls.pc.in <http://gnutls.pc.in>
> file looks ok to me. Any idea how I could reproduce this?
>
>
> Also, just sedding them out of the resulting file seems suboptimal
> compared to finding out where the path is coming from and fixing that,
> so it would be good to see an analysis as to where the path comes from.
> Last timeI fixed a number of those it exposed real problems or bad
> assumptions in the makefiles.
>
> Ross
For this case, or such cases that use pkg-config to compute paths for
LIBS (such as zlib), they have different behaviors:
* multilib enabled build:
$ bitbake gnutls -cdevshell
$ pkg-config --libs zlib
-L/buildarea/raid5/wfan/yocto/builds/poky-build/tmp/sysroots/qemux86-64/usr/lib64
-lz
* build w/o multilib
$ bitbake gnutls -cdevshell
$ pkg-config --libs zlib
-lz
This is where the buildpaths from for target pkgconfig files. Ideally it
should be fixed from pkg-config side, but just fix it with sed is
acceptable I think if the former is impossible.
I'll investigate more about that. Do you know where the difference from?
Thanks
Wenzong
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gnutls: cleanup buildpaths from gnutls.pc
2015-09-24 11:49 ` Jussi Kukkonen
2015-09-24 11:55 ` Burton, Ross
@ 2015-09-25 4:48 ` wenzong fan
1 sibling, 0 replies; 6+ messages in thread
From: wenzong fan @ 2015-09-25 4:48 UTC (permalink / raw)
To: Jussi Kukkonen; +Cc: Patches and discussions about the oe-core layer
On 09/24/2015 07:49 PM, Jussi Kukkonen wrote:
> On 24 September 2015 at 14:04, <wenzong.fan@windriver.com
> <mailto:wenzong.fan@windriver.com>> wrote:
>
> From: Wenzong Fan <wenzong.fan@windriver.com
> <mailto:wenzong.fan@windriver.com>>
>
> * gnutls.pc:
> -L/path/to/tmp/sysroots/qemux86-64/lib64 -> -L/lib64
>
>
> I'm not seeing this problem and gnutls.pc.in <http://gnutls.pc.in> file
> looks ok to me. Any idea how I could reproduce this?
Sorry for the confusion, I'll update the commit logs.
To reproduce the issue with qemux86-64:
1. update local.conf:
MACHINE ?= "qemux86-64"
require conf/multilib.conf
MULTILIBS ?= "multilib:lib32 multilib:lib64"
DEFAULTTUNE_virtclass-multilib-lib32 ?= "x86"
DEFAULTTUNE_virtclass-multilib-lib64 ?= "x86-64"
2. run bitbake gnutls
3. check gnutls.pc:
Libs.private:
-L/buildarea/raid5/wfan/yocto/builds/poky-build/tmp/sysroots/qemux86-64/usr/lib64
-lz -lgmp
Thanks
Wenzong
>
> Jussi
>
> Signed-off-by: Wenzong Fan <wenzong.fan@windriver.com
> <mailto:wenzong.fan@windriver.com>>
> ---
> meta/recipes-support/gnutls/gnutls.inc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/meta/recipes-support/gnutls/gnutls.inc
> b/meta/recipes-support/gnutls/gnutls.inc
> index e9b138a..0a5e663 100644
> --- a/meta/recipes-support/gnutls/gnutls.inc
> +++ b/meta/recipes-support/gnutls/gnutls.inc
> @@ -38,6 +38,11 @@ PACKAGECONFIG ??= "zlib"
> PACKAGECONFIG[tpm] = "--with-tpm, --without-tpm, trousers"
> PACKAGECONFIG[zlib] = "--with-zlib, --without-zlib, zlib"
>
> +do_install_append() {
> + # cleanup buildpaths from gnutls.pc
> + sed -i -e 's#${STAGING_DIR_HOST}##g'
> ${D}${libdir}/pkgconfig/gnutls.pc
> +}
> +
> PACKAGES =+ "${PN}-openssl ${PN}-xx"
>
> FILES_${PN}-dev += "${bindir}/gnutls-cli-debug"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> <mailto:Openembedded-core@lists.openembedded.org>
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-09-25 10:53 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-24 11:04 [PATCH] gnutls: cleanup buildpaths from gnutls.pc wenzong.fan
2015-09-24 11:49 ` Jussi Kukkonen
2015-09-24 11:55 ` Burton, Ross
2015-09-25 10:21 ` wenzong fan
2015-09-25 10:52 ` Burton, Ross
2015-09-25 4:48 ` wenzong fan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.