From: Matthias Brugger <matthias.bgg@gmail.com>
To: fan.chen@mediatek.com, Mark Rutland <mark.rutland@arm.com>
Cc: srv_heupstream@mediatek.com, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Eddie Huang <eddie.huang@mediatek.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Howard Chen <howard.chen@linaro.org>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Sudeep Holla <sudeep.holla@arm.com>
Subject: Re: [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support
Date: Sun, 27 Sep 2015 16:23:23 +0200 [thread overview]
Message-ID: <5607FBDB.2070201@gmail.com> (raw)
In-Reply-To: <1440727919-34719-1-git-send-email-fan.chen@mediatek.com>
On 28/08/15 04:11, fan.chen@mediatek.com wrote:
> From: Fan Chen <fan.chen@mediatek.com>
>
> This patch adds psci comatible properties to support all mandatory
> functions of PSCI-1.0, PSCI-0.2 and PSCI-0.1, and system suspend
> can be supported in PSCI-1.0.
>
> Signed-off-by: Fan Chen <fan.chen@mediatek.com>
> ---
> Because PSCI-1.0 patches hadn't landed on mainline, this patch is
> based on three patch sets below:
> [0] http://www.spinics.net/lists/arm-kernel/msg425793.html
> PSCI: system suspend support
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
> psci/unification
> [2] http://www.spinics.net/lists/devicetree/msg82017.html
> [PATCH 0/6] drivers: firmware: psci: add basic v1.0 support
>
> Before they are merged in, this patch still works fine with psci-0.2
> support in current mainline.
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index d18ee42..b9b4205 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -95,7 +95,7 @@
> };
>
> psci {
> - compatible = "arm,psci";
> + compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
As this binding is not yet upstream, I prefer not to take the patch.
Most probably the binding will have the name you indicated, but as DTS
bindings are representing an external API, we should be really careful
in changing them.
Cheers,
Matthias
> method = "smc";
> cpu_suspend = <0x84000001>;
> cpu_off = <0x84000002>;
>
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support
Date: Sun, 27 Sep 2015 16:23:23 +0200 [thread overview]
Message-ID: <5607FBDB.2070201@gmail.com> (raw)
In-Reply-To: <1440727919-34719-1-git-send-email-fan.chen@mediatek.com>
On 28/08/15 04:11, fan.chen at mediatek.com wrote:
> From: Fan Chen <fan.chen@mediatek.com>
>
> This patch adds psci comatible properties to support all mandatory
> functions of PSCI-1.0, PSCI-0.2 and PSCI-0.1, and system suspend
> can be supported in PSCI-1.0.
>
> Signed-off-by: Fan Chen <fan.chen@mediatek.com>
> ---
> Because PSCI-1.0 patches hadn't landed on mainline, this patch is
> based on three patch sets below:
> [0] http://www.spinics.net/lists/arm-kernel/msg425793.html
> PSCI: system suspend support
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git
> psci/unification
> [2] http://www.spinics.net/lists/devicetree/msg82017.html
> [PATCH 0/6] drivers: firmware: psci: add basic v1.0 support
>
> Before they are merged in, this patch still works fine with psci-0.2
> support in current mainline.
> ---
> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> index d18ee42..b9b4205 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> @@ -95,7 +95,7 @@
> };
>
> psci {
> - compatible = "arm,psci";
> + compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
As this binding is not yet upstream, I prefer not to take the patch.
Most probably the binding will have the name you indicated, but as DTS
bindings are representing an external API, we should be really careful
in changing them.
Cheers,
Matthias
> method = "smc";
> cpu_suspend = <0x84000001>;
> cpu_off = <0x84000002>;
>
next prev parent reply other threads:[~2015-09-27 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-28 2:11 [PATCH] arm64: dts: mediatek: mt8173 PSCI-1.0 support fan.chen-NuS5LvNUpcJWk0Htik3J/w
2015-08-28 2:11 ` fan.chen
2015-08-28 2:11 ` fan.chen at mediatek.com
2015-09-27 14:23 ` Matthias Brugger [this message]
2015-09-27 14:23 ` Matthias Brugger
2015-10-27 10:52 ` Matthias Brugger
2015-10-27 10:52 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5607FBDB.2070201@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=fan.chen@mediatek.com \
--cc=galak@codeaurora.org \
--cc=howard.chen@linaro.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=srv_heupstream@mediatek.com \
--cc=sudeep.holla@arm.com \
--cc=will.deacon@arm.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.