From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: linux-nfs@vger.kernel.org,
Linux btrfs Developers List <linux-btrfs@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>, Zach Brown <zab@zabbo.net>,
Al Viro <viro@zeniv.linux.org.uk>, Chris Mason <clm@fb.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Michael Kerrisk-manpages <mtk.manpages@gmail.com>,
andros@netapp.com, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v3 8/9] vfs: copy_file_range() can do a pagecache copy with splice
Date: Mon, 28 Sep 2015 10:28:18 -0400 [thread overview]
Message-ID: <56094E82.2070800@Netapp.com> (raw)
In-Reply-To: <CALCETrWLAwNVqAiTMOmaktVY0cQkM0bX2vztXzEHm3EFYDg6zA@mail.gmail.com>
On 09/25/2015 08:14 PM, Andy Lutomirski wrote:
> On Fri, Sep 25, 2015 at 1:48 PM, Anna Schumaker
> <Anna.Schumaker@netapp.com> wrote:
>> The NFS server will need some kind offallback for filesystems that don't
>> have any kind of copy acceleration, and it should be generally useful to
>> have an in-kernel copy to avoid lots of switches between kernel and user
>> space.
>>
>> I make this configurable by adding two new flags. Users who only want a
>> reflink can pass COPY_FR_REFLINK, and users who want a full data copy can
>> pass COPY_FR_COPY. The default (flags=0) means to first attempt a
>> reflink, but use the pagecache if that fails.
>>
>
> Can you clarify how the subject line fits in? I'm a bit lost.
I'll try! I use the splice interface to copy file data from the pagecache, and this implements an in-kernel copy that can be controlled using the two flags I added.
I plan on using this in the NFS server when I add server-side copy support.
Let me know if that doesn't answer your question!
Anna
>
> --Andy
>
WARNING: multiple messages have this Message-ID (diff)
From: Anna Schumaker <Anna.Schumaker@netapp.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: <linux-nfs@vger.kernel.org>,
Linux btrfs Developers List <linux-btrfs@vger.kernel.org>,
Linux FS Devel <linux-fsdevel@vger.kernel.org>,
Linux API <linux-api@vger.kernel.org>, Zach Brown <zab@zabbo.net>,
Al Viro <viro@zeniv.linux.org.uk>, Chris Mason <clm@fb.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Michael Kerrisk-manpages <mtk.manpages@gmail.com>,
<andros@netapp.com>, Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH v3 8/9] vfs: copy_file_range() can do a pagecache copy with splice
Date: Mon, 28 Sep 2015 10:28:18 -0400 [thread overview]
Message-ID: <56094E82.2070800@Netapp.com> (raw)
In-Reply-To: <CALCETrWLAwNVqAiTMOmaktVY0cQkM0bX2vztXzEHm3EFYDg6zA@mail.gmail.com>
On 09/25/2015 08:14 PM, Andy Lutomirski wrote:
> On Fri, Sep 25, 2015 at 1:48 PM, Anna Schumaker
> <Anna.Schumaker@netapp.com> wrote:
>> The NFS server will need some kind offallback for filesystems that don't
>> have any kind of copy acceleration, and it should be generally useful to
>> have an in-kernel copy to avoid lots of switches between kernel and user
>> space.
>>
>> I make this configurable by adding two new flags. Users who only want a
>> reflink can pass COPY_FR_REFLINK, and users who want a full data copy can
>> pass COPY_FR_COPY. The default (flags=0) means to first attempt a
>> reflink, but use the pagecache if that fails.
>>
>
> Can you clarify how the subject line fits in? I'm a bit lost.
I'll try! I use the splice interface to copy file data from the pagecache, and this implements an in-kernel copy that can be controlled using the two flags I added.
I plan on using this in the NFS server when I add server-side copy support.
Let me know if that doesn't answer your question!
Anna
>
> --Andy
>
next prev parent reply other threads:[~2015-09-28 14:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-25 20:48 [PATCH v3 0/9] VFS: In-kernel copy system call Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 1/9] vfs: add copy_file_range syscall and vfs helper Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 2/9] x86: add sys_copy_file_range to syscall tables Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 3/9] btrfs: add .copy_file_range file operation Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 4/9] vfs: Copy should check len after file open mode Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 5/9] vfs: Copy shouldn't forbid ranges inside the same file Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-28 18:46 ` Darrick J. Wong
[not found] ` <1443214096-12769-1-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2015-09-25 20:48 ` [PATCH v3 6/9] vfs: Copy should use file_out rather than file_in Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 7/9] vfs: Remove copy_file_range mountpoint checks Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 8/9] vfs: copy_file_range() can do a pagecache copy with splice Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
[not found] ` <1443214096-12769-9-git-send-email-Anna.Schumaker-ZwjVKphTwtPQT0dZR+AlfA@public.gmane.org>
2015-09-25 21:58 ` Pádraig Brady
2015-09-25 21:58 ` Pádraig Brady
2015-09-28 18:31 ` Darrick J. Wong
2015-09-28 18:31 ` Darrick J. Wong
[not found] ` <20150928183152.GB850-PTl6brltDGh4DFYR7WNSRA@public.gmane.org>
2015-09-28 18:35 ` Anna Schumaker
2015-09-28 18:35 ` Anna Schumaker
2015-09-28 18:35 ` Anna Schumaker
2015-09-26 0:14 ` Andy Lutomirski
2015-09-28 14:28 ` Anna Schumaker [this message]
2015-09-28 14:28 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 9/9] btrfs: btrfs_copy_file_range() only supports reflinks Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-25 20:48 ` [PATCH v3 10/9] copy_file_range.2: New page documenting copy_file_range() Anna Schumaker
2015-09-25 20:48 ` Anna Schumaker
2015-09-28 18:40 ` Darrick J. Wong
2015-09-28 20:42 ` Anna Schumaker
2015-09-28 20:42 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56094E82.2070800@Netapp.com \
--to=anna.schumaker@netapp.com \
--cc=andros@netapp.com \
--cc=clm@fb.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mtk.manpages@gmail.com \
--cc=viro@zeniv.linux.org.uk \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.