All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Snow <jsnow@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>, qemu-trivial@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	qemu-block@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 06/10][TRIVIAL] macio-ide: add to storage category
Date: Mon, 28 Sep 2015 10:29:46 -0400	[thread overview]
Message-ID: <56094EDA.6080505@redhat.com> (raw)
In-Reply-To: <1443284532-8634-7-git-send-email-laurent@vivier.eu>



On 09/26/2015 12:22 PM, Laurent Vivier wrote:
> macio-ide is an IDE controller, so add it
> to the storage category.
> 
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  hw/ide/macio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ide/macio.c b/hw/ide/macio.c
> index 66ac2ba..893c9b9 100644
> --- a/hw/ide/macio.c
> +++ b/hw/ide/macio.c
> @@ -590,6 +590,7 @@ static void macio_ide_class_init(ObjectClass *oc, void *data)
>      dc->realize = macio_ide_realizefn;
>      dc->reset = macio_ide_reset;
>      dc->vmsd = &vmstate_pmac;
> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>  }
>  
>  static const TypeInfo macio_ide_type_info = {
> 

Thanks,

Reviewed-by: John Snow <jsnow@redhat.com>

I'll leave this to be staged by whomever stages the entire series.

--js


WARNING: multiple messages have this Message-ID (diff)
From: John Snow <jsnow@redhat.com>
To: Laurent Vivier <laurent@vivier.eu>, qemu-trivial@nongnu.org
Cc: Paolo Bonzini <pbonzini@redhat.com>,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	qemu-block@nongnu.org, Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] [PATCH 06/10][TRIVIAL] macio-ide: add to storage category
Date: Mon, 28 Sep 2015 10:29:46 -0400	[thread overview]
Message-ID: <56094EDA.6080505@redhat.com> (raw)
In-Reply-To: <1443284532-8634-7-git-send-email-laurent@vivier.eu>



On 09/26/2015 12:22 PM, Laurent Vivier wrote:
> macio-ide is an IDE controller, so add it
> to the storage category.
> 
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
>  hw/ide/macio.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/ide/macio.c b/hw/ide/macio.c
> index 66ac2ba..893c9b9 100644
> --- a/hw/ide/macio.c
> +++ b/hw/ide/macio.c
> @@ -590,6 +590,7 @@ static void macio_ide_class_init(ObjectClass *oc, void *data)
>      dc->realize = macio_ide_realizefn;
>      dc->reset = macio_ide_reset;
>      dc->vmsd = &vmstate_pmac;
> +    set_bit(DEVICE_CATEGORY_STORAGE, dc->categories);
>  }
>  
>  static const TypeInfo macio_ide_type_info = {
> 

Thanks,

Reviewed-by: John Snow <jsnow@redhat.com>

I'll leave this to be staged by whomever stages the entire series.

--js

  parent reply	other threads:[~2015-09-29  9:49 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-26 16:22 [Qemu-trivial] [PATCH 00/10][TRIVIAL] Define categories for some PPC devices Laurent Vivier
2015-09-26 16:22 ` [Qemu-devel] " Laurent Vivier
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 01/10][TRIVIAL] adb: add to input category Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 10:44   ` [Qemu-trivial] " Thomas Huth
2015-09-28 10:44     ` Thomas Huth
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 02/10][TRIVIAL] cmd646: add to storage category Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 10:46   ` [Qemu-trivial] " Thomas Huth
2015-09-28 10:46     ` Thomas Huth
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 03/10][TRIVIAL] escc: add to input category Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 10:47   ` [Qemu-trivial] " Thomas Huth
2015-09-28 10:47     ` Thomas Huth
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 04/10][TRIVIAL] grackle: add to bridge category Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 10:57   ` [Qemu-trivial] " Thomas Huth
2015-09-28 10:57     ` Thomas Huth
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 05/10][TRIVIAL] cuda: " Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 06/10][TRIVIAL] macio-ide: add to storage category Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 10:48   ` [Qemu-trivial] " Thomas Huth
2015-09-28 10:48     ` Thomas Huth
2015-09-28 14:29   ` John Snow [this message]
2015-09-28 14:29     ` John Snow
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 07/10][TRIVIAL] uninorth: add to bridge category Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 11:04   ` [Qemu-trivial] " Thomas Huth
2015-09-28 11:04     ` Thomas Huth
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 08/10][TRIVIAL] macio: " Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 11:05   ` [Qemu-trivial] " Thomas Huth
2015-09-28 11:05     ` Thomas Huth
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 09/10][TRIVIAL] macio-nvram: add to misc category Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 11:05   ` [Qemu-trivial] " Thomas Huth
2015-09-28 11:05     ` Thomas Huth
2015-09-26 16:22 ` [Qemu-trivial] [PATCH 10/10][TRIVIAL] openpic: " Laurent Vivier
2015-09-26 16:22   ` [Qemu-devel] " Laurent Vivier
2015-09-28 11:06   ` [Qemu-trivial] " Thomas Huth
2015-09-28 11:06     ` Thomas Huth
2015-09-30  5:58 ` [Qemu-trivial] [Qemu-ppc] [PATCH 00/10][TRIVIAL] Define categories for some PPC devices David Gibson
2015-09-30  5:58   ` [Qemu-devel] " David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56094EDA.6080505@redhat.com \
    --to=jsnow@redhat.com \
    --cc=agraf@suse.de \
    --cc=laurent@vivier.eu \
    --cc=pbonzini@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.