All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Wise <swise@opengridcomputing.com>
To: trond.myklebust@primarydata.com, bfields@fieldses.org
Cc: linux-nfs@vger.kernel.org, linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers
Date: Mon, 28 Sep 2015 09:30:46 -0500	[thread overview]
Message-ID: <56094F16.3040608@opengridcomputing.com> (raw)
In-Reply-To: <20150921172423.9761.92399.stgit@build2.ogc.int>

On 9/21/2015 12:24 PM, Steve Wise wrote:
> Otherwise a FRMR completion can cause a touch-after-free crash.
>
> In xprt_rdma_destroy(), call rpcrdma_buffer_destroy() only after calling
> rpcrdma_ep_destroy().
>
> In rpcrdma_ep_destroy(), disconnect the cm_id first which should flush the
> qp, then drain the cqs, then destroy the qp, and finally destroy the cqs.
>
> Signed-off-by: Steve Wise <swise@opengridcomputing.com>
> Tested-by: Chuck Lever <chuck.lever@oracle.com>
> ---

Hey Trond,  I'm hoping this can make 4.3-rc (and stable if you agree).

Thanks,

Steve.


WARNING: multiple messages have this Message-ID (diff)
From: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
To: trond.myklebust-7I+n7zu2hftEKMMhf/gKZA@public.gmane.org,
	bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org
Cc: linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers
Date: Mon, 28 Sep 2015 09:30:46 -0500	[thread overview]
Message-ID: <56094F16.3040608@opengridcomputing.com> (raw)
In-Reply-To: <20150921172423.9761.92399.stgit-PBeJgSbIpn97NCTnQtmixQ@public.gmane.org>

On 9/21/2015 12:24 PM, Steve Wise wrote:
> Otherwise a FRMR completion can cause a touch-after-free crash.
>
> In xprt_rdma_destroy(), call rpcrdma_buffer_destroy() only after calling
> rpcrdma_ep_destroy().
>
> In rpcrdma_ep_destroy(), disconnect the cm_id first which should flush the
> qp, then drain the cqs, then destroy the qp, and finally destroy the cqs.
>
> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> Tested-by: Chuck Lever <chuck.lever-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---

Hey Trond,  I'm hoping this can make 4.3-rc (and stable if you agree).

Thanks,

Steve.

--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2015-09-28 14:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-21 17:24 [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers Steve Wise
2015-09-21 17:24 ` Steve Wise
2015-09-21 17:24 ` [PATCH 2/3] svcrdma: handle rdma read with a non-zero initial page offset Steve Wise
2015-09-21 17:24   ` Steve Wise
2015-09-28 14:31   ` Steve Wise
2015-09-28 14:31     ` Steve Wise
2015-09-28 21:04     ` J. Bruce Fields
2015-09-28 21:04       ` J. Bruce Fields
2015-09-28 21:49       ` Steve Wise
2015-09-28 21:49         ` Steve Wise
2015-09-29 15:40         ` 'J. Bruce Fields'
2015-09-29 15:40           ` 'J. Bruce Fields'
2015-09-21 17:24 ` [PATCH 3/3] xprtrdma: don't log warnings for flushed completions Steve Wise
2015-09-21 17:24   ` Steve Wise
2015-09-28 14:30 ` Steve Wise [this message]
2015-09-28 14:30   ` [PATCH 1/3] xprtrdma: disconnect and flush cqs before freeing buffers Steve Wise
2015-09-28 14:45   ` Anna Schumaker
2015-09-28 14:45     ` Anna Schumaker
2015-09-28 14:50     ` Steve Wise
2015-09-28 14:50       ` Steve Wise
2015-09-28 14:57       ` Anna Schumaker
2015-09-28 14:57         ` Anna Schumaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56094F16.3040608@opengridcomputing.com \
    --to=swise@opengridcomputing.com \
    --cc=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.