From: Dave Hansen <dave@sr71.net>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] e1000: fix e1000e_disable_aspm_locked() warning
Date: Mon, 28 Sep 2015 08:57:18 -0700 [thread overview]
Message-ID: <5609635E.6010907@sr71.net> (raw)
In-Reply-To: <20150831212641.FA5D579A@viggo.jf.intel.com>
On 08/31/2015 02:26 PM, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> I have a .config with CONFIG_PM disabled. I get the following whenever
> compiling the e1000 driver:
>
> ...net/ethernet/intel/e1000e/netdev.c:6450:13: warning: 'e1000e_disable_aspm_locked' defined but not used [-Wunused-function]
> static void e1000e_disable_aspm_locked(struct pci_dev *pdev, u16 state)
>
> Looks like we just need to move e1000e_disable_aspm_locked() to
> be underneath the CONFIG_PM #ifdef.
This patch:
[2758f9edb]: e1000e: Fix incorrect ASPM locking
established a new caller for e1000e_disable_aspm_locked() which makes my
patch useless and wrong (it breaks the compile).
I believe we should just revert my patch.
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: raanan.avargil@intel.com
Cc: dave.hansen@linux.intel.com, jeffrey.t.kirsher@intel.com,
jesse.brandeburg@intel.com, shannon.nelson@intel.com,
carolyn.wyborny@intel.com, donald.c.skidmore@intel.com,
matthew.vick@intel.com, john.ronciak@intel.com,
mitch.a.williams@intel.com, intel-wired-lan@lists.osuosl.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] e1000: fix e1000e_disable_aspm_locked() warning
Date: Mon, 28 Sep 2015 08:57:18 -0700 [thread overview]
Message-ID: <5609635E.6010907@sr71.net> (raw)
In-Reply-To: <20150831212641.FA5D579A@viggo.jf.intel.com>
On 08/31/2015 02:26 PM, Dave Hansen wrote:
> From: Dave Hansen <dave.hansen@linux.intel.com>
>
> I have a .config with CONFIG_PM disabled. I get the following whenever
> compiling the e1000 driver:
>
> ...net/ethernet/intel/e1000e/netdev.c:6450:13: warning: 'e1000e_disable_aspm_locked' defined but not used [-Wunused-function]
> static void e1000e_disable_aspm_locked(struct pci_dev *pdev, u16 state)
>
> Looks like we just need to move e1000e_disable_aspm_locked() to
> be underneath the CONFIG_PM #ifdef.
This patch:
[2758f9edb]: e1000e: Fix incorrect ASPM locking
established a new caller for e1000e_disable_aspm_locked() which makes my
patch useless and wrong (it breaks the compile).
I believe we should just revert my patch.
next prev parent reply other threads:[~2015-09-28 15:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-31 21:26 [Intel-wired-lan] [PATCH] e1000: fix e1000e_disable_aspm_locked() warning Dave Hansen
2015-08-31 21:26 ` Dave Hansen
2015-09-28 15:57 ` Dave Hansen [this message]
2015-09-28 15:57 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5609635E.6010907@sr71.net \
--to=dave@sr71.net \
--cc=intel-wired-lan@osuosl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.