All of lore.kernel.org
 help / color / mirror / Atom feed
From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: dts: sun6i: Turn on gmac on Colombus
Date: Tue, 29 Sep 2015 22:10:20 +0200	[thread overview]
Message-ID: <560AF02C.2010308@redhat.com> (raw)
In-Reply-To: <20150820221259.GM30520@lukather>

Hi,

On 08/21/2015 12:12 AM, Maxime Ripard wrote:
> On Thu, Aug 20, 2015 at 08:23:27AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 08/19/2015 05:17 PM, Maxime Ripard wrote:
>>> On Fri, Aug 07, 2015 at 05:22:34PM +0200, Hans de Goede wrote:
>>>> We've everything we need to support the gmac on Colombus, turn it on.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> I recall that the phy was powered by one of the AXP221 regulators,
>>> does it require some additional stuff (like a recent u-boot), or does
>>> it just work and my memory is bad :) ?
>>
>> I think it just works, it MAY be connected to aldo1 but according to
>> the git history for the u-boot defconfig that one is used for wifi not
>> for the gmac, and we do not enable any other "spare" regulators in the
>> u-boot config.
>>
>> I do not have any schematics, so no way to say for sure.
>>
>> I can confirm that the GMAC work fine with the latest u-boot
>> master. Looking in the history we've always enabled ALDO1
>> on the Colombus in upstream u-boot, so this should all just work.
>
> Except that if it is the case, the DT was working fine with the stock
> bootloader, and it doesn't anymore, while we have no way to upgrade
> it.

Ok, I've finally made some time to test this, the gmac works fine
with aldo1 disabled, so I believe this patch can be merged as is.

Regards,

Hans

WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Maxime Ripard
	<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [PATCH 2/3] ARM: dts: sun6i: Turn on gmac on Colombus
Date: Tue, 29 Sep 2015 22:10:20 +0200	[thread overview]
Message-ID: <560AF02C.2010308@redhat.com> (raw)
In-Reply-To: <20150820221259.GM30520@lukather>

Hi,

On 08/21/2015 12:12 AM, Maxime Ripard wrote:
> On Thu, Aug 20, 2015 at 08:23:27AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 08/19/2015 05:17 PM, Maxime Ripard wrote:
>>> On Fri, Aug 07, 2015 at 05:22:34PM +0200, Hans de Goede wrote:
>>>> We've everything we need to support the gmac on Colombus, turn it on.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>>
>>> I recall that the phy was powered by one of the AXP221 regulators,
>>> does it require some additional stuff (like a recent u-boot), or does
>>> it just work and my memory is bad :) ?
>>
>> I think it just works, it MAY be connected to aldo1 but according to
>> the git history for the u-boot defconfig that one is used for wifi not
>> for the gmac, and we do not enable any other "spare" regulators in the
>> u-boot config.
>>
>> I do not have any schematics, so no way to say for sure.
>>
>> I can confirm that the GMAC work fine with the latest u-boot
>> master. Looking in the history we've always enabled ALDO1
>> on the Colombus in upstream u-boot, so this should all just work.
>
> Except that if it is the case, the DT was working fine with the stock
> bootloader, and it doesn't anymore, while we have no way to upgrade
> it.

Ok, I've finally made some time to test this, the gmac works fine
with aldo1 disabled, so I believe this patch can be merged as is.

Regards,

Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2015-09-29 20:10 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-07 15:22 [PATCH 1/3] ARM: dts: sun5i: Add support for the Auxtek-T003 HDMI stick Hans de Goede
2015-08-07 15:22 ` Hans de Goede
2015-08-07 15:22 ` [PATCH 2/3] ARM: dts: sun6i: Turn on gmac on Colombus Hans de Goede
2015-08-07 15:22   ` Hans de Goede
2015-08-19 15:17   ` Maxime Ripard
2015-08-19 15:17     ` Maxime Ripard
2015-08-19 15:29     ` [linux-sunxi] " Chen-Yu Tsai
2015-08-19 15:29       ` Chen-Yu Tsai
2015-08-20  6:23     ` Hans de Goede
2015-08-20  6:23       ` Hans de Goede
2015-08-20 14:54       ` [linux-sunxi] " Chen-Yu Tsai
2015-08-20 14:54         ` Chen-Yu Tsai
2015-08-20 22:12       ` Maxime Ripard
2015-08-20 22:12         ` Maxime Ripard
2015-09-29 20:10         ` Hans de Goede [this message]
2015-09-29 20:10           ` Hans de Goede
2015-08-07 15:22 ` [PATCH 3/3] ARM: dts: sun6i: Columbus: Add i2c controller for communicating with the LCD Hans de Goede
2015-08-07 15:22   ` Hans de Goede
2015-08-19 15:10   ` Maxime Ripard
2015-08-19 15:10     ` Maxime Ripard
2015-08-24 11:16 ` [PATCH 1/3] ARM: dts: sun5i: Add support for the Auxtek-T003 HDMI stick Maxime Ripard
2015-08-24 11:16   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560AF02C.2010308@redhat.com \
    --to=hdegoede@redhat.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.