* [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()
@ 2015-09-30 9:33 ` Xishi Qiu
0 siblings, 0 replies; 8+ messages in thread
From: Xishi Qiu @ 2015-09-30 9:33 UTC (permalink / raw)
To: Andrew Morton, Mel Gorman, Tang Chen, zhongjiang,
Yasuaki Ishimatsu, Zhang Yanfei
Cc: Linux MM, LKML
If user set "movablecore=xx" to a large number, corepages will overflow,
this patch fix the problem.
Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
---
mm/page_alloc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 48aaf7b..af3c9bd 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
*/
required_movablecore =
roundup(required_movablecore, MAX_ORDER_NR_PAGES);
+ required_movablecore = min(totalpages, required_movablecore);
corepages = totalpages - required_movablecore;
required_kernelcore = max(required_kernelcore, corepages);
--
2.0.0
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()
2015-09-30 9:33 ` Xishi Qiu
@ 2015-09-30 10:31 ` Tang Chen
-1 siblings, 0 replies; 8+ messages in thread
From: Tang Chen @ 2015-09-30 10:31 UTC (permalink / raw)
To: Xishi Qiu, Andrew Morton, Mel Gorman, zhongjiang,
Yasuaki Ishimatsu, Zhang Yanfei
Cc: Linux MM, LKML, tangchen
Seems OK to me.
Thanks.
On 09/30/2015 05:33 PM, Xishi Qiu wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
> mm/page_alloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 48aaf7b..af3c9bd 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
> */
> required_movablecore =
> roundup(required_movablecore, MAX_ORDER_NR_PAGES);
> + required_movablecore = min(totalpages, required_movablecore);
> corepages = totalpages - required_movablecore;
>
> required_kernelcore = max(required_kernelcore, corepages);
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()
@ 2015-09-30 10:31 ` Tang Chen
0 siblings, 0 replies; 8+ messages in thread
From: Tang Chen @ 2015-09-30 10:31 UTC (permalink / raw)
To: Xishi Qiu, Andrew Morton, Mel Gorman, zhongjiang,
Yasuaki Ishimatsu, Zhang Yanfei
Cc: Linux MM, LKML, tangchen
Seems OK to me.
Thanks.
On 09/30/2015 05:33 PM, Xishi Qiu wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
> mm/page_alloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 48aaf7b..af3c9bd 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
> */
> required_movablecore =
> roundup(required_movablecore, MAX_ORDER_NR_PAGES);
> + required_movablecore = min(totalpages, required_movablecore);
> corepages = totalpages - required_movablecore;
>
> required_kernelcore = max(required_kernelcore, corepages);
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()
2015-09-30 9:33 ` Xishi Qiu
@ 2015-09-30 21:03 ` David Rientjes
-1 siblings, 0 replies; 8+ messages in thread
From: David Rientjes @ 2015-09-30 21:03 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, Mel Gorman, Tang Chen, zhongjiang,
Yasuaki Ishimatsu, Zhang Yanfei, Linux MM, LKML
On Wed, 30 Sep 2015, Xishi Qiu wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Acked-by: David Rientjes <rientjes@google.com>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()
@ 2015-09-30 21:03 ` David Rientjes
0 siblings, 0 replies; 8+ messages in thread
From: David Rientjes @ 2015-09-30 21:03 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, Mel Gorman, Tang Chen, zhongjiang,
Yasuaki Ishimatsu, Zhang Yanfei, Linux MM, LKML
On Wed, 30 Sep 2015, Xishi Qiu wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()
2015-09-30 9:33 ` Xishi Qiu
@ 2015-10-01 20:02 ` Yasuaki Ishimatsu
-1 siblings, 0 replies; 8+ messages in thread
From: Yasuaki Ishimatsu @ 2015-10-01 20:02 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, Mel Gorman, Tang Chen, zhongjiang,
Yasuaki Ishimatsu, Zhang Yanfei, Linux MM, LKML
On Wed, 30 Sep 2015 17:33:42 +0800
Xishi Qiu <qiuxishi@huawei.com> wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
Looks good to me.
Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thanks,
Yasuaki Ishimatsu
> mm/page_alloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 48aaf7b..af3c9bd 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
> */
> required_movablecore =
> roundup(required_movablecore, MAX_ORDER_NR_PAGES);
> + required_movablecore = min(totalpages, required_movablecore);
> corepages = totalpages - required_movablecore;
>
> required_kernelcore = max(required_kernelcore, corepages);
> --
> 2.0.0
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] mm: fix overflow in find_zone_movable_pfns_for_nodes()
@ 2015-10-01 20:02 ` Yasuaki Ishimatsu
0 siblings, 0 replies; 8+ messages in thread
From: Yasuaki Ishimatsu @ 2015-10-01 20:02 UTC (permalink / raw)
To: Xishi Qiu
Cc: Andrew Morton, Mel Gorman, Tang Chen, zhongjiang,
Yasuaki Ishimatsu, Zhang Yanfei, Linux MM, LKML
On Wed, 30 Sep 2015 17:33:42 +0800
Xishi Qiu <qiuxishi@huawei.com> wrote:
> If user set "movablecore=xx" to a large number, corepages will overflow,
> this patch fix the problem.
>
> Signed-off-by: Xishi Qiu <qiuxishi@huawei.com>
> ---
Looks good to me.
Reviewed-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Thanks,
Yasuaki Ishimatsu
> mm/page_alloc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/mm/page_alloc.c b/mm/page_alloc.c
> index 48aaf7b..af3c9bd 100644
> --- a/mm/page_alloc.c
> +++ b/mm/page_alloc.c
> @@ -5668,6 +5668,7 @@ static void __init find_zone_movable_pfns_for_nodes(void)
> */
> required_movablecore =
> roundup(required_movablecore, MAX_ORDER_NR_PAGES);
> + required_movablecore = min(totalpages, required_movablecore);
> corepages = totalpages - required_movablecore;
>
> required_kernelcore = max(required_kernelcore, corepages);
> --
> 2.0.0
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 8+ messages in thread