From: Lokesh Vutla <a0131933@ti.com>
To: Felipe Balbi <balbi@ti.com>, Tony Lindgren <tony@atomide.com>
Cc: Nishanth Menon <nm@ti.com>,
Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
Linux ARM Kernel Mailing List
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCHv4] arm: omap2: timer: always define omap4_local_timer_init
Date: Wed, 30 Sep 2015 15:11:54 +0530 [thread overview]
Message-ID: <560BAE62.9000503@ti.com> (raw)
In-Reply-To: <560B9210.1080700@ti.com>
On Wednesday 30 September 2015 01:11 PM, Lokesh Vutla wrote:
> Hi Felipe,
>
> On Tuesday 29 September 2015 09:45 PM, Felipe Balbi wrote:
>> omap4_local_timer_init() can be used by other
>> platforms as is. At least AM437x wants to use
>> it. Instead of making omap4-only and providing
>> a stub for builds without OMAP4, we can just
>> make sure that function is always available
>> for all SoCs that need it.
> You might also want to update init_time function pointer for AM43xx in
> board_generic.c or is there any dependency for this patch? With this
> patch alone AM43xx only build is broken.
>
> arch/arm/mach-omap2/built-in.o:(.arch.info.init+0x54): undefined
> reference to `omap3_gptimer_timer_init'
> Makefile:944: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
I think the following series needs to be applied.
http://www.mail-archive.com/linux-omap%40vger.kernel.org/msg119840.html
Sorry for the noise.
Thanks and regards,
Lokesh
WARNING: multiple messages have this Message-ID (diff)
From: a0131933@ti.com (Lokesh Vutla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv4] arm: omap2: timer: always define omap4_local_timer_init
Date: Wed, 30 Sep 2015 15:11:54 +0530 [thread overview]
Message-ID: <560BAE62.9000503@ti.com> (raw)
In-Reply-To: <560B9210.1080700@ti.com>
On Wednesday 30 September 2015 01:11 PM, Lokesh Vutla wrote:
> Hi Felipe,
>
> On Tuesday 29 September 2015 09:45 PM, Felipe Balbi wrote:
>> omap4_local_timer_init() can be used by other
>> platforms as is. At least AM437x wants to use
>> it. Instead of making omap4-only and providing
>> a stub for builds without OMAP4, we can just
>> make sure that function is always available
>> for all SoCs that need it.
> You might also want to update init_time function pointer for AM43xx in
> board_generic.c or is there any dependency for this patch? With this
> patch alone AM43xx only build is broken.
>
> arch/arm/mach-omap2/built-in.o:(.arch.info.init+0x54): undefined
> reference to `omap3_gptimer_timer_init'
> Makefile:944: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
I think the following series needs to be applied.
http://www.mail-archive.com/linux-omap%40vger.kernel.org/msg119840.html
Sorry for the noise.
Thanks and regards,
Lokesh
next prev parent reply other threads:[~2015-09-30 9:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 16:15 [PATCHv4] arm: omap2: timer: always define omap4_local_timer_init Felipe Balbi
2015-09-29 16:15 ` Felipe Balbi
2015-09-29 16:17 ` Nishanth Menon
2015-09-29 16:17 ` Nishanth Menon
2015-09-30 7:41 ` Lokesh Vutla
2015-09-30 7:41 ` Lokesh Vutla
2015-09-30 9:41 ` Lokesh Vutla [this message]
2015-09-30 9:41 ` Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560BAE62.9000503@ti.com \
--to=a0131933@ti.com \
--cc=balbi@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.