Re: [PATCH] toaster: orm Machines filter don't pass self in as parameter

[Michael Wood <michael.g.wood@intel.com>]

On 30/09/15 10:21, Barros Pena, Belen wrote:
>
> On 29/09/2015 17:18, "toaster-bounces@yoctoproject.org on behalf of
> Michael Wood" <toaster-bounces@yoctoproject.org on behalf of
> michael.g.wood@intel.com> wrote:
>
>> Fix typo don't pass self in as a parameter, this evaluated to true
>> giving the wrong results meaning the machines typeahead did not return
>> valid results.
> I am not sure if it is connected to this problem, but I can only set
> machines if I select one of the type ahead suggestions. This is not the
> correct behaviour. Machines are like build targets: we can never be sure
> that Toaster knows of all valid options. Therefore, we need to allow free
> text entry.

This is controlled by the project page so not related to this. Feel free 
to open a bug.


> Right now, if type some random string in the machine field then click
> 'save', Toaster reverts to the previous value and refuses to take the new
> one. This also means that, for a local project, where we don't have any
> information about machines, it is impossible to change the machine value.
>
> Cheers,
>
> Belén
>
>> Signed-off-by: Michael Wood <michael.g.wood@intel.com>
>> ---
>> bitbake/lib/toaster/orm/models.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/bitbake/lib/toaster/orm/models.py
>> b/bitbake/lib/toaster/orm/models.py
>> index 5aed158..f5529e2 100644
>> --- a/bitbake/lib/toaster/orm/models.py
>> +++ b/bitbake/lib/toaster/orm/models.py
>> @@ -229,7 +229,7 @@ class Project(models.Model):
>>          """ Returns QuerySet of all Machines which are provided by the
>>          Layers currently added to the Project """
>>          queryset = Machine.objects.filter(
>> -            layer_version__in=self.get_project_layer_versions(self))
>> +            layer_version__in=self.get_project_layer_versions())
>>
>>          return queryset
>>
>> -- 
>> 2.1.4
>>
>> -- 
>> _______________________________________________
>> toaster mailing list
>> toaster@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/toaster