From: Razvan Cojocaru <rcojocaru@bitdefender.com>
To: Jan Beulich <JBeulich@suse.com>, Julien Grall <julien.grall@citrix.com>
Cc: keir@xen.org, tim@xen.org, ian.jackson@eu.citrix.com,
ian.campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] xen: Bump __XEN_LATEST_INTERFACE_VERSION__ to 0x00040700
Date: Wed, 30 Sep 2015 18:38:26 +0300 [thread overview]
Message-ID: <560C01F2.9040002@bitdefender.com> (raw)
In-Reply-To: <560C1D3702000078000A730F@prv-mh.provo.novell.com>
On 09/30/2015 06:34 PM, Jan Beulich wrote:
>>>> On 30.09.15 at 17:28, <rcojocaru@bitdefender.com> wrote:
>> On 09/30/2015 06:25 PM, Julien Grall wrote:
>>> Hi,
>>>
>>> On 30/09/15 16:16, Razvan Cojocaru wrote:
>>>> VM_EVENT_FLAG_SET_REGISTERS and xc_monitor_emulate_each_rep() are
>>>> not available in Xen 4.6, hence the bump.
>>>
>>> Shouldn't you bump XEN_DOMCTL_INTERFACE_VERSION and
>>> VM_EVENT_INTERFACE_VERSION instead?
>>>
>>> The former for xc_monitor_emulate_each_read as it's a DOMCTL and the
>>> latter for VM_EVENT_FLAG_SET_REGISTERS?
>>
>> Yes, judging also by Jan's previous comment that would appear to be the
>> preferred way to go.
>
> I can't talk about VM_EVENT_INTERFACE_VERSION, but I also
> don't see any reason to bump XEN_DOMCTL_INTERFACE_VERSION
> with the given change. Again - it's just an addition to the interface,
> not an incompatible change.
The same is true for VM_EVENT_FLAG_SET_REGISTERS I'm afraid. Nothing at
all changes for existing vm_event users. In that case, I'll just leave
them all alone.
But the question still remains, if these markers are unreliable in my
case, could you please suggest another which I can check in my scenario?
__XEN_LATEST_INTERFACE_VERSION__ has been fine so far, but I now see
that this has only been a coincidence.
Thanks,
Razvan
prev parent reply other threads:[~2015-09-30 15:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 15:16 [PATCH] xen: Bump __XEN_LATEST_INTERFACE_VERSION__ to 0x00040700 Razvan Cojocaru
2015-09-30 15:23 ` Jan Beulich
2015-09-30 15:27 ` Razvan Cojocaru
2015-09-30 15:39 ` Jan Beulich
2015-09-30 15:46 ` Razvan Cojocaru
2015-09-30 15:25 ` Julien Grall
2015-09-30 15:28 ` Razvan Cojocaru
2015-09-30 15:34 ` Jan Beulich
2015-09-30 15:38 ` Razvan Cojocaru [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560C01F2.9040002@bitdefender.com \
--to=rcojocaru@bitdefender.com \
--cc=JBeulich@suse.com \
--cc=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=julien.grall@citrix.com \
--cc=keir@xen.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.