All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@citrix.com>
To: Doug Goldstein <cardoe@cardoe.com>,
	Ian Campbell <ian.campbell@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Jan Beulich <jbeulich@suse.com>, Keir Fraser <keir@xen.org>,
	Tim Deegan <tim@xen.org>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] build: drop unused SUBARCH variable
Date: Wed, 30 Sep 2015 19:02:23 +0100	[thread overview]
Message-ID: <560C23AF.5090604@citrix.com> (raw)
In-Reply-To: <560C22B8.30907@cardoe.com>

On 30/09/15 18:58, Doug Goldstein wrote:
> On 9/18/15 1:41 PM, Doug Goldstein wrote:
>> This variable appears to be unused throughout the code base.
>>
>> Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
>> ---
>>  Makefile | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/Makefile b/Makefile
>> index 75177f0..8a9331f 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir
>>  		$(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \
>>  	fi
>>  
>> -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH))
>> -export XEN_TARGET_ARCH SUBARCH
>> +export XEN_TARGET_ARCH
>>  export DESTDIR
>>  
>>  # build and install everything into the standard system directories
>>
> 
> ping?

Jan tends to not notify when a patch has been committed. It's in the
tree since last week:

commit 063792541db41167db9467feadb700de64cfcd16
Author: Doug Goldstein <cardoe@cardoe.com>
Date:   Mon Sep 21 16:14:19 2015 +0200

    build: drop unused SUBARCH variable

    This variable appears to be unused throughout the code base.

    Signed-off-by: Doug Goldstein <cardoe@cardoe.com>

Regards,

-- 
Julien Grall

  reply	other threads:[~2015-09-30 18:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 18:41 [PATCH] build: drop unused SUBARCH variable Doug Goldstein
2015-09-30 17:58 ` Doug Goldstein
2015-09-30 18:02   ` Julien Grall [this message]
2015-10-05 13:37     ` Ian Jackson
2015-10-08 18:55       ` Julien Grall
2015-10-01  6:44   ` Jan Beulich
2015-10-01  8:55     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=560C23AF.5090604@citrix.com \
    --to=julien.grall@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=ian.campbell@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=jbeulich@suse.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.