All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <ian.campbell@citrix.com>
To: Jan Beulich <JBeulich@suse.com>, Doug Goldstein <cardoe@cardoe.com>
Cc: Keir Fraser <keir@xen.org>, Tim Deegan <tim@xen.org>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	xen-devel@lists.xen.org
Subject: Re: [PATCH] build: drop unused SUBARCH variable
Date: Thu, 1 Oct 2015 09:55:24 +0100	[thread overview]
Message-ID: <1443689724.16718.227.camel@citrix.com> (raw)
In-Reply-To: <560CF25002000078000A74EE@prv-mh.provo.novell.com>

On Thu, 2015-10-01 at 00:44 -0600, Jan Beulich wrote:
> > > > On 30.09.15 at 19:58, <cardoe@cardoe.com> wrote:
> > On 9/18/15 1:41 PM, Doug Goldstein wrote:
> > > This variable appears to be unused throughout the code base.
> > > 
> > > Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
> > > ---
> > >  Makefile | 3 +--
> > >  1 file changed, 1 insertion(+), 2 deletions(-)
> > > 
> > > diff --git a/Makefile b/Makefile
> > > index 75177f0..8a9331f 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -35,8 +35,7 @@ mini-os-dir-force-update: mini-os-dir
> > >  		$(GIT) reset --hard $(MINIOS_UPSTREAM_REVISION); \
> > >  	fi
> > >  
> > > -SUBARCH := $(subst x86_32,i386,$(XEN_TARGET_ARCH))
> > > -export XEN_TARGET_ARCH SUBARCH
> > > +export XEN_TARGET_ARCH
> > >  export DESTDIR
> > >  
> > >  # build and install everything into the standard system directories
> > > 
> > 
> > ping?
> 
> This was applied over a week ago. Did you check the tree before
> pinging?

I've updated http://wiki.xen.org/wiki/Submitting_Xen_Project_Patches to
mention that people should check staging.

Ian.

      reply	other threads:[~2015-10-01  8:55 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-18 18:41 [PATCH] build: drop unused SUBARCH variable Doug Goldstein
2015-09-30 17:58 ` Doug Goldstein
2015-09-30 18:02   ` Julien Grall
2015-10-05 13:37     ` Ian Jackson
2015-10-08 18:55       ` Julien Grall
2015-10-01  6:44   ` Jan Beulich
2015-10-01  8:55     ` Ian Campbell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443689724.16718.227.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=JBeulich@suse.com \
    --cc=cardoe@cardoe.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=keir@xen.org \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.