From: Jacek Anaszewski <j.anaszewski@samsung.com>
To: Maciek Borzecki <maciek.borzecki@gmail.com>
Cc: linux-kernel@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
linux-leds@vger.kernel.org, linux-doc@vger.kernel.org,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 2/3] leds: add debugfs to device trigger
Date: Thu, 01 Oct 2015 09:36:00 +0200 [thread overview]
Message-ID: <560CE260.1000404@samsung.com> (raw)
In-Reply-To: <20150930154754.GA31149@corsair.lan>
On 09/30/2015 05:47 PM, Maciek Borzecki wrote:
> On 09/30 16:08, Jacek Anaszewski wrote:
>> Hi Maciek,
>>
>> Please test your solution thoroughly before submitting
>> the next version. Writing to debugfs register attribute
>> fails due to lack of proper copying from user memory,
>> which makes testing impossible.
>
> Hi, thanks for the comment. Indeed, I noticed the problem just after
> sending the patch. Surprisingly this didn't fail on iMX6 for some
> reason.
>
> Aside from the __user access problem, is the approach, in general, ok for
> you or would you suggest that I changed something?
At first glance the feature looks nice. I'll be able to say more
after testing working version.
--
Best Regards,
Jacek Anaszewski
next prev parent reply other threads:[~2015-10-01 7:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 20:43 [PATCH 0/3] leds: add device trigger Maciek Borzecki
[not found] ` <cover.1443472356.git.maciek.borzecki@gmail.com>
2015-09-28 20:43 ` [PATCH 1/3] leds: add device activity LED triggers Maciek Borzecki
2015-09-28 20:43 ` [PATCH 2/3] leds: add debugfs to device trigger Maciek Borzecki
2015-09-29 3:41 ` kbuild test robot
2015-09-29 3:41 ` kbuild test robot
2015-09-29 7:04 ` Maciek Borzecki
2015-09-30 14:08 ` Jacek Anaszewski
2015-09-30 15:47 ` Maciek Borzecki
2015-10-01 7:36 ` Jacek Anaszewski [this message]
2015-11-15 11:22 ` Pavel Machek
2015-09-28 20:43 ` [PATCH 3/3] Documentation: leds: document ledtrig-device trigger Maciek Borzecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560CE260.1000404@samsung.com \
--to=j.anaszewski@samsung.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=maciek.borzecki@gmail.com \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.