From: Neil Armstrong <narmstrong@baylibre.com>
To: Florian Fainelli <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jesper Dangaard Brouer <brouer@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, vivien.didelot@savoirfairelinux.com,
linux@roeck-us.net
Subject: Re: [RFC PATCH 0/3] net: dsa: Complete and fix the dsa unbinding
Date: Thu, 1 Oct 2015 17:06:06 +0200 [thread overview]
Message-ID: <560D4BDE.3080400@baylibre.com> (raw)
In-Reply-To: <560C1F5A.5070506@gmail.com>
On 09/30/2015 07:43 PM, Florian Fainelli wrote:
> On 30/09/15 01:21, Neil Armstrong wrote:
>> In order to cleanly unbind the dsa core, either as a module removal,
>> or a platform device unbind, switch the allocation the their devm_
>> counterparts and complete the destroy functions.
>>
>> The last patch is an experimental way to exit the probe when no
>> switch is found in the discover process.
>>
>> The patches are based on the current net-next.
>
> I looked at the patches and they bring DSA in a better direction. For
> future submissions, could you CC people who recently worked on DSA, like
> Andrew Lunn, Guenter Roeck, Vivien Didelot and myself? We can typically
> give your patches a try fairly quickly.
>
> In case you are seriously considering making DSA a loadable module,
> there were an earlier attempt here:
>
> http://comments.gmane.org/gmane.linux.network/345803
>
> Thanks!
>
>>
>> Neil Armstrong (3):
>> net: dsa: Use devm_ prefixed allocations
>> net: dsa: complete dsa_switch_destroy calls
>> net: dsa: exit probe if no switch were found
>>
>> net/dsa/dsa.c | 67 ++++++++++++++++++++++++++++++++++++++++++++++++++++-------
>> 1 file changed, 60 insertions(+), 7 deletions(-)
>>
>
>
Hi All,
Thanks for the tests and reviews.
My first intent is to make dynamic unbind/bind reliable, the reliable loadable module support
is a more complex target, but starting with unbind is a simpler start.
Should I re-post with the missing people, the Tested-by & without the RFC tag ?
Regards,
Neil
next prev parent reply other threads:[~2015-10-01 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 8:21 [RFC PATCH 0/3] net: dsa: Complete and fix the dsa unbinding Neil Armstrong
2015-09-30 17:43 ` Florian Fainelli
2015-10-01 15:06 ` Neil Armstrong [this message]
2015-10-01 17:20 ` Vivien Didelot
2015-10-01 15:19 ` Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D4BDE.3080400@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=andrew@lunn.ch \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.