* [Qemu-trivial] [PATCH] qtest/ahci: fix redundant assertion
@ 2015-09-21 20:55 ` John Snow
0 siblings, 0 replies; 6+ messages in thread
From: John Snow @ 2015-09-21 20:55 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, John Snow, mjt
Fixes https://bugs.launchpad.net/qemu/+bug/1497711
(!ncq || (ncq && lba48)) is the same as
(!ncq || lba48).
The intention is simply: "If a command is NCQ,
it must also be LBA48."
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/libqos/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index cf66b3e..adb2665 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -742,7 +742,7 @@ AHCICommand *ahci_command_create(uint8_t command_name)
g_assert(!(props->lba28 && props->lba48));
g_assert(!(props->read && props->write));
g_assert(!props->size || props->data);
- g_assert(!props->ncq || (props->ncq && props->lba48));
+ g_assert(!props->ncq || props->lba48);
/* Defaults and book-keeping */
cmd->props = props;
--
2.4.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* [Qemu-devel] [PATCH] qtest/ahci: fix redundant assertion
@ 2015-09-21 20:55 ` John Snow
0 siblings, 0 replies; 6+ messages in thread
From: John Snow @ 2015-09-21 20:55 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, John Snow, mjt
Fixes https://bugs.launchpad.net/qemu/+bug/1497711
(!ncq || (ncq && lba48)) is the same as
(!ncq || lba48).
The intention is simply: "If a command is NCQ,
it must also be LBA48."
Signed-off-by: John Snow <jsnow@redhat.com>
---
tests/libqos/ahci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
index cf66b3e..adb2665 100644
--- a/tests/libqos/ahci.c
+++ b/tests/libqos/ahci.c
@@ -742,7 +742,7 @@ AHCICommand *ahci_command_create(uint8_t command_name)
g_assert(!(props->lba28 && props->lba48));
g_assert(!(props->read && props->write));
g_assert(!props->size || props->data);
- g_assert(!props->ncq || (props->ncq && props->lba48));
+ g_assert(!props->ncq || props->lba48);
/* Defaults and book-keeping */
cmd->props = props;
--
2.4.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [Qemu-trivial] [Qemu-devel] [PATCH] qtest/ahci: fix redundant assertion
2015-09-21 20:55 ` [Qemu-devel] " John Snow
@ 2015-10-01 16:39 ` John Snow
-1 siblings, 0 replies; 6+ messages in thread
From: John Snow @ 2015-10-01 16:39 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, mjt
On 09/21/2015 04:55 PM, John Snow wrote:
> Fixes https://bugs.launchpad.net/qemu/+bug/1497711
>
> (!ncq || (ncq && lba48)) is the same as
> (!ncq || lba48).
>
> The intention is simply: "If a command is NCQ,
> it must also be LBA48."
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/libqos/ahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
> index cf66b3e..adb2665 100644
> --- a/tests/libqos/ahci.c
> +++ b/tests/libqos/ahci.c
> @@ -742,7 +742,7 @@ AHCICommand *ahci_command_create(uint8_t command_name)
> g_assert(!(props->lba28 && props->lba48));
> g_assert(!(props->read && props->write));
> g_assert(!props->size || props->data);
> - g_assert(!props->ncq || (props->ncq && props->lba48));
> + g_assert(!props->ncq || props->lba48);
>
> /* Defaults and book-keeping */
> cmd->props = props;
>
Tentatively staged. Barring objections, I will send a pull request for
this tomorrow, thanks.
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] qtest/ahci: fix redundant assertion
@ 2015-10-01 16:39 ` John Snow
0 siblings, 0 replies; 6+ messages in thread
From: John Snow @ 2015-10-01 16:39 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, mjt
On 09/21/2015 04:55 PM, John Snow wrote:
> Fixes https://bugs.launchpad.net/qemu/+bug/1497711
>
> (!ncq || (ncq && lba48)) is the same as
> (!ncq || lba48).
>
> The intention is simply: "If a command is NCQ,
> it must also be LBA48."
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/libqos/ahci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/libqos/ahci.c b/tests/libqos/ahci.c
> index cf66b3e..adb2665 100644
> --- a/tests/libqos/ahci.c
> +++ b/tests/libqos/ahci.c
> @@ -742,7 +742,7 @@ AHCICommand *ahci_command_create(uint8_t command_name)
> g_assert(!(props->lba28 && props->lba48));
> g_assert(!(props->read && props->write));
> g_assert(!props->size || props->data);
> - g_assert(!props->ncq || (props->ncq && props->lba48));
> + g_assert(!props->ncq || props->lba48);
>
> /* Defaults and book-keeping */
> cmd->props = props;
>
Tentatively staged. Barring objections, I will send a pull request for
this tomorrow, thanks.
https://github.com/jnsnow/qemu/commits/ide
https://github.com/jnsnow/qemu.git
--js
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-trivial] [PATCH] qtest/ahci: fix redundant assertion
2015-09-21 20:55 ` [Qemu-devel] " John Snow
@ 2015-10-04 16:18 ` Michael Tokarev
-1 siblings, 0 replies; 6+ messages in thread
From: Michael Tokarev @ 2015-10-04 16:18 UTC (permalink / raw)
To: John Snow, qemu-devel; +Cc: qemu-trivial
21.09.2015 23:55, John Snow wrote:
> Fixes https://bugs.launchpad.net/qemu/+bug/1497711
>
> (!ncq || (ncq && lba48)) is the same as
> (!ncq || lba48).
Applied to -trivial too, just in case :)
Thank you!
/mjt
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-10-08 8:01 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-21 20:55 [Qemu-trivial] [PATCH] qtest/ahci: fix redundant assertion John Snow
2015-09-21 20:55 ` [Qemu-devel] " John Snow
2015-10-01 16:39 ` [Qemu-trivial] " John Snow
2015-10-01 16:39 ` John Snow
2015-10-04 16:18 ` [Qemu-trivial] " Michael Tokarev
2015-10-04 16:18 ` [Qemu-devel] " Michael Tokarev
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.