From: Dave Hansen <dave@sr71.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: borntraeger@de.ibm.com, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dave.hansen@linux.intel.com
Subject: Re: [PATCH 07/25] x86, pkeys: new page fault error code bit: PF_PK
Date: Thu, 1 Oct 2015 10:19:02 -0700 [thread overview]
Message-ID: <560D6B06.6040505@sr71.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1510011351150.4500@nanos>
On 10/01/2015 04:54 AM, Thomas Gleixner wrote:
> On Mon, 28 Sep 2015, Dave Hansen wrote:
>> >
>> > /*
>> > @@ -916,7 +918,10 @@ static int spurious_fault_check(unsigned
>> >
>> > if ((error_code & PF_INSTR) && !pte_exec(*pte))
>> > return 0;
>> > -
>> > + /*
>> > + * Note: We do not do lazy flushing on protection key
>> > + * changes, so no spurious fault will ever set PF_PK.
>> > + */
> It might be a bit more clear to have:
>
> /* Comment .... */
> if ((error_code & PF_PK))
> return 1;
>
> return 1;
>
> That way the comment is associated to obviously redundant code, but
> it's easier to read, especially if we add some new PF_ thingy after
> that.
Agreed, that's a nicer way to do it. I'll fix it up.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave@sr71.net>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: borntraeger@de.ibm.com, x86@kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
dave.hansen@linux.intel.com
Subject: Re: [PATCH 07/25] x86, pkeys: new page fault error code bit: PF_PK
Date: Thu, 1 Oct 2015 10:19:02 -0700 [thread overview]
Message-ID: <560D6B06.6040505@sr71.net> (raw)
In-Reply-To: <alpine.DEB.2.11.1510011351150.4500@nanos>
On 10/01/2015 04:54 AM, Thomas Gleixner wrote:
> On Mon, 28 Sep 2015, Dave Hansen wrote:
>> >
>> > /*
>> > @@ -916,7 +918,10 @@ static int spurious_fault_check(unsigned
>> >
>> > if ((error_code & PF_INSTR) && !pte_exec(*pte))
>> > return 0;
>> > -
>> > + /*
>> > + * Note: We do not do lazy flushing on protection key
>> > + * changes, so no spurious fault will ever set PF_PK.
>> > + */
> It might be a bit more clear to have:
>
> /* Comment .... */
> if ((error_code & PF_PK))
> return 1;
>
> return 1;
>
> That way the comment is associated to obviously redundant code, but
> it's easier to read, especially if we add some new PF_ thingy after
> that.
Agreed, that's a nicer way to do it. I'll fix it up.
next prev parent reply other threads:[~2015-10-01 17:19 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-28 19:18 [PATCH 00/25] x86: Memory Protection Keys Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 02/25] x86, pkeys: Add Kconfig option Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-10-01 11:02 ` Thomas Gleixner
2015-10-01 11:02 ` Thomas Gleixner
2015-09-28 19:18 ` [PATCH 01/25] x86, fpu: add placeholder for Processor Trace XSAVE state Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-10-01 11:01 ` Thomas Gleixner
2015-10-01 11:01 ` Thomas Gleixner
2015-09-28 19:18 ` [PATCH 03/25] x86, pkeys: cpuid bit definition Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-10-01 11:02 ` Thomas Gleixner
2015-10-01 11:02 ` Thomas Gleixner
2015-09-28 19:18 ` [PATCH 06/25] x86, pkeys: PTE bits for storing protection key Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-10-01 11:51 ` Thomas Gleixner
2015-10-01 11:51 ` Thomas Gleixner
2015-09-28 19:18 ` [PATCH 05/25] x86, pkey: add PKRU xsave fields and data structure(s) Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-10-01 11:50 ` Thomas Gleixner
2015-10-01 11:50 ` Thomas Gleixner
2015-10-01 17:17 ` Dave Hansen
2015-10-01 17:17 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 04/25] x86, pku: define new CR4 bit Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-10-01 11:03 ` Thomas Gleixner
2015-10-01 11:03 ` Thomas Gleixner
2015-09-28 19:18 ` [PATCH 08/25] x86, pkeys: store protection in high VMA flags Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 07/25] x86, pkeys: new page fault error code bit: PF_PK Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-10-01 11:54 ` Thomas Gleixner
2015-10-01 11:54 ` Thomas Gleixner
2015-10-01 17:19 ` Dave Hansen [this message]
2015-10-01 17:19 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 10/25] x86, pkeys: pass VMA down in to fault signal generation code Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 09/25] x86, pkeys: arch-specific protection bits Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 11/25] x86, pkeys: notify userspace about protection key faults Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 13/25] mm: factor out VMA fault permission checking Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 12/25] x86, pkeys: add functions to fetch PKRU Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 14/25] mm: simplify get_user_pages() PTE bit handling Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 15/25] x86, pkeys: check VMAs and PTEs for protection keys Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-10-22 20:57 ` Jerome Glisse
2015-10-22 20:57 ` Jerome Glisse
2015-10-22 21:23 ` Dave Hansen
2015-10-22 21:23 ` Dave Hansen
2015-10-22 22:25 ` Jerome Glisse
2015-10-22 22:25 ` Jerome Glisse
2015-10-23 0:49 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 16/25] x86, pkeys: optimize fault handling in access_error() Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 19/25] x86, pkeys: add Kconfig prompt to existing config option Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 18/25] x86, pkeys: dump PTE pkey in /proc/pid/smaps Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 17/25] x86, pkeys: dump PKRU with other kernel registers Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 20/25] mm, multi-arch: pass a protection key in to calc_vm_flag_bits() Dave Hansen
2015-09-28 19:18 ` Dave Hansen
[not found] ` <20150928191817.035A64E2-LXbPSdftPKxrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-09-28 19:18 ` [PATCH 22/25] x86: wire up mprotect_key() system call Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 23/25] x86, pkeys: actually enable Memory Protection Keys in CPU Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 21/25] mm: implement new mprotect_key() system call Dave Hansen
2015-09-28 19:18 ` Dave Hansen
[not found] ` <20150928191826.F1CD5256-LXbPSdftPKxrdx17CPfAsdBPR1lH4CV8@public.gmane.org>
2015-09-29 6:39 ` Michael Ellerman
2015-09-29 6:39 ` Michael Ellerman
2015-09-29 6:39 ` Michael Ellerman
2015-09-29 14:16 ` Dave Hansen
2015-09-29 14:16 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 25/25] x86, pkeys: Documentation Dave Hansen
2015-09-28 19:18 ` Dave Hansen
2015-09-28 20:34 ` Andi Kleen
2015-09-28 20:34 ` Andi Kleen
2015-09-28 20:41 ` Dave Hansen
2015-09-28 19:18 ` [PATCH 24/25] x86, pkeys: add self-tests Dave Hansen
2015-09-28 19:18 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560D6B06.6040505@sr71.net \
--to=dave@sr71.net \
--cc=borntraeger@de.ibm.com \
--cc=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.