Re: [PATCH v2 16/26] IB/srp: Convert to new registration API

[Bart Van Assche <bart.vanassche@sandisk.com>]

On 09/24/2015 10:35 AM, Sagi Grimberg wrote:
> +	if (dev->use_fast_reg) {
> +		state.sg = idb_sg;
> +		state.sg_nents = 1;
> +		sg_set_buf(idb_sg, req->indirect_desc, idb_len);
> +		idb_sg->dma_address = req->indirect_dma_addr; /* hack! */
> +		ret = srp_map_finish_fr(&state, ch);
> +		if (ret < 0)
> +			return ret;
> +	} else if (dev->use_fmr) {

Hello Sagi,

Had you considered to use sg_init_one() instead of using sg_set_buf() 
and setting sg_nents to one ? The former function sets the end marker in 
the idb_sg scatterlist and also sets sg_magic if CONFIG_DEBUG_SG has 
been enabled.

Thanks,

Bart.