Re: [PATCH] Add Terratec H7 Revision 4 to DVBSky driver

["Roger Mårtensson" <roger.martensson@gmail.com>]

Den 2015-09-19 kl. 19:30, skrev Erik Andresen:
> Adds Terratec H7 Rev. 4 with USB id 0ccd:10a5 to DVBSky driver.

I have tested this on a Custom Linux 4.2 kernel and it is working as 
expected.
Noticed a few things.

1) "Supported:" on ir-keytable doesn't show anything.
1b) Setting RC-5 with ir-keytable -p gives me an error.
2) Keymap tt-1500 may be for dvbsky but not for H7 Rev 4. Needed to do 
my own keymap. (48 button remote)
2b) The Remote buttons "Music" and "Pic" doesn't give any scancodes in 
ir-keytable -t.

I have tested in a DVB-C environment with CAM/CI and encrypted channels.
I have two H7 devices and one of them seem to get into a hang and needs 
to be powercycled now and then. At the moment it is always the same one 
that hangs. A linux reboot does not help but I need to do it sometimes 
together with a power cycle of the hanging device.


> Signed-off-by: Erik Andresen <erik@vontaene.de>
> ---
>   drivers/media/dvb-core/dvb-usb-ids.h  | 1 +
>   drivers/media/usb/dvb-usb-v2/dvbsky.c | 4 ++++
>   2 files changed, 5 insertions(+)
>
> diff --git a/drivers/media/dvb-core/dvb-usb-ids.h b/drivers/media/dvb-core/dvb-usb-ids.h
> index c117fb3..0a46580 100644
> --- a/drivers/media/dvb-core/dvb-usb-ids.h
> +++ b/drivers/media/dvb-core/dvb-usb-ids.h
> @@ -257,6 +257,7 @@
>   #define USB_PID_TERRATEC_CINERGY_T_XXS_2		0x00ab
>   #define USB_PID_TERRATEC_H7				0x10b4
>   #define USB_PID_TERRATEC_H7_2				0x10a3
> +#define USB_PID_TERRATEC_H7_3				0x10a5
>   #define USB_PID_TERRATEC_T3				0x10a0
>   #define USB_PID_TERRATEC_T5				0x10a1
>   #define USB_PID_NOXON_DAB_STICK				0x00b3
> diff --git a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c
> index cdf59bc..8f526a4 100644
> --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c
> +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c
> @@ -841,6 +841,10 @@ static const struct usb_device_id dvbsky_id_table[] = {
>   		USB_PID_TECHNOTREND_CONNECT_CT2_4650_CI,
>   		&dvbsky_t680c_props, "TechnoTrend TT-connect CT2-4650 CI",
>   		RC_MAP_TT_1500) },
> +        { DVB_USB_DEVICE(USB_VID_TERRATEC,
> +                USB_PID_TERRATEC_H7_3,
> +                &dvbsky_t680c_props, "Terratec H7 Rev.4",
> +                RC_MAP_TT_1500) },
>   	{ }
>   };
>   MODULE_DEVICE_TABLE(usb, dvbsky_id_table);