Re: [PATCH V2 0/2] rc: Add timeout support to gpio-ir-recv

[Eric Nelson <eric@nelint.com>]

Hi Mauro,

On 10/03/2015 07:27 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 21 Sep 2015 12:08:42 -0700
> Eric Nelson <eric@nelint.com> escreveu:
> 
>> Add timeout support to the gpio-ir-recv driver as discussed
>> in this original patch:
>>
>> 	https://patchwork.ozlabs.org/patch/516827/
>>
>> V2 uses the timeout field of the rcdev instead of a device tree 
>> field to set the timeout value as suggested by Sean Young.
>>
>> Eric Nelson (2):
>>   rc-core: define a default timeout for drivers
>>   rc: gpio-ir-recv: add timeout on idle
> 
> I'm ok on having a default timeout for drivers, but the better would
> be to implement it at the RC core, and not inside each driver.
> 

Can you elaborate?

I'm not sure how that can be done, since the issue with the
gpio-ir driver stems from the fact that there's no tail-end
interrupt at the end of a burst. I think this isn't needed
for other hardware.

It seems that the call to schedule() in ir_raw_event_thread()
could be changed to schedule_timeout(), but

	- this should only be done when not idle, and
	- only some hardware drivers need it

I'm also not familiar with the rest of the code, so I'd
be concerned about breaking other interfaces.

Please advise,


Eric