From: Eric Nelson <eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
To: Mauro Carvalho Chehab <mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
pawel.moll-5wv7dgnIgG8@public.gmane.org,
mark.rutland-5wv7dgnIgG8@public.gmane.org,
ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org,
galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
patrice.chotard-qxv4g6HH51o@public.gmane.org,
fabf-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org,
wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org,
heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
otavio-fKevB0iiKLMBZ+LybsDmbA@public.gmane.org
Subject: Re: [PATCH V2 1/2] rc-core: define a default timeout for drivers
Date: Sat, 3 Oct 2015 07:52:18 -0700 [thread overview]
Message-ID: <560FEBA2.6040504@nelint.com> (raw)
In-Reply-To: <20151003112510.54fe2a25-+RedX5hVuTR+urZeOPWqwQ@public.gmane.org>
Thanks Mauro,
On 10/03/2015 07:25 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 21 Sep 2015 12:08:43 -0700
> Eric Nelson <eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org> escreveu:
>
>> A default timeout value of 100ms is workable for most decoders.
>> Declare a constant to help standardize its' use.
>
> I guess the worse case scenario is the NEC protocol:
> http://www.sbprojects.com/knowledge/ir/nec.php
>
> with allows a repeat message to be sent on every 110ms. As the
> repeat message is 11.25 ms, that would mean a maximum time without
> data for 98.75 ms. So, in thesis, 100 ms would be ok. However, IR
> timings are not always precise and may affected by the battery charge.
>
> So, I think that a timeout of 100ms is too close to 98.75 and may
> cause troubles.
>
> S, IMHO, it is safer to define the default timeout as 125ms.
>
Sounds good. I'll submit V3 shortly.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Eric Nelson <eric@nelint.com>
To: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
Cc: linux-media@vger.kernel.org, robh+dt@kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
patrice.chotard@st.com, fabf@skynet.be, wsa@the-dreams.de,
heiko@sntech.de, devicetree@vger.kernel.org,
otavio@ossystems.com.br
Subject: Re: [PATCH V2 1/2] rc-core: define a default timeout for drivers
Date: Sat, 3 Oct 2015 07:52:18 -0700 [thread overview]
Message-ID: <560FEBA2.6040504@nelint.com> (raw)
In-Reply-To: <20151003112510.54fe2a25@recife.lan>
Thanks Mauro,
On 10/03/2015 07:25 AM, Mauro Carvalho Chehab wrote:
> Em Mon, 21 Sep 2015 12:08:43 -0700
> Eric Nelson <eric@nelint.com> escreveu:
>
>> A default timeout value of 100ms is workable for most decoders.
>> Declare a constant to help standardize its' use.
>
> I guess the worse case scenario is the NEC protocol:
> http://www.sbprojects.com/knowledge/ir/nec.php
>
> with allows a repeat message to be sent on every 110ms. As the
> repeat message is 11.25 ms, that would mean a maximum time without
> data for 98.75 ms. So, in thesis, 100 ms would be ok. However, IR
> timings are not always precise and may affected by the battery charge.
>
> So, I think that a timeout of 100ms is too close to 98.75 and may
> cause troubles.
>
> S, IMHO, it is safer to define the default timeout as 125ms.
>
Sounds good. I'll submit V3 shortly.
next prev parent reply other threads:[~2015-10-03 14:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-11 14:00 [PATCH][resend] rc: gpio-ir-recv: allow flush space on idle Eric Nelson
[not found] ` <1441980024-1944-1-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-14 10:00 ` Sean Young
2015-09-14 10:00 ` Sean Young
2015-09-14 14:34 ` Eric Nelson
2015-09-14 14:54 ` Sean Young
2015-09-14 15:05 ` Eric Nelson
2015-09-14 15:35 ` Sean Young
2015-09-21 19:08 ` [PATCH V2 0/2] rc: Add timeout support to gpio-ir-recv Eric Nelson
2015-09-21 19:08 ` Eric Nelson
2015-09-21 19:08 ` [PATCH V2 1/2] rc-core: define a default timeout for drivers Eric Nelson
[not found] ` <1442862524-3694-2-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-10-03 14:25 ` Mauro Carvalho Chehab
2015-10-03 14:25 ` Mauro Carvalho Chehab
[not found] ` <20151003112510.54fe2a25-+RedX5hVuTR+urZeOPWqwQ@public.gmane.org>
2015-10-03 14:52 ` Eric Nelson [this message]
2015-10-03 14:52 ` Eric Nelson
2015-10-03 15:18 ` Eric Nelson
2015-09-21 19:08 ` [PATCH V2 2/2] rc: gpio-ir-recv: add timeout on idle Eric Nelson
2015-09-23 13:26 ` Sean Young
2015-09-23 13:52 ` Eric Nelson
[not found] ` <5602AE95.9000505-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-23 14:07 ` [PATCH V3 " Eric Nelson
2015-09-23 14:07 ` Eric Nelson
[not found] ` <1443017228-16499-1-git-send-email-eric-SeqgQ6RdavfQT0dZR+AlfA@public.gmane.org>
2015-09-23 14:26 ` Sean Young
2015-09-23 14:26 ` Sean Young
2015-10-03 14:27 ` [PATCH V2 0/2] rc: Add timeout support to gpio-ir-recv Mauro Carvalho Chehab
2015-10-03 15:10 ` Eric Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=560FEBA2.6040504@nelint.com \
--to=eric-seqgq6rdavfqt0dzr+alfa@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=fabf-AgBVmzD5pcezQB+pC5nmwQ@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=mchehab-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org \
--cc=otavio-fKevB0iiKLMBZ+LybsDmbA@public.gmane.org \
--cc=patrice.chotard-qxv4g6HH51o@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.