From: Markos Chandras <Markos.Chandras@imgtec.com>
To: <linux-mips@linux-mips.org>
Subject: Re: [PATCH] MIPS: BPF: Disable JIT on R3000 (MIPS-I)
Date: Mon, 5 Oct 2015 10:51:08 +0100 [thread overview]
Message-ID: <5612480C.2040006@imgtec.com> (raw)
In-Reply-To: <20151005092440.GA1389@linux-mips.org>
On 10/05/2015 10:24 AM, Ralf Baechle wrote:
> On Sat, Sep 05, 2015 at 08:29:28PM +0100, Ben Hutchings wrote:
>
>> The JIT does not include the load delay slots required by MIPS-I
>> processors.
>
> See 0c5d187828588dd1b36cb93b4481a8db467ef3e8 (MIPS: BPF: Fix load delay
> slots.) for a proper fix.
Since this patch didn't make it to the LMO and never discussed, i must
say that it's probably not complete. The bpf_jit.c code also emits load
instructions (for example see emit_load_imm). So I guess you need to
extend your patch to cover the C code as well.
--
markos
WARNING: multiple messages have this Message-ID (diff)
From: Markos Chandras <Markos.Chandras@imgtec.com>
To: linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: BPF: Disable JIT on R3000 (MIPS-I)
Date: Mon, 5 Oct 2015 10:51:08 +0100 [thread overview]
Message-ID: <5612480C.2040006@imgtec.com> (raw)
Message-ID: <20151005095108.urzSvek5QA4ob4QcN7LEZSV5YQ1MKx462dErPgq__wg@z> (raw)
In-Reply-To: <20151005092440.GA1389@linux-mips.org>
On 10/05/2015 10:24 AM, Ralf Baechle wrote:
> On Sat, Sep 05, 2015 at 08:29:28PM +0100, Ben Hutchings wrote:
>
>> The JIT does not include the load delay slots required by MIPS-I
>> processors.
>
> See 0c5d187828588dd1b36cb93b4481a8db467ef3e8 (MIPS: BPF: Fix load delay
> slots.) for a proper fix.
Since this patch didn't make it to the LMO and never discussed, i must
say that it's probably not complete. The bpf_jit.c code also emits load
instructions (for example see emit_load_imm). So I guess you need to
extend your patch to cover the C code as well.
--
markos
next prev parent reply other threads:[~2015-10-05 9:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-05 19:29 [PATCH] MIPS: BPF: Disable JIT on R3000 (MIPS-I) Ben Hutchings
2015-10-05 9:24 ` Ralf Baechle
2015-10-05 9:51 ` Markos Chandras [this message]
2015-10-05 9:51 ` Markos Chandras
2015-10-05 11:31 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5612480C.2040006@imgtec.com \
--to=markos.chandras@imgtec.com \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.