From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Jerome Marchand <jmarchan@redhat.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Michal Hocko <mhocko@suse.cz>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-s390@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Linux API <linux-api@vger.kernel.org>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Subject: Re: [PATCH v4 2/4] mm, proc: account for shmem swap in /proc/pid/smaps
Date: Tue, 6 Oct 2015 09:08:03 +0200 [thread overview]
Message-ID: <56137353.2010600@suse.cz> (raw)
In-Reply-To: <20151002153702.7bdc4c0483cd9b2ee9e0fba3@linux-foundation.org>
On 10/03/2015 12:37 AM, Andrew Morton wrote:
> On Fri, 2 Oct 2015 15:35:49 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
>
>>
>> --- a/include/linux/shmem_fs.h
>> +++ b/include/linux/shmem_fs.h
>> @@ -60,6 +60,12 @@ extern struct page *shmem_read_mapping_page_gfp(struct address_space *mapping,
>> extern void shmem_truncate_range(struct inode *inode, loff_t start, loff_t end);
>> extern int shmem_unuse(swp_entry_t entry, struct page *page);
>>
>> +#ifdef CONFIG_SWAP
>> +extern unsigned long shmem_swap_usage(struct inode *inode);
>> +extern unsigned long shmem_partial_swap_usage(struct address_space *mapping,
>> + pgoff_t start, pgoff_t end);
>> +#endif
>
> CONFIG_SWAP is wrong, isn't it? It should be CONFIG_SHMEM if anything.
Yeah, I overlooked this while removing the other ifdefs. Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Vlastimil Babka <vbabka@suse.cz>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-mm@kvack.org, Jerome Marchand <jmarchan@redhat.com>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
Michal Hocko <mhocko@suse.cz>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Randy Dunlap <rdunlap@infradead.org>,
linux-s390@vger.kernel.org,
Martin Schwidefsky <schwidefsky@de.ibm.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Paul Mackerras <paulus@samba.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Oleg Nesterov <oleg@redhat.com>,
Linux API <linux-api@vger.kernel.org>,
Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Subject: Re: [PATCH v4 2/4] mm, proc: account for shmem swap in /proc/pid/smaps
Date: Tue, 6 Oct 2015 09:08:03 +0200 [thread overview]
Message-ID: <56137353.2010600@suse.cz> (raw)
In-Reply-To: <20151002153702.7bdc4c0483cd9b2ee9e0fba3@linux-foundation.org>
On 10/03/2015 12:37 AM, Andrew Morton wrote:
> On Fri, 2 Oct 2015 15:35:49 +0200 Vlastimil Babka <vbabka@suse.cz> wrote:
>
>>
>> --- a/include/linux/shmem_fs.h
>> +++ b/include/linux/shmem_fs.h
>> @@ -60,6 +60,12 @@ extern struct page *shmem_read_mapping_page_gfp(struct address_space *mapping,
>> extern void shmem_truncate_range(struct inode *inode, loff_t start, loff_t end);
>> extern int shmem_unuse(swp_entry_t entry, struct page *page);
>>
>> +#ifdef CONFIG_SWAP
>> +extern unsigned long shmem_swap_usage(struct inode *inode);
>> +extern unsigned long shmem_partial_swap_usage(struct address_space *mapping,
>> + pgoff_t start, pgoff_t end);
>> +#endif
>
> CONFIG_SWAP is wrong, isn't it? It should be CONFIG_SHMEM if anything.
Yeah, I overlooked this while removing the other ifdefs. Thanks.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2015-10-06 7:08 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-02 13:35 [PATCH v4 0/4] enhance shmem process and swap accounting Vlastimil Babka
2015-10-02 13:35 ` Vlastimil Babka
2015-10-02 13:35 ` [PATCH v4 1/4] mm, documentation: clarify /proc/pid/status VmSwap limitations Vlastimil Babka
2015-10-02 13:35 ` Vlastimil Babka
2015-10-02 14:56 ` Jerome Marchand
2015-10-05 1:05 ` Hugh Dickins
2015-10-05 1:05 ` Hugh Dickins
2015-10-06 7:05 ` Vlastimil Babka
2015-10-06 7:05 ` Vlastimil Babka
2015-10-02 13:35 ` [PATCH v4 2/4] mm, proc: account for shmem swap in /proc/pid/smaps Vlastimil Babka
2015-10-02 13:35 ` Vlastimil Babka
2015-10-02 15:00 ` Jerome Marchand
2015-10-02 15:20 ` Michal Hocko
2015-10-02 15:20 ` Michal Hocko
2015-10-02 22:37 ` Andrew Morton
2015-10-02 22:37 ` Andrew Morton
2015-10-06 7:08 ` Vlastimil Babka [this message]
2015-10-06 7:08 ` Vlastimil Babka
2015-10-05 3:01 ` Hugh Dickins
2015-10-05 3:01 ` Hugh Dickins
2015-10-21 14:39 ` Vlastimil Babka
2015-10-21 14:39 ` Vlastimil Babka
2015-10-21 22:38 ` Hugh Dickins
2015-10-21 22:38 ` Hugh Dickins
2015-10-26 11:22 ` Jerome Marchand
2015-10-05 7:53 ` Peter Zijlstra
2015-10-05 7:53 ` Peter Zijlstra
2015-10-02 13:35 ` [PATCH v4 3/4] mm, shmem: Add shmem resident memory accounting Vlastimil Babka
2015-10-02 13:35 ` Vlastimil Babka
2015-10-02 22:37 ` Andrew Morton
2015-10-02 22:37 ` Andrew Morton
2015-10-05 4:28 ` Hugh Dickins
2015-10-05 4:28 ` Hugh Dickins
2015-10-02 13:35 ` [PATCH v4 4/4] mm, procfs: Display VmAnon, VmFile and VmShm in /proc/pid/status Vlastimil Babka
2015-10-02 13:35 ` Vlastimil Babka
2015-10-02 22:37 ` Andrew Morton
2015-10-02 22:37 ` Andrew Morton
[not found] ` <1443792951-13944-5-git-send-email-vbabka-AlSwsSmVLrQ@public.gmane.org>
2015-10-05 4:55 ` Hugh Dickins
2015-10-05 4:55 ` Hugh Dickins
2015-10-05 4:55 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56137353.2010600@suse.cz \
--to=vbabka@suse.cz \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=gorcunov@openvz.org \
--cc=heiko.carstens@de.ibm.com \
--cc=hughd@google.com \
--cc=jmarchan@redhat.com \
--cc=khlebnikov@yandex-team.ru \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=mhocko@suse.cz \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.