All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
To: Hiraku Toyooka
	<hiraku.toyooka.gu-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Tony Luck <tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Kees Cook <keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
	linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	Anton Vorontsov <anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org>,
	Mark Salyzyn <salyzyn-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
	Seiji Aguchi
	<seiji.aguchi.tr-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org>,
	Shuah Khan <shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
Subject: Re: [PATCH v2 0/2] selftests/pstore: add pstore test script
Date: Tue, 6 Oct 2015 11:59:09 -0600	[thread overview]
Message-ID: <56140BED.7040507@osg.samsung.com> (raw)
In-Reply-To: <20151002114637.20957.61769.stgit@arietta>

On 10/02/2015 05:46 AM, Hiraku Toyooka wrote:
> These scripts include test cases which check pstore behavior. This
> is useful to avoid regressions of pstore.
> 
> Changes since v1:
>  * Exit with 1 in pstore/Makefile when pstore_crash_test failed.
>  * Create helper functions to make the tests much more readable.
>  * Use /sys/module/pstore/parameters/backend to check pstore backend is
>    registered.
>  * Show content of /sys/module/.../backend and /proc/cmdline for debug
>  * Give UUID to each execution of test script.
>  * Write unique test string with UUID into pmsg.
>  * Check only one test string pattern appears in pmsg after crash.
>  * Check UUID written to pmsg matches across crash.
>  * Don't touch panic_on_oops because it is not necessary for reboot on crash
> 
> (v1: http://www.kernelhub.org/?msg=831044&p=2)
> 
> I also confirmed that these scripts work fine with kdump reboot with
> kernel boot parameter 'crash_kexec_post_notifiers'.

Thanks. Applied to linux-kselftest next for 4.4

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org | (970) 217-8978

WARNING: multiple messages have this Message-ID (diff)
From: Shuah Khan <shuahkh@osg.samsung.com>
To: Hiraku Toyooka <hiraku.toyooka.gu@hitachi.com>,
	linux-kernel@vger.kernel.org
Cc: Tony Luck <tony.luck@intel.com>,
	Kees Cook <keescook@chromium.org>,
	linux-api@vger.kernel.org, Anton Vorontsov <anton@enomsg.org>,
	Mark Salyzyn <salyzyn@android.com>,
	Colin Cross <ccross@android.com>,
	Seiji Aguchi <seiji.aguchi.tr@hitachi.com>,
	Shuah Khan <shuahkh@osg.samsung.com>
Subject: Re: [PATCH v2 0/2] selftests/pstore: add pstore test script
Date: Tue, 6 Oct 2015 11:59:09 -0600	[thread overview]
Message-ID: <56140BED.7040507@osg.samsung.com> (raw)
In-Reply-To: <20151002114637.20957.61769.stgit@arietta>

On 10/02/2015 05:46 AM, Hiraku Toyooka wrote:
> These scripts include test cases which check pstore behavior. This
> is useful to avoid regressions of pstore.
> 
> Changes since v1:
>  * Exit with 1 in pstore/Makefile when pstore_crash_test failed.
>  * Create helper functions to make the tests much more readable.
>  * Use /sys/module/pstore/parameters/backend to check pstore backend is
>    registered.
>  * Show content of /sys/module/.../backend and /proc/cmdline for debug
>  * Give UUID to each execution of test script.
>  * Write unique test string with UUID into pmsg.
>  * Check only one test string pattern appears in pmsg after crash.
>  * Check UUID written to pmsg matches across crash.
>  * Don't touch panic_on_oops because it is not necessary for reboot on crash
> 
> (v1: http://www.kernelhub.org/?msg=831044&p=2)
> 
> I also confirmed that these scripts work fine with kdump reboot with
> kernel boot parameter 'crash_kexec_post_notifiers'.

Thanks. Applied to linux-kselftest next for 4.4

thanks,
-- Shuah


-- 
Shuah Khan
Sr. Linux Kernel Developer
Open Source Innovation Group
Samsung Research America (Silicon Valley)
shuahkh@osg.samsung.com | (970) 217-8978

  parent reply	other threads:[~2015-10-06 17:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-02 11:46 [PATCH v2 0/2] selftests/pstore: add pstore test script Hiraku Toyooka
2015-10-02 11:46 ` Hiraku Toyooka
2015-10-02 11:46 ` [PATCH v2 1/2] selftests/pstore: add pstore test script for pre-reboot Hiraku Toyooka
2015-10-02 19:39   ` Mark Salyzyn
2015-10-02 19:39     ` Mark Salyzyn
2015-10-02 11:46 ` [PATCH v2 2/2] selftests/pstore: add pstore test scripts going with reboot Hiraku Toyooka
2015-10-02 19:39   ` Mark Salyzyn
2015-10-06 17:59 ` Shuah Khan [this message]
2015-10-06 17:59   ` [PATCH v2 0/2] selftests/pstore: add pstore test script Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56140BED.7040507@osg.samsung.com \
    --to=shuahkh-jph+aebz4p+uejcrhfaqsw@public.gmane.org \
    --cc=anton-9xeibp6oKSgdnm+yROfE0A@public.gmane.org \
    --cc=ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=hiraku.toyooka.gu-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org \
    --cc=keescook-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org \
    --cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=salyzyn-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org \
    --cc=seiji.aguchi.tr-FCd8Q96Dh0JBDgjK7y7TUQ@public.gmane.org \
    --cc=tony.luck-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.