From: neidhard.kim@lge.com (Jongsung Kim)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM:mm: fix kmap_atomic_to_page
Date: Wed, 7 Oct 2015 12:55:08 +0900 [thread overview]
Message-ID: <5614979C.30100@lge.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1510062136190.1531@knanqh.ubzr>
Recently, we made a driver utilizing kmap_atomic_to_page. Of course, it's not mainlined. People may be using it outside mainline just like us.
vmalloc has vmalloc_to_page, pkmap has kmap_to page, and fixmap has kmap_atomic_to_page. Then.. how about letting virt_to_page do them all?
On 10/07/2015 10:37 AM, Nicolas Pitre wrote:
> On Tue, 6 Oct 2015, Russell King - ARM Linux wrote:
>
>> On Tue, Oct 06, 2015 at 08:09:33PM +0900, Chanho Min wrote:
>>> Since kmap_atomic returns the pkmap address without a new mapping to
>>> fixmap for the page that is already mapped by kmap, It should be
>>> considered for the pkmap address in kmap_atomic_to_page.
>> What's the reasoning behind this change, given that I can find lots of
>> definitions of kmap_atomic_to_page() in the kernel, but not a single
>> user of this.
>>
>> If there's no users, should we be deleting this code?
> I think commit 5bbeed12bdc3 provides the answer to that question.
>
>
> Nicolas
>
WARNING: multiple messages have this Message-ID (diff)
From: Jongsung Kim <neidhard.kim@lge.com>
To: Nicolas Pitre <nicolas.pitre@linaro.org>,
Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Chanho Min <chanho.min@lge.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Gunho Lee <gunho.lee@lge.com>
Subject: Re: [PATCH] ARM:mm: fix kmap_atomic_to_page
Date: Wed, 7 Oct 2015 12:55:08 +0900 [thread overview]
Message-ID: <5614979C.30100@lge.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1510062136190.1531@knanqh.ubzr>
Recently, we made a driver utilizing kmap_atomic_to_page. Of course, it's not mainlined. People may be using it outside mainline just like us.
vmalloc has vmalloc_to_page, pkmap has kmap_to page, and fixmap has kmap_atomic_to_page. Then.. how about letting virt_to_page do them all?
On 10/07/2015 10:37 AM, Nicolas Pitre wrote:
> On Tue, 6 Oct 2015, Russell King - ARM Linux wrote:
>
>> On Tue, Oct 06, 2015 at 08:09:33PM +0900, Chanho Min wrote:
>>> Since kmap_atomic returns the pkmap address without a new mapping to
>>> fixmap for the page that is already mapped by kmap, It should be
>>> considered for the pkmap address in kmap_atomic_to_page.
>> What's the reasoning behind this change, given that I can find lots of
>> definitions of kmap_atomic_to_page() in the kernel, but not a single
>> user of this.
>>
>> If there's no users, should we be deleting this code?
> I think commit 5bbeed12bdc3 provides the answer to that question.
>
>
> Nicolas
>
next prev parent reply other threads:[~2015-10-07 3:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 11:09 [PATCH] ARM:mm: fix kmap_atomic_to_page Chanho Min
2015-10-06 11:09 ` Chanho Min
2015-10-06 19:28 ` Russell King - ARM Linux
2015-10-06 19:28 ` Russell King - ARM Linux
2015-10-07 1:37 ` Nicolas Pitre
2015-10-07 1:37 ` Nicolas Pitre
2015-10-07 3:55 ` Jongsung Kim [this message]
2015-10-07 3:55 ` Jongsung Kim
2015-10-07 9:01 ` Russell King - ARM Linux
2015-10-07 9:01 ` Russell King - ARM Linux
2015-10-12 5:30 ` Jongsung Kim
2015-10-12 5:30 ` Jongsung Kim
2015-10-12 9:27 ` Arnd Bergmann
2015-10-12 9:27 ` Arnd Bergmann
2015-10-13 2:06 ` Jongsung Kim
2015-10-13 2:06 ` Jongsung Kim
2015-10-13 11:44 ` Arnd Bergmann
2015-10-13 11:44 ` Arnd Bergmann
2015-10-12 6:00 ` yalin wang
2015-10-12 6:00 ` yalin wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5614979C.30100@lge.com \
--to=neidhard.kim@lge.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.