From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
Santosh Shilimkar <ssantosh@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Austin Schuh <austin@peloton-tech.com>,
Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] genirq: export handle_bad_irq
Date: Wed, 7 Oct 2015 14:18:24 -0500 [thread overview]
Message-ID: <56157000.4010009@ti.com> (raw)
In-Reply-To: <5847725.4IBopItaOr@wuerfel>
Hi Arnd,
On 10/06/2015 03:24 PM, Arnd Bergmann wrote:
> A cleanup of the omap gpio driver introduced a use of the
> handle_bad_irq() function in a device driver that can be
> a loadable module.
>
> This broke the ARM allmodconfig build:
>
> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>
> This patch exports the handle_bad_irq symbol in order to
> allow the use in modules.
>
Thanks for fixing it and sorry for the mess.
Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index ea7b5fd99ba5..142bbf3b607f 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -35,6 +35,7 @@ void handle_bad_irq(struct irq_desc *desc)
> kstat_incr_irqs_this_cpu(desc);
> ack_bad_irq(irq);
> }
> +EXPORT_SYMBOL_GPL(handle_bad_irq);
>
> /*
> * Special, empty irq handler:
>
--
regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: grygorii.strashko@ti.com (Grygorii Strashko)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] genirq: export handle_bad_irq
Date: Wed, 7 Oct 2015 14:18:24 -0500 [thread overview]
Message-ID: <56157000.4010009@ti.com> (raw)
In-Reply-To: <5847725.4IBopItaOr@wuerfel>
Hi Arnd,
On 10/06/2015 03:24 PM, Arnd Bergmann wrote:
> A cleanup of the omap gpio driver introduced a use of the
> handle_bad_irq() function in a device driver that can be
> a loadable module.
>
> This broke the ARM allmodconfig build:
>
> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>
> This patch exports the handle_bad_irq symbol in order to
> allow the use in modules.
>
Thanks for fixing it and sorry for the mess.
Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index ea7b5fd99ba5..142bbf3b607f 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -35,6 +35,7 @@ void handle_bad_irq(struct irq_desc *desc)
> kstat_incr_irqs_this_cpu(desc);
> ack_bad_irq(irq);
> }
> +EXPORT_SYMBOL_GPL(handle_bad_irq);
>
> /*
> * Special, empty irq handler:
>
--
regards,
-grygorii
WARNING: multiple messages have this Message-ID (diff)
From: Grygorii Strashko <grygorii.strashko@ti.com>
To: Arnd Bergmann <arnd@arndb.de>, Thomas Gleixner <tglx@linutronix.de>
Cc: <linux-kernel@vger.kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Austin Schuh <austin@peloton-tech.com>,
Tony Lindgren <tony@atomide.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-gpio@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] genirq: export handle_bad_irq
Date: Wed, 7 Oct 2015 14:18:24 -0500 [thread overview]
Message-ID: <56157000.4010009@ti.com> (raw)
In-Reply-To: <5847725.4IBopItaOr@wuerfel>
Hi Arnd,
On 10/06/2015 03:24 PM, Arnd Bergmann wrote:
> A cleanup of the omap gpio driver introduced a use of the
> handle_bad_irq() function in a device driver that can be
> a loadable module.
>
> This broke the ARM allmodconfig build:
>
> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>
> This patch exports the handle_bad_irq symbol in order to
> allow the use in modules.
>
Thanks for fixing it and sorry for the mess.
Tested-by: Grygorii Strashko <grygorii.strashko@ti.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
>
> diff --git a/kernel/irq/handle.c b/kernel/irq/handle.c
> index ea7b5fd99ba5..142bbf3b607f 100644
> --- a/kernel/irq/handle.c
> +++ b/kernel/irq/handle.c
> @@ -35,6 +35,7 @@ void handle_bad_irq(struct irq_desc *desc)
> kstat_incr_irqs_this_cpu(desc);
> ack_bad_irq(irq);
> }
> +EXPORT_SYMBOL_GPL(handle_bad_irq);
>
> /*
> * Special, empty irq handler:
>
--
regards,
-grygorii
next prev parent reply other threads:[~2015-10-07 19:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-06 20:24 [PATCH] genirq: export handle_bad_irq Arnd Bergmann
2015-10-06 20:24 ` Arnd Bergmann
2015-10-06 20:51 ` kbuild test robot
2015-10-06 20:51 ` kbuild test robot
2015-10-06 20:59 ` [PATCH] genirq: fix handle_bad_irq kerneldoc comment Arnd Bergmann
2015-10-06 20:59 ` Arnd Bergmann
2015-10-09 15:21 ` [tip:irq/urgent] genirq: Fix " tip-bot for Arnd Bergmann
2015-10-07 19:18 ` Grygorii Strashko [this message]
2015-10-07 19:18 ` [PATCH] genirq: export handle_bad_irq Grygorii Strashko
2015-10-07 19:18 ` Grygorii Strashko
2015-10-09 15:21 ` [tip:irq/urgent] genirq: Export handle_bad_irq tip-bot for Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56157000.4010009@ti.com \
--to=grygorii.strashko@ti.com \
--cc=arnd@arndb.de \
--cc=austin@peloton-tech.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.