From: w.f@huawei.com (wangfei)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/8] dt-bindings: pmic: Document Hi655x pmic driver
Date: Thu, 8 Oct 2015 14:33:06 +0800 [thread overview]
Message-ID: <56160E22.3010703@huawei.com> (raw)
In-Reply-To: <20150930173921.GJ15635@sirena.org.uk>
On 2015/10/1 1:39, Mark Brown wrote:
> On Wed, Sep 30, 2015 at 07:05:04PM +0800, Fei Wang wrote:
>
>> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
>> +
>> +hi655x consists of a large and varied group of sub-devices:
>> +
>> +Device Supply Names Description
>> +------ ------------ -----------
>> +hi655x-powerkey : : Powerkey
>> +hi655x-regulator-pmic : : Regulators
>> +hi655x-usbvbus : : USB plug detection
>> +hi655x-pmu-rtc : : RTC
>> +hi655x-coul : : Coulomb
>
> ...counter?
>
> There's no documentation of the bindings for any of the above devices or
> how things are structured, you need to provide binding documentation
> which is understandable standalone. None of the properties are
> documented, nor is the set of regulators supported or how this is
> structured.
OK,i will add them.
>
>> + coul: coul at 1 {
>> + compatible = "hisilicon,hi655x-coul";
>> + interrupt-parent = <&pmic>;
>> + interrupts = <24 0>, <25 0>, <26 0>, <27 0>;
>> + interrupt-names = "cl_int_i", "cl_out_i", "cl_in_i", "vbat_int_i";
>> + battery_product_index = <0>;
>
> For example, the "battery_product_index" property here is undocumented.
now on hikey, we only enable hi655x-regulator-pmic function, and regulator is child node of pmic.do i need to document regulator dt-binding in this file or create a new regulator dt-binding file?
>
WARNING: multiple messages have this Message-ID (diff)
From: wangfei <w.f@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux@arm.linux.org.uk, robh+dt@kernel.org, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
khilman@linaro.org, sameo@linux.intel.com, lee.jones@linaro.org,
lgirdwood@gmail.com, bintian.wang@huawei.com,
xuwei5@hisilicon.com, haojian.zhuang@linaro.org,
zhangfei.gao@linaro.org, guodong.xu@linaro.org,
jorge.ramirez-ortiz@linaro.org, puck.chen@hisilicon.com,
xuyiping@hisilicon.com, kong.kongxinwei@hisilicon.com,
z.liuxinliang@hisilicon.com, william.wfei@gmail.com,
zhongkaihua@huawei.com
Subject: Re: [PATCH 1/8] dt-bindings: pmic: Document Hi655x pmic driver
Date: Thu, 8 Oct 2015 14:33:06 +0800 [thread overview]
Message-ID: <56160E22.3010703@huawei.com> (raw)
In-Reply-To: <20150930173921.GJ15635@sirena.org.uk>
On 2015/10/1 1:39, Mark Brown wrote:
> On Wed, Sep 30, 2015 at 07:05:04PM +0800, Fei Wang wrote:
>
>> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
>> +
>> +hi655x consists of a large and varied group of sub-devices:
>> +
>> +Device Supply Names Description
>> +------ ------------ -----------
>> +hi655x-powerkey : : Powerkey
>> +hi655x-regulator-pmic : : Regulators
>> +hi655x-usbvbus : : USB plug detection
>> +hi655x-pmu-rtc : : RTC
>> +hi655x-coul : : Coulomb
>
> ...counter?
>
> There's no documentation of the bindings for any of the above devices or
> how things are structured, you need to provide binding documentation
> which is understandable standalone. None of the properties are
> documented, nor is the set of regulators supported or how this is
> structured.
OK,i will add them.
>
>> + coul: coul@1 {
>> + compatible = "hisilicon,hi655x-coul";
>> + interrupt-parent = <&pmic>;
>> + interrupts = <24 0>, <25 0>, <26 0>, <27 0>;
>> + interrupt-names = "cl_int_i", "cl_out_i", "cl_in_i", "vbat_int_i";
>> + battery_product_index = <0>;
>
> For example, the "battery_product_index" property here is undocumented.
now on hikey, we only enable hi655x-regulator-pmic function, and regulator is child node of pmic.do i need to document regulator dt-binding in this file or create a new regulator dt-binding file?
>
WARNING: multiple messages have this Message-ID (diff)
From: wangfei <w.f@huawei.com>
To: Mark Brown <broonie@kernel.org>
Cc: <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux@arm.linux.org.uk>, <robh+dt@kernel.org>,
<pawel.moll@arm.com>, <mark.rutland@arm.com>,
<ijc+devicetree@hellion.org.uk>, <khilman@linaro.org>,
<sameo@linux.intel.com>, <lee.jones@linaro.org>,
<lgirdwood@gmail.com>, <bintian.wang@huawei.com>,
<xuwei5@hisilicon.com>, <haojian.zhuang@linaro.org>,
<zhangfei.gao@linaro.org>, <guodong.xu@linaro.org>,
<jorge.ramirez-ortiz@linaro.org>, <puck.chen@hisilicon.com>,
<xuyiping@hisilicon.com>, <kong.kongxinwei@hisilicon.com>,
<z.liuxinliang@hisilicon.com>, <william.wfei@gmail.com>,
<zhongkaihua@huawei.com>
Subject: Re: [PATCH 1/8] dt-bindings: pmic: Document Hi655x pmic driver
Date: Thu, 8 Oct 2015 14:33:06 +0800 [thread overview]
Message-ID: <56160E22.3010703@huawei.com> (raw)
In-Reply-To: <20150930173921.GJ15635@sirena.org.uk>
On 2015/10/1 1:39, Mark Brown wrote:
> On Wed, Sep 30, 2015 at 07:05:04PM +0800, Fei Wang wrote:
>
>> +Hisilicon hi655x Power Management Integrated Circuit (PMIC)
>> +
>> +hi655x consists of a large and varied group of sub-devices:
>> +
>> +Device Supply Names Description
>> +------ ------------ -----------
>> +hi655x-powerkey : : Powerkey
>> +hi655x-regulator-pmic : : Regulators
>> +hi655x-usbvbus : : USB plug detection
>> +hi655x-pmu-rtc : : RTC
>> +hi655x-coul : : Coulomb
>
> ...counter?
>
> There's no documentation of the bindings for any of the above devices or
> how things are structured, you need to provide binding documentation
> which is understandable standalone. None of the properties are
> documented, nor is the set of regulators supported or how this is
> structured.
OK,i will add them.
>
>> + coul: coul@1 {
>> + compatible = "hisilicon,hi655x-coul";
>> + interrupt-parent = <&pmic>;
>> + interrupts = <24 0>, <25 0>, <26 0>, <27 0>;
>> + interrupt-names = "cl_int_i", "cl_out_i", "cl_in_i", "vbat_int_i";
>> + battery_product_index = <0>;
>
> For example, the "battery_product_index" property here is undocumented.
now on hikey, we only enable hi655x-regulator-pmic function, and regulator is child node of pmic.do i need to document regulator dt-binding in this file or create a new regulator dt-binding file?
>
next prev parent reply other threads:[~2015-10-08 6:33 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 11:05 [PATCH 0/8] Add Support for Hi6220 PMIC Hi6553 MFD Core and Regulator Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` [PATCH 1/8] dt-bindings: pmic: Document Hi655x pmic driver Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 17:39 ` Mark Brown
2015-09-30 17:39 ` Mark Brown
2015-09-30 17:39 ` Mark Brown
2015-10-08 6:33 ` wangfei [this message]
2015-10-08 6:33 ` wangfei
2015-10-08 6:33 ` wangfei
2015-10-12 16:49 ` Mark Brown
2015-10-12 16:49 ` Mark Brown
2015-10-01 7:56 ` Lee Jones
2015-10-01 7:56 ` Lee Jones
2015-10-01 7:56 ` Lee Jones
2015-10-01 7:58 ` Lee Jones
2015-10-01 7:58 ` Lee Jones
2015-10-08 7:03 ` wangfei
2015-10-08 7:03 ` wangfei
2015-10-08 7:03 ` wangfei
2015-09-30 11:05 ` [PATCH 2/8] mfd: Hi655x: Add support for PMIC Hi655x MFD Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` [PATCH 3/8] arm64: dts: add Hi655x pmic node Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` [PATCH 4/8] regulator: Hi655x: Add support for Hi655x regulator Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 17:58 ` Mark Brown
2015-09-30 17:58 ` Mark Brown
2015-09-30 17:58 ` Mark Brown
2015-10-08 7:38 ` wangfei
2015-10-08 7:38 ` wangfei
2015-10-08 7:38 ` wangfei
2015-10-08 7:47 ` Javier Martinez Canillas
2015-10-08 7:47 ` Javier Martinez Canillas
2015-10-08 7:47 ` Javier Martinez Canillas
2015-09-30 11:05 ` [PATCH 5/8] arm64: dts: Add Hi655x regulator config node Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` [PATCH 6/8] dt-bindings: mtcmos: Document Hi6220 mtcmos driver Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` [PATCH 7/8] mtcmos: Hi6220: Add Hi6220 mtcmos regulator driver Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` [PATCH 8/8] arm64: dts: Add Hi6220 mtcmos regulator node Fei Wang
2015-09-30 11:05 ` Fei Wang
2015-09-30 11:05 ` Fei Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56160E22.3010703@huawei.com \
--to=w.f@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.