From: hdegoede@redhat.com (Hans de Goede)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] Re: [PATCH 2/6] ARM: dts: sun7i: Enable USB DRC on Bananapi
Date: Thu, 8 Oct 2015 09:37:39 +0100 [thread overview]
Message-ID: <56162B53.8020800@redhat.com> (raw)
In-Reply-To: <20151001083242.GB7104@lukather>
Hi,
On 10/01/2015 09:32 AM, Maxime Ripard wrote:
> Hi,
>
> On Tue, Sep 29, 2015 at 10:26:37AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 29-09-15 10:04, Maxime Ripard wrote:
>>> On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote:
>>>> Enable the otg/drc usb controller on the Bananapi.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
>>>
>>> Applied all the other patches but this one.
>>
>> Thanks, seems you did not push this to your git.kernel.org repo though ?
>
> I think I did, but maybe not at the time you sent the mail.
>
>>> Since we dropped the patch adding the regulators support on the
>>> Bananapi until we figure out why the board crash, it doesn't compile
>>> anymore.
>>
>> How about me doing a v2 of the regulators patch which removes the
>>
>> &cpu0 {
>> cpu-supply = <®_dcdc2>;
>> };
>>
>> So that we do not get cpu voltage scaling, then the regulator
>> changes should be a NOP, everything should just keep the u-boot
>> set voltages, and we can enable oth support.
>>
>> And then when we've figured out a safe way to enable cpu voltage
>> scaling we can do so with a follow up patch ?
>>
>> Is that a plan ? If so say yes and I'll do a v2 of these patches :)
>
> Yep, it sounds like a good plan :)
With the new v3 of the regulators patch with the corrected opp-s which
was just send this should no longer be necessary, can you apply the
original "ARM: dts: sun7i: Enable USB DRC on Bananapi" after applying
v3 of the regulators patch please ?
Regards,
Hans
WARNING: multiple messages have this Message-ID (diff)
From: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: [linux-sunxi] Re: [PATCH 2/6] ARM: dts: sun7i: Enable USB DRC on Bananapi
Date: Thu, 8 Oct 2015 09:37:39 +0100 [thread overview]
Message-ID: <56162B53.8020800@redhat.com> (raw)
In-Reply-To: <20151001083242.GB7104@lukather>
Hi,
On 10/01/2015 09:32 AM, Maxime Ripard wrote:
> Hi,
>
> On Tue, Sep 29, 2015 at 10:26:37AM +0200, Hans de Goede wrote:
>> Hi,
>>
>> On 29-09-15 10:04, Maxime Ripard wrote:
>>> On Tue, Sep 22, 2015 at 03:36:01PM +0200, Hans de Goede wrote:
>>>> Enable the otg/drc usb controller on the Bananapi.
>>>>
>>>> Signed-off-by: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>>>
>>> Applied all the other patches but this one.
>>
>> Thanks, seems you did not push this to your git.kernel.org repo though ?
>
> I think I did, but maybe not at the time you sent the mail.
>
>>> Since we dropped the patch adding the regulators support on the
>>> Bananapi until we figure out why the board crash, it doesn't compile
>>> anymore.
>>
>> How about me doing a v2 of the regulators patch which removes the
>>
>> &cpu0 {
>> cpu-supply = <®_dcdc2>;
>> };
>>
>> So that we do not get cpu voltage scaling, then the regulator
>> changes should be a NOP, everything should just keep the u-boot
>> set voltages, and we can enable oth support.
>>
>> And then when we've figured out a safe way to enable cpu voltage
>> scaling we can do so with a follow up patch ?
>>
>> Is that a plan ? If so say yes and I'll do a v2 of these patches :)
>
> Yep, it sounds like a good plan :)
With the new v3 of the regulators patch with the corrected opp-s which
was just send this should no longer be necessary, can you apply the
original "ARM: dts: sun7i: Enable USB DRC on Bananapi" after applying
v3 of the regulators patch please ?
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-08 8:37 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 13:36 [PATCH 1/6] ARM: dts: axp209: Add usb_power_supply child node to the ax209 node Hans de Goede
2015-09-22 13:36 ` Hans de Goede
2015-09-22 13:36 ` [PATCH 2/6] ARM: dts: sun7i: Enable USB DRC on Bananapi Hans de Goede
2015-09-22 13:36 ` Hans de Goede
2015-09-23 8:07 ` [linux-sunxi] " Jens Thiele
2015-09-23 8:07 ` Jens Thiele
2015-09-23 8:47 ` [linux-sunxi] " Hans de Goede
2015-09-23 8:47 ` Hans de Goede
2015-09-29 8:04 ` Maxime Ripard
2015-09-29 8:04 ` Maxime Ripard
2015-09-29 8:26 ` [linux-sunxi] " Hans de Goede
2015-09-29 8:26 ` Hans de Goede
2015-10-01 8:32 ` Maxime Ripard
2015-10-01 8:32 ` Maxime Ripard
2015-10-08 8:37 ` Hans de Goede [this message]
2015-10-08 8:37 ` [linux-sunxi] " Hans de Goede
2015-10-11 16:47 ` Maxime Ripard
2015-10-11 16:47 ` Maxime Ripard
2015-10-11 16:46 ` Maxime Ripard
2015-10-11 16:46 ` Maxime Ripard
2015-09-22 13:36 ` [PATCH 3/6] ARM: dts: sun7i: Enable USB DRC on orangepi-mini Hans de Goede
2015-09-22 13:36 ` Hans de Goede
2015-09-22 13:36 ` [PATCH 4/6] ARM: dts: sun7i: Enable USB DRC on the Orange pi Hans de Goede
2015-09-22 13:36 ` Hans de Goede
2015-09-22 13:36 ` [PATCH 5/6] ARM: dts: sun7i: Enable USB DRC on Wexler TAB7200 Hans de Goede
2015-09-22 13:36 ` Hans de Goede
2015-09-22 13:36 ` [PATCH 6/6] ARM: dts: sun7i: Add dts file for Wits Pro A20 DKT Hans de Goede
2015-09-22 13:36 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56162B53.8020800@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.