From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Denys Vlasenko <dvlasenk@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Richard Purdie <rpurdie@rpsys.net>,
Chris Wilson <chris@chris-wilson.co.uk>,
David Airlie <airlied@linux.ie>,
Alex Deucher <alexdeucher@gmail.com>,
Ben Skeggs <bskeggs@redhat.com>, Zhang Rui <rui.zhang@intel.com>,
Len Brown <lenb@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Dave Airlie <airlied@redhat.com>,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org
Subject: Re: [PATCH] radeonfb: Deinline large functions
Date: Thu, 08 Oct 2015 09:26:08 +0000 [thread overview]
Message-ID: <561636B0.1070509@ti.com> (raw)
In-Reply-To: <1443031073-7039-1-git-send-email-dvlasenk@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On 23/09/15 20:57, Denys Vlasenko wrote:
> With this .config: http://busybox.net/~vda/kernel_config,
> after uninlining these functions have sizes and callsite counts
> as follows:
>
> __OUTPLLP: 61 bytes, 12 callsites
> __INPLL: 79 bytes, 150 callsites
> __OUTPLL: 82 bytes, 138 callsites
> _OUTREGP: 101 bytes, 8 callsites
> _radeon_msleep: 66 bytes, 18 callsites
> _radeon_fifo_wait: 83 bytes, 24 callsites
> _radeon_engine_idle: 92 bytes, 10 callsites
> radeon_engine_flush: 105 bytes, 2 callsites
> radeon_pll_errata_after_index_slow: 31 bytes, 11 callsites
> radeon_pll_errata_after_data_slow: 91 bytes, 9 callsites
>
> radeon_pll_errata_after_FOO functions are split into two parts:
> the inlined part which checks corresponding rinfo->errata bit,
> and out-of-line part which performs workaround magic per se.
>
> Reduction in code size is about 49,500 bytes:
>
> text data bss dec hex filename
> 85789648 22294616 20627456 128711720 7abfc28 vmlinux.before
> 85740176 22294680 20627456 128662312 7ab3b28 vmlinux
Thanks, applying for 4.4.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Denys Vlasenko <dvlasenk@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Richard Purdie <rpurdie@rpsys.net>,
Chris Wilson <chris@chris-wilson.co.uk>,
David Airlie <airlied@linux.ie>,
Alex Deucher <alexdeucher@gmail.com>,
Ben Skeggs <bskeggs@redhat.com>, Zhang Rui <rui.zhang@intel.com>,
Len Brown <lenb@kernel.org>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Dave Airlie <airlied@redhat.com>, <linux-kernel@vger.kernel.org>,
<linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH] radeonfb: Deinline large functions
Date: Thu, 8 Oct 2015 12:26:08 +0300 [thread overview]
Message-ID: <561636B0.1070509@ti.com> (raw)
In-Reply-To: <1443031073-7039-1-git-send-email-dvlasenk@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On 23/09/15 20:57, Denys Vlasenko wrote:
> With this .config: http://busybox.net/~vda/kernel_config,
> after uninlining these functions have sizes and callsite counts
> as follows:
>
> __OUTPLLP: 61 bytes, 12 callsites
> __INPLL: 79 bytes, 150 callsites
> __OUTPLL: 82 bytes, 138 callsites
> _OUTREGP: 101 bytes, 8 callsites
> _radeon_msleep: 66 bytes, 18 callsites
> _radeon_fifo_wait: 83 bytes, 24 callsites
> _radeon_engine_idle: 92 bytes, 10 callsites
> radeon_engine_flush: 105 bytes, 2 callsites
> radeon_pll_errata_after_index_slow: 31 bytes, 11 callsites
> radeon_pll_errata_after_data_slow: 91 bytes, 9 callsites
>
> radeon_pll_errata_after_FOO functions are split into two parts:
> the inlined part which checks corresponding rinfo->errata bit,
> and out-of-line part which performs workaround magic per se.
>
> Reduction in code size is about 49,500 bytes:
>
> text data bss dec hex filename
> 85789648 22294616 20627456 128711720 7abfc28 vmlinux.before
> 85740176 22294680 20627456 128662312 7ab3b28 vmlinux
Thanks, applying for 4.4.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2015-10-08 9:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-23 17:57 [PATCH] radeonfb: Deinline large functions Denys Vlasenko
2015-09-23 17:57 ` Denys Vlasenko
2015-10-08 9:26 ` Tomi Valkeinen [this message]
2015-10-08 9:26 ` Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2015-05-18 14:25 Denys Vlasenko
2015-05-18 14:25 ` Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561636B0.1070509@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=alexdeucher@gmail.com \
--cc=benh@kernel.crashing.org \
--cc=bskeggs@redhat.com \
--cc=chris@chris-wilson.co.uk \
--cc=dvlasenk@redhat.com \
--cc=jbarnes@virtuousgeek.org \
--cc=lenb@kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plagnioj@jcrosoft.com \
--cc=rpurdie@rpsys.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.