From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Alexander Graf <agraf@suse.de>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH 2/5] hw/scsi/spapr_vscsi: Remove superfluous memset
Date: Thu, 8 Oct 2015 15:00:28 -0600 [thread overview]
Message-ID: <5616D96C.70604@redhat.com> (raw)
In-Reply-To: <1444332916-16476-3-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On 10/08/2015 01:35 PM, Thomas Huth wrote:
> g_malloc0 already clears the memory, so no need for
> the additional memset here.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/scsi/spapr_vscsi.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Alexander Graf <agraf@suse.de>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH 2/5] hw/scsi/spapr_vscsi: Remove superfluous memset
Date: Thu, 8 Oct 2015 15:00:28 -0600 [thread overview]
Message-ID: <5616D96C.70604@redhat.com> (raw)
In-Reply-To: <1444332916-16476-3-git-send-email-thuth@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 545 bytes --]
On 10/08/2015 01:35 PM, Thomas Huth wrote:
> g_malloc0 already clears the memory, so no need for
> the additional memset here.
>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Cc: David Gibson <david@gibson.dropbear.id.au>
> Cc: Alexander Graf <agraf@suse.de>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> hw/scsi/spapr_vscsi.c | 1 -
> 1 file changed, 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2015-10-08 21:04 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 19:35 [Qemu-trivial] [PATCH 0/5] Small optimizations for code using g_malloc0 + memset/memcpy Thomas Huth
2015-10-08 19:35 ` [Qemu-devel] " Thomas Huth
2015-10-08 19:35 ` [Qemu-trivial] [PATCH 1/5] hw/dma/pxa2xx: Remove superfluous memset Thomas Huth
2015-10-08 19:35 ` [Qemu-devel] " Thomas Huth
2015-10-08 20:59 ` [Qemu-trivial] " Eric Blake
2015-10-08 20:59 ` Eric Blake
2015-10-09 6:39 ` [Qemu-trivial] " Thomas Huth
2015-10-09 6:39 ` Thomas Huth
2015-10-08 19:35 ` [Qemu-trivial] [PATCH 2/5] hw/scsi/spapr_vscsi: " Thomas Huth
2015-10-08 19:35 ` [Qemu-devel] " Thomas Huth
2015-10-08 21:00 ` Eric Blake [this message]
2015-10-08 21:00 ` Eric Blake
2015-10-09 1:51 ` [Qemu-trivial] " David Gibson
2015-10-09 1:51 ` [Qemu-devel] " David Gibson
2015-10-08 19:35 ` [Qemu-trivial] [PATCH 3/5] hw/input/tsc210x: " Thomas Huth
2015-10-08 19:35 ` [Qemu-devel] " Thomas Huth
2015-10-08 23:34 ` [Qemu-trivial] " Eric Blake
2015-10-08 23:34 ` Eric Blake
2015-10-09 6:40 ` [Qemu-trivial] " Thomas Huth
2015-10-09 6:40 ` Thomas Huth
2015-10-08 19:35 ` [Qemu-trivial] [PATCH 4/5] tests/i44fx-test: No need for zeroing memory before memset Thomas Huth
2015-10-08 19:35 ` [Qemu-devel] " Thomas Huth
2015-10-08 20:24 ` [Qemu-trivial] " Laszlo Ersek
2015-10-08 20:24 ` [Qemu-devel] " Laszlo Ersek
2015-10-09 6:36 ` [Qemu-trivial] " Thomas Huth
2015-10-09 6:36 ` [Qemu-devel] " Thomas Huth
2015-10-09 6:46 ` [Qemu-trivial] " Markus Armbruster
2015-10-09 6:46 ` Markus Armbruster
2015-10-09 8:08 ` [Qemu-trivial] " Laszlo Ersek
2015-10-09 8:08 ` Laszlo Ersek
2015-10-08 19:35 ` [Qemu-trivial] [PATCH 5/5] linux-user/syscall: Replace g_malloc0 + memcpy with g_memdup Thomas Huth
2015-10-08 19:35 ` [Qemu-devel] " Thomas Huth
2015-10-08 23:32 ` [Qemu-trivial] " Eric Blake
2015-10-08 23:32 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5616D96C.70604@redhat.com \
--to=eblake@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.