From: petr.cvek@tul.cz (Petr Cvek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 12/26] ARM: pxa: magician: Rename charger cable detection EGPIOs
Date: Fri, 9 Oct 2015 04:33:46 +0200 [thread overview]
Message-ID: <5617278A.5060909@tul.cz> (raw)
In-Reply-To: <1443875934.4186.27.camel@gmail.com>
Dne 3.10.2015 v 14:38 Philipp Zabel napsal(a):
> Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek:
>> This patch renames EGPIOs, which are used for the charging cable
>> presence
>> and type detection. Old names did not correspond with an observed
>> functionality (on board_id 0x3a). The behavior is not:
>>
>> - AC charger
>> - USB charger
>> - Cable detection
>>
>> , but:
>>
>> - AC/USB type
>> - Cable detection1
>> - Cable detection2
>>
>> This patch fixes a possible typo in the bit offset for the cable
>> detection
>> EGPIO declaration, too.
>>
>> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
>
> Just to be sure, please tell me what are the values of those three
> EGPIOs while
> a) wall plug charger plugged in
> b) usb cable connected to a host plugged in
> c) no cable plugged in
usb charger none
==== ======= ====
0xC0 0xC0 0xC0
0xA0 0xA0 0xA0
0x61 0x61 0x61
0x00 0x00 0x00
0x02 0x03 0x00 //first cable detection and charger type
0x3A 0x3A 0x3A //send me your board_id
0x09 0x09 0x01 //second cable detection
0x04 0x04 0x04
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
I think the charger is original.
>
> It could well be there are differences between our boards.
Well it is CPLD chip, so they can have different bitstreams (OT: I can think of many CPLD HDL enhancements :-D).
Cheers,
Petr
WARNING: multiple messages have this Message-ID (diff)
From: Petr Cvek <petr.cvek@tul.cz>
To: Philipp Zabel <philipp.zabel@gmail.com>,
robert.jarzmik@free.fr, daniel@zonque.org,
haojian.zhuang@gmail.com, linux@arm.linux.org.uk
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 12/26] ARM: pxa: magician: Rename charger cable detection EGPIOs
Date: Fri, 9 Oct 2015 04:33:46 +0200 [thread overview]
Message-ID: <5617278A.5060909@tul.cz> (raw)
In-Reply-To: <1443875934.4186.27.camel@gmail.com>
Dne 3.10.2015 v 14:38 Philipp Zabel napsal(a):
> Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek:
>> This patch renames EGPIOs, which are used for the charging cable
>> presence
>> and type detection. Old names did not correspond with an observed
>> functionality (on board_id 0x3a). The behavior is not:
>>
>> - AC charger
>> - USB charger
>> - Cable detection
>>
>> , but:
>>
>> - AC/USB type
>> - Cable detection1
>> - Cable detection2
>>
>> This patch fixes a possible typo in the bit offset for the cable
>> detection
>> EGPIO declaration, too.
>>
>> Signed-off-by: Petr Cvek <petr.cvek@tul.cz>
>
> Just to be sure, please tell me what are the values of those three
> EGPIOs while
> a) wall plug charger plugged in
> b) usb cable connected to a host plugged in
> c) no cable plugged in
usb charger none
==== ======= ====
0xC0 0xC0 0xC0
0xA0 0xA0 0xA0
0x61 0x61 0x61
0x00 0x00 0x00
0x02 0x03 0x00 //first cable detection and charger type
0x3A 0x3A 0x3A //send me your board_id
0x09 0x09 0x01 //second cable detection
0x04 0x04 0x04
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
0x00 0x00 0x00
I think the charger is original.
>
> It could well be there are differences between our boards.
Well it is CPLD chip, so they can have different bitstreams (OT: I can think of many CPLD HDL enhancements :-D).
Cheers,
Petr
next prev parent reply other threads:[~2015-10-09 2:33 UTC|newest]
Thread overview: 118+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1443472089.git.petr.cvek@tul.cz>
2015-09-28 21:09 ` [PATCH v4 01/26] ARM: pxa: magician: Fix indentation in machine files Petr Cvek
2015-09-28 21:09 ` Petr Cvek
2015-10-03 12:14 ` Philipp Zabel
2015-10-03 12:14 ` Philipp Zabel
2015-09-28 21:10 ` [PATCH v4 02/26] ARM: pxa: magician: Change comments to be more informative Petr Cvek
2015-09-28 21:10 ` Petr Cvek
2015-10-03 12:19 ` Philipp Zabel
2015-10-03 12:19 ` Philipp Zabel
2015-10-13 20:08 ` Robert Jarzmik
2015-10-13 20:08 ` Robert Jarzmik
2015-09-28 21:10 ` [PATCH v4 03/26] ARM: pxa: magician: Print more specific error message for global GPIOs Petr Cvek
2015-09-28 21:10 ` Petr Cvek
2015-10-03 12:19 ` Philipp Zabel
2015-10-03 12:19 ` Philipp Zabel
2015-09-28 21:11 ` [PATCH v4 04/26] ARM: pxa: magician: Optimize debug messages for LCD power Petr Cvek
2015-09-28 21:11 ` Petr Cvek
2015-10-03 12:20 ` Philipp Zabel
2015-10-03 12:20 ` Philipp Zabel
2015-09-28 21:11 ` [PATCH v4 05/26] ARM: pxa: magician: Change description of LCD power GPIO Petr Cvek
2015-09-28 21:11 ` Petr Cvek
2015-10-03 12:21 ` Philipp Zabel
2015-10-03 12:21 ` Philipp Zabel
2015-09-28 21:15 ` [PATCH v4 06/26] ARM: pxa: magician: Add new discovered EGPIO pins Petr Cvek
2015-09-28 21:15 ` Petr Cvek
2015-10-03 12:23 ` Philipp Zabel
2015-10-03 12:23 ` Philipp Zabel
2015-09-28 21:15 ` [PATCH v4 07/26] ARM: pxa: magician: Fix HTC Magician pin mux definitions Petr Cvek
2015-09-28 21:15 ` Petr Cvek
2015-10-03 12:30 ` Philipp Zabel
2015-10-03 12:30 ` Philipp Zabel
2015-10-05 2:15 ` Petr Cvek
2015-10-05 2:15 ` Petr Cvek
2015-10-13 20:09 ` Robert Jarzmik
2015-10-13 20:09 ` Robert Jarzmik
2015-09-28 21:15 ` [PATCH v4 08/26] ARM: pxa: magician: Rename abstract LCD GPIOs Petr Cvek
2015-09-28 21:15 ` Petr Cvek
2015-10-03 12:31 ` Philipp Zabel
2015-10-03 12:31 ` Philipp Zabel
2015-09-28 21:16 ` [PATCH v4 09/26] ARM: pxa: magician: Optimize powerup delays for Samsung LCD Petr Cvek
2015-09-28 21:16 ` Petr Cvek
2015-10-03 12:32 ` Philipp Zabel
2015-10-03 12:32 ` Philipp Zabel
2015-09-28 21:32 ` [PATCH v4 10/26] ARM: pxa: magician: Optimize Samsung LCD refresh to 50Hz Petr Cvek
2015-09-28 21:32 ` Petr Cvek
2015-10-03 12:33 ` Philipp Zabel
2015-10-03 12:33 ` Philipp Zabel
2015-09-28 21:32 ` [PATCH v4 11/26] ARM: pxa: magician: Optimize EGPIO initial values Petr Cvek
2015-09-28 21:32 ` Petr Cvek
2015-10-03 12:35 ` Philipp Zabel
2015-10-03 12:35 ` Philipp Zabel
2015-10-07 19:45 ` Robert Jarzmik
2015-10-07 19:45 ` Robert Jarzmik
2015-09-28 21:32 ` [PATCH v4 12/26] ARM: pxa: magician: Rename charger cable detection EGPIOs Petr Cvek
2015-09-28 21:32 ` Petr Cvek
2015-10-03 12:38 ` Philipp Zabel
2015-10-03 12:38 ` Philipp Zabel
2015-10-09 2:33 ` Petr Cvek [this message]
2015-10-09 2:33 ` Petr Cvek
2015-09-28 21:33 ` [PATCH v4 13/26] ARM: pxa: magician: Fix and add charging detection functions Petr Cvek
2015-09-28 21:33 ` Petr Cvek
2015-09-28 21:33 ` [PATCH v4 14/26] ARM: pxa: magician: Fix platform data for both PXA27x I2C controllers Petr Cvek
2015-09-28 21:33 ` Petr Cvek
2015-10-03 12:41 ` Philipp Zabel
2015-10-03 12:41 ` Philipp Zabel
2015-09-28 21:34 ` [PATCH v4 15/26] ARM: pxa: magician: Fix redundant GPIO request for pxaficp_ir Petr Cvek
2015-09-28 21:34 ` Petr Cvek
2015-09-28 21:34 ` [PATCH v4 16/26] ARM: pxa: magician: Fix support for Intel Strata NOR Flash Petr Cvek
2015-09-28 21:34 ` Petr Cvek
2015-09-28 21:38 ` [PATCH v4 17/26] ARM: pxa: magician: Fix wrongly enabled USB host ports Petr Cvek
2015-09-28 21:38 ` Petr Cvek
2015-10-03 12:45 ` Philipp Zabel
2015-10-03 12:45 ` Philipp Zabel
2015-10-05 2:03 ` Petr Cvek
2015-10-05 2:03 ` Petr Cvek
2015-09-28 21:38 ` [PATCH v4 18/26] ARM: pxa: magician: Add support for ADS7846 Petr Cvek
2015-09-28 21:38 ` Petr Cvek
2015-10-03 12:49 ` Philipp Zabel
2015-10-03 12:49 ` Philipp Zabel
2015-10-12 4:39 ` Petr Cvek
2015-10-12 4:39 ` Petr Cvek
2015-09-28 21:38 ` [PATCH v4 19/26] ARM: pxa: magician: Add support for Omnivision OV9640 camera Petr Cvek
2015-09-28 21:38 ` Petr Cvek
2015-10-03 12:50 ` Philipp Zabel
2015-10-03 12:50 ` Philipp Zabel
2015-10-07 19:49 ` Robert Jarzmik
2015-10-07 19:49 ` Robert Jarzmik
2015-10-08 6:05 ` Petr Cvek
2015-10-08 6:05 ` Petr Cvek
2015-09-28 21:39 ` [PATCH v4 20/26] ARM: pxa: magician: Add support for MAX1587A Vcore regulator Petr Cvek
2015-09-28 21:39 ` Petr Cvek
2015-10-03 12:57 ` Philipp Zabel
2015-10-03 12:57 ` Philipp Zabel
2015-10-13 20:16 ` Robert Jarzmik
2015-10-13 20:16 ` Robert Jarzmik
2015-09-28 21:39 ` [PATCH v4 21/26] ARM: pxa: magician: Add support for PXA27x UDC Petr Cvek
2015-09-28 21:39 ` Petr Cvek
2015-10-03 12:58 ` Philipp Zabel
2015-10-03 12:58 ` Philipp Zabel
2015-10-13 20:29 ` Robert Jarzmik
2015-10-13 20:29 ` Robert Jarzmik
2015-09-28 21:39 ` [PATCH v4 22/26] ARM: pxa: magician: Remove pdata for pasic3-leds Petr Cvek
2015-09-28 21:39 ` Petr Cvek
2015-10-03 12:59 ` Philipp Zabel
2015-10-03 12:59 ` Philipp Zabel
2015-10-13 20:32 ` Robert Jarzmik
2015-10-13 20:32 ` Robert Jarzmik
2015-09-28 21:40 ` [PATCH v4 23/26] ARM: pxa: magician: Remove definition of the STUART port Petr Cvek
2015-09-28 21:40 ` Petr Cvek
2015-09-28 21:40 ` [PATCH v4 24/26] ARM: pxa: magician: Add debug message for backlight brightness function Petr Cvek
2015-09-28 21:40 ` Petr Cvek
2015-09-28 21:40 ` [PATCH v4 25/26] ARM: pxa: magician: Add missing regulator for PWM backlight Petr Cvek
2015-09-28 21:40 ` Petr Cvek
2015-10-03 13:02 ` Philipp Zabel
2015-10-03 13:02 ` Philipp Zabel
2015-09-28 21:42 ` [PATCH v4 26/26] ARM: pxa: magician: Move platform_add_devices() to the end of magician_init() Petr Cvek
2015-09-28 21:42 ` Petr Cvek
2015-10-03 13:04 ` Philipp Zabel
2015-10-03 13:04 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5617278A.5060909@tul.cz \
--to=petr.cvek@tul.cz \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.