All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org, linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH] mac80211: save he oper info in bss config for AP and mesh
Date: Mon, 12 Oct 2020 09:41:25 -0700	[thread overview]
Message-ID: <561813d2d5a5268261c48e51a6ad90b9@codeaurora.org> (raw)
In-Reply-To: <f6daeb86f2cf83f57785e08b86fecfdf6410de46.camel@sipsolutions.net>


>> -u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def 
>> *chandef)
>> +u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def 
>> *chandef,
>> +			       struct ieee80211_sub_if_data *sdata)
>>  {
>>  	struct ieee80211_he_operation *he_oper;
>>  	struct ieee80211_he_6ghz_oper *he_6ghz_op;
>> @@ -3056,6 +3057,7 @@ u8 *ieee80211_ie_build_he_oper(u8 *pos, struct 
>> cfg80211_chan_def *chandef)
>>  	he_oper = (struct ieee80211_he_operation *)pos;
>>  	he_oper->he_oper_params = cpu_to_le32(he_oper_params);
>> 
>> +	sdata->vif.bss_conf.he_oper.params = he_oper_params;
> 
> I think these changes are inappropriate. This is a helper function to
> build something, not to store the data. Please change the callers
> instead.
> 
> johannes
Hi Johannes,

Sorry for late response..

Thanks for the review.. I have tried to address the review comments
provided and created new series @ 
https://patchwork.kernel.org/cover/11824871/

Thanks
Pradeep

      reply	other threads:[~2020-10-12 16:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-15  3:09 [PATCH] mac80211: save he oper info in bss config for AP and mesh Pradeep Kumar Chitrapu
2020-07-15  5:39 ` kernel test robot
2020-07-15  5:39   ` kernel test robot
2020-07-30 11:24 ` Johannes Berg
2020-10-12 16:41   ` Pradeep Kumar Chitrapu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561813d2d5a5268261c48e51a6ad90b9@codeaurora.org \
    --to=pradeepc@codeaurora.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless-owner@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.