From: kernel test robot <lkp@intel.com>
To: Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>,
Johannes Berg <johannes@sipsolutions.net>
Cc: kbuild-all@lists.01.org, linux-wireless@vger.kernel.org,
Pradeep Kumar Chitrapu <pradeepc@codeaurora.org>
Subject: Re: [PATCH] mac80211: save he oper info in bss config for AP and mesh
Date: Wed, 15 Jul 2020 13:39:48 +0800 [thread overview]
Message-ID: <202007151346.Zle65KYB%lkp@intel.com> (raw)
In-Reply-To: <20200715030937.25290-1-pradeepc@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 4686 bytes --]
Hi Pradeep,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mac80211-next/master]
[also build test ERROR on mac80211/master v5.8-rc5 next-20200714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Pradeep-Kumar-Chitrapu/mac80211-save-he-oper-info-in-bss-config-for-AP-and-mesh/20200715-111048
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: mips-malta_kvm_guest_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/mac80211/mesh.c: In function 'mesh_add_he_oper_ie':
>> net/mac80211/mesh.c:614:2: error: too few arguments to function 'ieee80211_ie_build_he_oper'
614 | ieee80211_ie_build_he_oper(pos, &sdata->vif.bss_conf.chandef);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from net/mac80211/mesh.c:11:
net/mac80211/ieee80211_i.h:2187:5: note: declared here
2187 | u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def *chandef,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/ieee80211_ie_build_he_oper +614 net/mac80211/mesh.c
60ad72da55ac74 Sven Eckelmann 2019-07-24 584
60ad72da55ac74 Sven Eckelmann 2019-07-24 585 int mesh_add_he_oper_ie(struct ieee80211_sub_if_data *sdata,
60ad72da55ac74 Sven Eckelmann 2019-07-24 586 struct sk_buff *skb)
60ad72da55ac74 Sven Eckelmann 2019-07-24 587 {
60ad72da55ac74 Sven Eckelmann 2019-07-24 588 const struct ieee80211_sta_he_cap *he_cap;
60ad72da55ac74 Sven Eckelmann 2019-07-24 589 struct ieee80211_supported_band *sband;
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 590 u32 len;
60ad72da55ac74 Sven Eckelmann 2019-07-24 591 u8 *pos;
60ad72da55ac74 Sven Eckelmann 2019-07-24 592
60ad72da55ac74 Sven Eckelmann 2019-07-24 593 sband = ieee80211_get_sband(sdata);
60ad72da55ac74 Sven Eckelmann 2019-07-24 594 if (!sband)
60ad72da55ac74 Sven Eckelmann 2019-07-24 595 return -EINVAL;
60ad72da55ac74 Sven Eckelmann 2019-07-24 596
60ad72da55ac74 Sven Eckelmann 2019-07-24 597 he_cap = ieee80211_get_he_iftype_cap(sband, NL80211_IFTYPE_MESH_POINT);
60ad72da55ac74 Sven Eckelmann 2019-07-24 598 if (!he_cap ||
60ad72da55ac74 Sven Eckelmann 2019-07-24 599 sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20_NOHT ||
60ad72da55ac74 Sven Eckelmann 2019-07-24 600 sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_5 ||
60ad72da55ac74 Sven Eckelmann 2019-07-24 601 sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10)
60ad72da55ac74 Sven Eckelmann 2019-07-24 602 return 0;
60ad72da55ac74 Sven Eckelmann 2019-07-24 603
ef32fba11e9097 Pradeep Kumar Chitrapu 2020-07-14 604 sdata->vif.bss_conf.he_support = true;
ef32fba11e9097 Pradeep Kumar Chitrapu 2020-07-14 605
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 606 len = 2 + 1 + sizeof(struct ieee80211_he_operation);
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 607 if (sdata->vif.bss_conf.chandef.chan->band == NL80211_BAND_6GHZ)
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 608 len += sizeof(struct ieee80211_he_6ghz_oper);
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 609
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 610 if (skb_tailroom(skb) < len)
60ad72da55ac74 Sven Eckelmann 2019-07-24 611 return -ENOMEM;
60ad72da55ac74 Sven Eckelmann 2019-07-24 612
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 613 pos = skb_put(skb, len);
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 @614 ieee80211_ie_build_he_oper(pos, &sdata->vif.bss_conf.chandef);
60ad72da55ac74 Sven Eckelmann 2019-07-24 615
60ad72da55ac74 Sven Eckelmann 2019-07-24 616 return 0;
60ad72da55ac74 Sven Eckelmann 2019-07-24 617 }
60ad72da55ac74 Sven Eckelmann 2019-07-24 618
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 20960 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH] mac80211: save he oper info in bss config for AP and mesh
Date: Wed, 15 Jul 2020 13:39:48 +0800 [thread overview]
Message-ID: <202007151346.Zle65KYB%lkp@intel.com> (raw)
In-Reply-To: <20200715030937.25290-1-pradeepc@codeaurora.org>
[-- Attachment #1: Type: text/plain, Size: 4763 bytes --]
Hi Pradeep,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on mac80211-next/master]
[also build test ERROR on mac80211/master v5.8-rc5 next-20200714]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Pradeep-Kumar-Chitrapu/mac80211-save-he-oper-info-in-bss-config-for-AP-and-mesh/20200715-111048
base: https://git.kernel.org/pub/scm/linux/kernel/git/jberg/mac80211-next.git master
config: mips-malta_kvm_guest_defconfig (attached as .config)
compiler: mipsel-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
net/mac80211/mesh.c: In function 'mesh_add_he_oper_ie':
>> net/mac80211/mesh.c:614:2: error: too few arguments to function 'ieee80211_ie_build_he_oper'
614 | ieee80211_ie_build_he_oper(pos, &sdata->vif.bss_conf.chandef);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from net/mac80211/mesh.c:11:
net/mac80211/ieee80211_i.h:2187:5: note: declared here
2187 | u8 *ieee80211_ie_build_he_oper(u8 *pos, struct cfg80211_chan_def *chandef,
| ^~~~~~~~~~~~~~~~~~~~~~~~~~
vim +/ieee80211_ie_build_he_oper +614 net/mac80211/mesh.c
60ad72da55ac74 Sven Eckelmann 2019-07-24 584
60ad72da55ac74 Sven Eckelmann 2019-07-24 585 int mesh_add_he_oper_ie(struct ieee80211_sub_if_data *sdata,
60ad72da55ac74 Sven Eckelmann 2019-07-24 586 struct sk_buff *skb)
60ad72da55ac74 Sven Eckelmann 2019-07-24 587 {
60ad72da55ac74 Sven Eckelmann 2019-07-24 588 const struct ieee80211_sta_he_cap *he_cap;
60ad72da55ac74 Sven Eckelmann 2019-07-24 589 struct ieee80211_supported_band *sband;
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 590 u32 len;
60ad72da55ac74 Sven Eckelmann 2019-07-24 591 u8 *pos;
60ad72da55ac74 Sven Eckelmann 2019-07-24 592
60ad72da55ac74 Sven Eckelmann 2019-07-24 593 sband = ieee80211_get_sband(sdata);
60ad72da55ac74 Sven Eckelmann 2019-07-24 594 if (!sband)
60ad72da55ac74 Sven Eckelmann 2019-07-24 595 return -EINVAL;
60ad72da55ac74 Sven Eckelmann 2019-07-24 596
60ad72da55ac74 Sven Eckelmann 2019-07-24 597 he_cap = ieee80211_get_he_iftype_cap(sband, NL80211_IFTYPE_MESH_POINT);
60ad72da55ac74 Sven Eckelmann 2019-07-24 598 if (!he_cap ||
60ad72da55ac74 Sven Eckelmann 2019-07-24 599 sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20_NOHT ||
60ad72da55ac74 Sven Eckelmann 2019-07-24 600 sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_5 ||
60ad72da55ac74 Sven Eckelmann 2019-07-24 601 sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_10)
60ad72da55ac74 Sven Eckelmann 2019-07-24 602 return 0;
60ad72da55ac74 Sven Eckelmann 2019-07-24 603
ef32fba11e9097 Pradeep Kumar Chitrapu 2020-07-14 604 sdata->vif.bss_conf.he_support = true;
ef32fba11e9097 Pradeep Kumar Chitrapu 2020-07-14 605
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 606 len = 2 + 1 + sizeof(struct ieee80211_he_operation);
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 607 if (sdata->vif.bss_conf.chandef.chan->band == NL80211_BAND_6GHZ)
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 608 len += sizeof(struct ieee80211_he_6ghz_oper);
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 609
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 610 if (skb_tailroom(skb) < len)
60ad72da55ac74 Sven Eckelmann 2019-07-24 611 return -ENOMEM;
60ad72da55ac74 Sven Eckelmann 2019-07-24 612
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 613 pos = skb_put(skb, len);
d1b7524b3ea140 Rajkumar Manoharan 2020-05-28 @614 ieee80211_ie_build_he_oper(pos, &sdata->vif.bss_conf.chandef);
60ad72da55ac74 Sven Eckelmann 2019-07-24 615
60ad72da55ac74 Sven Eckelmann 2019-07-24 616 return 0;
60ad72da55ac74 Sven Eckelmann 2019-07-24 617 }
60ad72da55ac74 Sven Eckelmann 2019-07-24 618
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 20960 bytes --]
next prev parent reply other threads:[~2020-07-15 5:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 3:09 [PATCH] mac80211: save he oper info in bss config for AP and mesh Pradeep Kumar Chitrapu
2020-07-15 5:39 ` kernel test robot [this message]
2020-07-15 5:39 ` kernel test robot
2020-07-30 11:24 ` Johannes Berg
2020-10-12 16:41 ` Pradeep Kumar Chitrapu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007151346.Zle65KYB%lkp@intel.com \
--to=lkp@intel.com \
--cc=johannes@sipsolutions.net \
--cc=kbuild-all@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pradeepc@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.