From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Wolfram Sang <wsa@the-dreams.de>, linux-i2c@vger.kernel.org
Cc: k.kozlowski.k@gmail.com,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Kukjin Kim <kgene@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core
Date: Sat, 10 Oct 2015 16:47:45 +0900 [thread overview]
Message-ID: <5618C2A1.2030101@samsung.com> (raw)
In-Reply-To: <1444461874-2841-1-git-send-email-wsa@the-dreams.de>
W dniu 10.10.2015 o 16:24, Wolfram Sang pisze:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> The core may register clients attached to this master which may use
> funtionality from the master. So, RuntimePM must be enabled before, otherwise
> this will fail. While here, move drvdata, too.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Changes since v2: don't call runtime pm on adaper if it wasn't registered
>
> Thanks to Krzysztof for testing!
>
> drivers/i2c/busses/i2c-s3c2410.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Works good. Error path seems to be working fine as well.
Tested on Odroid-XU3 Lite, on top of next-20151009.
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core
Date: Sat, 10 Oct 2015 16:47:45 +0900 [thread overview]
Message-ID: <5618C2A1.2030101@samsung.com> (raw)
In-Reply-To: <1444461874-2841-1-git-send-email-wsa@the-dreams.de>
W dniu 10.10.2015 o 16:24, Wolfram Sang pisze:
> From: Wolfram Sang <wsa+renesas@sang-engineering.com>
>
> The core may register clients attached to this master which may use
> funtionality from the master. So, RuntimePM must be enabled before, otherwise
> this will fail. While here, move drvdata, too.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Changes since v2: don't call runtime pm on adaper if it wasn't registered
>
> Thanks to Krzysztof for testing!
>
> drivers/i2c/busses/i2c-s3c2410.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
Works good. Error path seems to be working fine as well.
Tested on Odroid-XU3 Lite, on top of next-20151009.
Tested-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Best regards,
Krzysztof
next prev parent reply other threads:[~2015-10-10 7:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-10 7:24 [PATCH v3] i2c: s3c2410: enable RuntimePM before registering to the core Wolfram Sang
2015-10-10 7:24 ` Wolfram Sang
2015-10-10 7:47 ` Krzysztof Kozlowski [this message]
2015-10-10 7:47 ` Krzysztof Kozlowski
2015-10-12 19:15 ` Kukjin Kim
2015-10-12 19:15 ` Kukjin Kim
2015-10-15 11:44 ` Wolfram Sang
2015-10-15 11:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5618C2A1.2030101@samsung.com \
--to=k.kozlowski@samsung.com \
--cc=k.kozlowski.k@gmail.com \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.