From: vz@mleia.com (Vladimir Zapolskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] arm: dts: lpc32xx: remove unneeded cell settings from cpus
Date: Tue, 13 Oct 2015 13:03:05 +0300 [thread overview]
Message-ID: <561CD6D9.1020102@mleia.com> (raw)
In-Reply-To: <CAGhQ9VwBcUxZr7A57feuUNs0OcNpHn4wwmGommVg6e-B0=tsBA@mail.gmail.com>
Hi Joachim,
On 13.10.2015 11:18, Joachim Eastwood wrote:
> Hi Vladimir,
>
> On 13 October 2015 at 01:54, Vladimir Zapolskiy <vz@mleia.com> wrote:
>> There is no addressable devices under cpus device node, remove noisy
>> address and size cells properties.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
>> ---
>> arch/arm/boot/dts/lpc32xx.dtsi | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi
>> index dcb52cb..929458d 100644
>> --- a/arch/arm/boot/dts/lpc32xx.dtsi
>> +++ b/arch/arm/boot/dts/lpc32xx.dtsi
>> @@ -18,9 +18,6 @@
>> interrupt-parent = <&mic>;
>>
>> cpus {
>> - #address-cells = <0>;
>> - #size-cells = <0>;
>> -
>
> According to Documentation/devicetree/bindings/arm/cpus.txt these
> properties are required.
>
> Take a look at Example 3 in the doc for it should look like on a ARM
> 926EJ-S uniprocessor 32-bit system.
thank you for review and pointing the fact out, then according to
documentation #address-cells must be set to 1 plus reg property in cpu
node is missing, I'll send a fix as patch v2 4/5.
--
With best wishes,
Vladimir
WARNING: multiple messages have this Message-ID (diff)
From: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
To: Joachim Eastwood <manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Roland Stigge <stigge-uj/7R2tJ6VmzQB+pC5nmwQ@public.gmane.org>,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Grant Likely
<grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH 4/5] arm: dts: lpc32xx: remove unneeded cell settings from cpus
Date: Tue, 13 Oct 2015 13:03:05 +0300 [thread overview]
Message-ID: <561CD6D9.1020102@mleia.com> (raw)
In-Reply-To: <CAGhQ9VwBcUxZr7A57feuUNs0OcNpHn4wwmGommVg6e-B0=tsBA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
Hi Joachim,
On 13.10.2015 11:18, Joachim Eastwood wrote:
> Hi Vladimir,
>
> On 13 October 2015 at 01:54, Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org> wrote:
>> There is no addressable devices under cpus device node, remove noisy
>> address and size cells properties.
>>
>> Signed-off-by: Vladimir Zapolskiy <vz-ChpfBGZJDbMAvxtiuMwx3w@public.gmane.org>
>> ---
>> arch/arm/boot/dts/lpc32xx.dtsi | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/lpc32xx.dtsi b/arch/arm/boot/dts/lpc32xx.dtsi
>> index dcb52cb..929458d 100644
>> --- a/arch/arm/boot/dts/lpc32xx.dtsi
>> +++ b/arch/arm/boot/dts/lpc32xx.dtsi
>> @@ -18,9 +18,6 @@
>> interrupt-parent = <&mic>;
>>
>> cpus {
>> - #address-cells = <0>;
>> - #size-cells = <0>;
>> -
>
> According to Documentation/devicetree/bindings/arm/cpus.txt these
> properties are required.
>
> Take a look at Example 3 in the doc for it should look like on a ARM
> 926EJ-S uniprocessor 32-bit system.
thank you for review and pointing the fact out, then according to
documentation #address-cells must be set to 1 plus reg property in cpu
node is missing, I'll send a fix as patch v2 4/5.
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-10-13 10:03 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 23:54 [PATCH 0/5] arm: dts: lpc32xx: fixes and updates to lpc32xx.dtsi Vladimir Zapolskiy
2015-10-12 23:54 ` Vladimir Zapolskiy
2015-10-12 23:54 ` [PATCH 1/5] arm: dts: lpc32xx: change include syntax to be C preprocessor friendly Vladimir Zapolskiy
2015-10-12 23:54 ` Vladimir Zapolskiy
2015-10-12 23:54 ` [PATCH 2/5] arm: dts: lpc32xx: fix improper usage of ranges property Vladimir Zapolskiy
2015-10-12 23:54 ` Vladimir Zapolskiy
2015-10-13 12:44 ` Arnd Bergmann
2015-10-13 12:44 ` Arnd Bergmann
2015-10-13 15:51 ` Vladimir Zapolskiy
2015-10-13 15:51 ` Vladimir Zapolskiy
2015-10-13 19:36 ` Arnd Bergmann
2015-10-13 19:36 ` Arnd Bergmann
2015-10-13 23:13 ` Vladimir Zapolskiy
2015-10-13 23:13 ` Vladimir Zapolskiy
2015-10-14 13:52 ` Arnd Bergmann
2015-10-14 13:52 ` Arnd Bergmann
2015-10-14 14:07 ` Vladimir Zapolskiy
2015-10-14 14:07 ` Vladimir Zapolskiy
2015-10-14 14:13 ` Arnd Bergmann
2015-10-14 14:13 ` Arnd Bergmann
2015-10-14 17:23 ` Joachim Eastwood
2015-10-14 17:23 ` Joachim Eastwood
2015-10-14 20:07 ` Arnd Bergmann
2015-10-14 20:07 ` Arnd Bergmann
2015-10-14 21:15 ` Joachim Eastwood
2015-10-14 21:15 ` Joachim Eastwood
2015-10-12 23:54 ` [PATCH 3/5] arm: dts: lpc32xx: add labels to all defined peripheral nodes Vladimir Zapolskiy
2015-10-12 23:54 ` Vladimir Zapolskiy
2015-10-12 23:54 ` [PATCH 4/5] arm: dts: lpc32xx: remove unneeded cell settings from cpus Vladimir Zapolskiy
2015-10-12 23:54 ` Vladimir Zapolskiy
2015-10-13 8:18 ` Joachim Eastwood
2015-10-13 8:18 ` Joachim Eastwood
2015-10-13 10:03 ` Vladimir Zapolskiy [this message]
2015-10-13 10:03 ` Vladimir Zapolskiy
2015-10-13 16:20 ` [PATCH v2 4/5] arm: dts: lpc32xx: add reg property to cpu device node Vladimir Zapolskiy
2015-10-13 16:20 ` Vladimir Zapolskiy
2015-10-12 23:54 ` [PATCH 5/5] arm: dts: lpc32xx: add device node for the second pwm controller Vladimir Zapolskiy
2015-10-12 23:54 ` Vladimir Zapolskiy
2015-10-14 18:04 ` Joachim Eastwood
2015-10-14 18:04 ` Joachim Eastwood
2015-10-15 10:25 ` Vladimir Zapolskiy
2015-10-15 10:25 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561CD6D9.1020102@mleia.com \
--to=vz@mleia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.