From: Kai Huang <kai.huang@linux.intel.com>
To: Wei Liu <wei.liu2@citrix.com>, Jan Beulich <JBeulich@suse.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
xudong.hao@intel.com, Ross Lagerwall <ross.lagerwall@citrix.com>,
Jun Nakajima <jun.nakajima@intel.com>,
robert.hu@intel.com, xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v3] x86/EPT: work around hardware erratum setting A bit
Date: Wed, 14 Oct 2015 09:17:23 +0800 [thread overview]
Message-ID: <561DAD23.7020704@linux.intel.com> (raw)
In-Reply-To: <20151002093606.GE25714@zion.uk.xensource.com>
On 10/02/2015 05:36 PM, Wei Liu wrote:
> On Wed, Sep 30, 2015 at 01:25:49PM +0100, Wei Liu wrote:
>> On Wed, Sep 30, 2015 at 05:36:22AM -0600, Jan Beulich wrote:
>>> Since commit 191b3f3344ee ("p2m/ept: enable PML in p2m-ept for
>>> log-dirty"), the A and D bits of EPT paging entries are set
>>> unconditionally, regardless of whether PML is enabled or not. This
>>> causes a regression in Xen 4.6 on some processors due to Intel Errata
>>> AVR41 -- HVM guests get severe memory corruption when the A bit is set
>>> due to incorrect TLB flushing on mov to cr3. The errata affects the Atom
>>> C2000 family (Avoton).
>>>
>>> To fix, do not set the A bit on this processor family.
>>>
>>> Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
>>>
>>> Move feature suppression to feature detection code. Add command line
>>> override.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>>>
>> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
>>
>> Thanks for handling this issue!
> In light of both the author and vmx maintainer are on vacation until
> October 8, I think we might as well commit this today.
>
> Kevin and Kai, when you're back, please have a look at this patch. And,
> if you disagree with the approach, please provide a patch to be
> backported to 4.6.1.
Hi Wei,
Sorry for late response. Our QA (Xudong and Robert, also copied here)
has conducted PML testing on Xen 4.6 release (which contains this patch)
and looks everything works fine.
Thanks,
-Kai
>
> Wei.
>
prev parent reply other threads:[~2015-10-14 1:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-30 11:36 [PATCH v3] x86/EPT: work around hardware erratum setting A bit Jan Beulich
2015-09-30 11:47 ` Andrew Cooper
2015-09-30 12:02 ` Jan Beulich
2015-09-30 12:07 ` Andrew Cooper
2015-10-02 10:29 ` Andrew Cooper
2015-10-02 10:47 ` Wei Liu
2015-09-30 12:25 ` Wei Liu
2015-10-02 9:36 ` Wei Liu
2015-10-14 1:17 ` Kai Huang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561DAD23.7020704@linux.intel.com \
--to=kai.huang@linux.intel.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=jun.nakajima@intel.com \
--cc=kevin.tian@intel.com \
--cc=robert.hu@intel.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
--cc=xudong.hao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.