From: Roger Quadros <rogerq@ti.com>
To: Franklin S Cooper Jr <fcooper@ti.com>,
paul@pwsan.com, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
linux@arm.linux.org.uk, tony@atomide.com, nm@ti.com
Subject: Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
Date: Wed, 14 Oct 2015 09:58:46 +0300 [thread overview]
Message-ID: <561DFD26.9090702@ti.com> (raw)
In-Reply-To: <1444743874-4454-1-git-send-email-fcooper@ti.com>
On 13/10/15 16:44, Franklin S Cooper Jr wrote:
> ELM address information is provided by device tree. No longer need
> to include this information within hwmod.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
Franklin,
Can you please do the same for gpmc_addr as well?
And looks like elm_addr needs to be removed from
omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?
cheers,
-roger
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247b..ad2cc7a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
> - {
> - .pa_start = 0x48078000,
> - .pa_end = 0x48078fff,
> - .flags = ADDR_TYPE_RT
> - },
> - { }
> -};
> -
> /* l4_per1 -> elm */
> static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
> .master = &dra7xx_l4_per1_hwmod,
> .slave = &dra7xx_elm_hwmod,
> .clk = "l3_iclk_div",
> - .addr = dra7xx_elm_addrs,
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: rogerq@ti.com (Roger Quadros)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
Date: Wed, 14 Oct 2015 09:58:46 +0300 [thread overview]
Message-ID: <561DFD26.9090702@ti.com> (raw)
In-Reply-To: <1444743874-4454-1-git-send-email-fcooper@ti.com>
On 13/10/15 16:44, Franklin S Cooper Jr wrote:
> ELM address information is provided by device tree. No longer need
> to include this information within hwmod.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
Franklin,
Can you please do the same for gpmc_addr as well?
And looks like elm_addr needs to be removed from
omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?
cheers,
-roger
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247b..ad2cc7a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
> - {
> - .pa_start = 0x48078000,
> - .pa_end = 0x48078fff,
> - .flags = ADDR_TYPE_RT
> - },
> - { }
> -};
> -
> /* l4_per1 -> elm */
> static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
> .master = &dra7xx_l4_per1_hwmod,
> .slave = &dra7xx_elm_hwmod,
> .clk = "l3_iclk_div",
> - .addr = dra7xx_elm_addrs,
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
>
WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Franklin S Cooper Jr <fcooper@ti.com>, <paul@pwsan.com>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-omap@vger.kernel.org>, <linux@arm.linux.org.uk>,
<tony@atomide.com>, <nm@ti.com>
Subject: Re: [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data
Date: Wed, 14 Oct 2015 09:58:46 +0300 [thread overview]
Message-ID: <561DFD26.9090702@ti.com> (raw)
In-Reply-To: <1444743874-4454-1-git-send-email-fcooper@ti.com>
On 13/10/15 16:44, Franklin S Cooper Jr wrote:
> ELM address information is provided by device tree. No longer need
> to include this information within hwmod.
>
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
Acked-by: Roger Quadros <rogerq@ti.com>
Franklin,
Can you please do the same for gpmc_addr as well?
And looks like elm_addr needs to be removed from
omap_hwmod_33xx_43xx_interconnect_data.c and omap_hwmod_44xx_data.c as well, no?
cheers,
-roger
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 562247b..ad2cc7a 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -2566,21 +2566,11 @@ static struct omap_hwmod_ocp_if dra7xx_l3_main_1__hdmi = {
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
> -static struct omap_hwmod_addr_space dra7xx_elm_addrs[] = {
> - {
> - .pa_start = 0x48078000,
> - .pa_end = 0x48078fff,
> - .flags = ADDR_TYPE_RT
> - },
> - { }
> -};
> -
> /* l4_per1 -> elm */
> static struct omap_hwmod_ocp_if dra7xx_l4_per1__elm = {
> .master = &dra7xx_l4_per1_hwmod,
> .slave = &dra7xx_elm_hwmod,
> .clk = "l3_iclk_div",
> - .addr = dra7xx_elm_addrs,
> .user = OCP_USER_MPU | OCP_USER_SDMA,
> };
>
>
next prev parent reply other threads:[~2015-10-14 6:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 13:44 [PATCH] ARM: DRA7: hwmod: Remove elm address space from hwmod data Franklin S Cooper Jr
2015-10-13 13:44 ` Franklin S Cooper Jr
2015-10-13 14:02 ` Lokesh Vutla
2015-10-13 14:02 ` Lokesh Vutla
2015-10-13 14:02 ` Lokesh Vutla
2015-10-14 6:58 ` Roger Quadros [this message]
2015-10-14 6:58 ` Roger Quadros
2015-10-14 6:58 ` Roger Quadros
2015-10-14 13:08 ` Franklin S Cooper Jr.
2015-10-14 13:08 ` Franklin S Cooper Jr.
2015-10-14 13:08 ` Franklin S Cooper Jr.
2015-10-15 6:25 ` Paul Walmsley
2015-10-15 6:25 ` Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561DFD26.9090702@ti.com \
--to=rogerq@ti.com \
--cc=fcooper@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nm@ti.com \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.