All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@ti.com>
To: Franklin S Cooper Jr <fcooper@ti.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-omap@vger.kernel.org>, <linux-mtd@lists.infradead.org>,
	<nsekhar@ti.com>, <computersforpeace@gmail.com>,
	<dwmw2@infradead.org>, <tony@atomide.com>
Subject: Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT
Date: Wed, 14 Oct 2015 14:36:47 +0300	[thread overview]
Message-ID: <561E3E4F.9020302@ti.com> (raw)
In-Reply-To: <1444700338-27582-2-git-send-email-fcooper@ti.com>

On 13/10/15 04:38, Franklin S Cooper Jr wrote:
> Switch from dma_request_channel to allow passing dma channel
> information from DT rather than hardcoding a value.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>

Acked-by: Roger Quadros <rogerq@ti.com>

> ---
>  drivers/mtd/nand/omap2.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index d0f2620..957c32f 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1866,7 +1866,9 @@ static int omap_nand_probe(struct platform_device *pdev)
>  		dma_cap_zero(mask);
>  		dma_cap_set(DMA_SLAVE, mask);
>  		sig = OMAP24XX_DMA_GPMC;
> -		info->dma = dma_request_channel(mask, omap_dma_filter_fn, &sig);
> +		info->dma = dma_request_slave_channel_compat(mask,
> +			omap_dma_filter_fn, &sig, pdev->dev.parent, "rxtx");
> +
>  		if (!info->dma) {
>  			dev_err(&pdev->dev, "DMA engine request failed\n");
>  			err = -ENXIO;
> 

cheers,
-roger

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@ti.com>
To: Franklin S Cooper Jr <fcooper@ti.com>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	linux-omap@vger.kernel.org, linux-mtd@lists.infradead.org,
	nsekhar@ti.com, computersforpeace@gmail.com, dwmw2@infradead.org,
	tony@atomide.com
Subject: Re: [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT
Date: Wed, 14 Oct 2015 14:36:47 +0300	[thread overview]
Message-ID: <561E3E4F.9020302@ti.com> (raw)
In-Reply-To: <1444700338-27582-2-git-send-email-fcooper@ti.com>

On 13/10/15 04:38, Franklin S Cooper Jr wrote:
> Switch from dma_request_channel to allow passing dma channel
> information from DT rather than hardcoding a value.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>

Acked-by: Roger Quadros <rogerq@ti.com>

> ---
>  drivers/mtd/nand/omap2.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index d0f2620..957c32f 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -1866,7 +1866,9 @@ static int omap_nand_probe(struct platform_device *pdev)
>  		dma_cap_zero(mask);
>  		dma_cap_set(DMA_SLAVE, mask);
>  		sig = OMAP24XX_DMA_GPMC;
> -		info->dma = dma_request_channel(mask, omap_dma_filter_fn, &sig);
> +		info->dma = dma_request_slave_channel_compat(mask,
> +			omap_dma_filter_fn, &sig, pdev->dev.parent, "rxtx");
> +
>  		if (!info->dma) {
>  			dev_err(&pdev->dev, "DMA engine request failed\n");
>  			err = -ENXIO;
> 

cheers,
-roger

  reply	other threads:[~2015-10-14 11:37 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-13  1:38 [PATCH 0/5] mtd: nand: Fix support for NAND DMA Prefetch Franklin S Cooper Jr
2015-10-13  1:38 ` Franklin S Cooper Jr
2015-10-13  1:38 ` [PATCH 1/5] mtd: nand: omap2: Support parsing dma channel information from DT Franklin S Cooper Jr
2015-10-14 11:36   ` Roger Quadros [this message]
2015-10-14 11:36     ` Roger Quadros
2015-10-14 11:52     ` Roger Quadros
2015-10-14 11:52       ` Roger Quadros
2015-10-14 13:26       ` Franklin S Cooper Jr.
2015-10-14 13:26         ` Franklin S Cooper Jr.
2015-10-14 14:11         ` Roger Quadros
2015-10-14 14:11           ` Roger Quadros
2015-10-14 14:32           ` Franklin S Cooper Jr.
2015-10-14 14:32             ` Franklin S Cooper Jr.
2015-10-14 16:18             ` Tony Lindgren
2015-10-14 16:18               ` Tony Lindgren
2015-10-14 16:23               ` Franklin S Cooper Jr.
2015-10-14 16:23                 ` Franklin S Cooper Jr.
2015-10-14 18:13                 ` Tony Lindgren
2015-10-14 20:03                   ` Franklin S Cooper Jr.
2015-10-14 20:03                     ` Franklin S Cooper Jr.
2015-10-15  7:35                     ` Roger Quadros
2015-10-15  7:35                       ` Roger Quadros
2015-10-15 17:12                       ` Franklin S Cooper Jr.
2015-10-15 17:12                         ` Franklin S Cooper Jr.
2015-10-13  1:38 ` [PATCH 2/5] mtd: nand: omap2: Start dma request before enabling prefetch Franklin S Cooper Jr
2015-10-14 11:41   ` Roger Quadros
2015-10-14 11:41     ` Roger Quadros
2015-10-14 13:45     ` Franklin S Cooper Jr.
2015-10-14 13:45       ` Franklin S Cooper Jr.
2015-10-13  1:38 ` [PATCH 3/5] mtd: nand: omap2: Fix high memory dma prefetch transfer Franklin S Cooper Jr
2015-10-13  1:38 ` [PATCH 4/5] ARM: dts: am437x/am33xx/omap3/dm816x: Add gpmc dma channel Franklin S Cooper Jr
2015-10-14 11:44   ` Roger Quadros
2015-10-14 11:44     ` Roger Quadros
2015-10-14 13:57     ` Franklin S Cooper Jr.
2015-10-14 13:57       ` Franklin S Cooper Jr.
2015-10-13  1:38 ` [PATCH 5/5] ARM: OMAP2+: Update gpmc and nand DT binding documentation Franklin S Cooper Jr
2015-10-14 11:50   ` Roger Quadros
2015-10-14 11:50     ` Roger Quadros
2015-10-15 17:14     ` Franklin S Cooper Jr.
2015-10-15 17:14       ` Franklin S Cooper Jr.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=561E3E4F.9020302@ti.com \
    --to=rogerq@ti.com \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=fcooper@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nsekhar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.