From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>, Keir Fraser <keir@xen.org>
Subject: Re: [PATCH] x86/Centaur: drop __init annotations
Date: Wed, 14 Oct 2015 14:30:21 +0100 [thread overview]
Message-ID: <561E58ED.7020803@citrix.com> (raw)
In-Reply-To: <561E744C02000078000AAEDC@prv-mh.provo.novell.com>
On 14/10/15 14:27, Jan Beulich wrote:
>>>> On 14.10.15 at 15:22, <andrew.cooper3@citrix.com> wrote:
>> On 14/10/15 14:06, Jan Beulich wrote:
>>> Commit 6f8f53cc64 ("x86 cpu: Fix bug: unify cpu_dev attr as
>>> __cpuinitdata") fixed centaur_cpu_dev's annotation without also fixing
>>> the pointers hanging off of it. Even if CPU hotplig support may be
>>> purely theoretical for Centaur, we should still not leave this as is.
>>>
>>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>> Surely they should be __cpuinit to match __cpuinitdata.
>>
>> This will have the same effect, as __cpuinit is empty on x86.
> Actually all the __{cpu,dev}init{,data} should go away, which is
> why I wouldn't want to needlessly add them here.
I suppose they should. I will draft a patch.
In the mean time, Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
prev parent reply other threads:[~2015-10-14 13:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-14 13:06 [PATCH] x86/Centaur: drop __init annotations Jan Beulich
2015-10-14 13:22 ` Andrew Cooper
2015-10-14 13:27 ` Jan Beulich
2015-10-14 13:30 ` Andrew Cooper [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561E58ED.7020803@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.