From: Qais Yousef <qais.yousef@imgtec.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: <linux-kernel@vger.kernel.org>, <tglx@linutronix.de>,
<jason@lakedaemon.net>, <marc.zyngier@arm.com>,
<jiang.liu@linux.intel.com>, <ralf@linux-mips.org>,
<linux-mips@linux-mips.org>
Subject: Re: [RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data
Date: Wed, 14 Oct 2015 16:46:41 +0100 [thread overview]
Message-ID: <561E78E1.2020907@imgtec.com> (raw)
In-Reply-To: <20151014145017.GE3052@linux-uzut.site>
On 10/14/2015 03:50 PM, Davidlohr Bueso wrote:
> On Tue, 13 Oct 2015, Qais Yousef wrote:
>
>> It has a similar role to affinity mask, but tracks the IPI affinity
>> instead.
>>
>> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
>> ---
>> include/linux/irq.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/irq.h b/include/linux/irq.h
>> index 504133671985..b000b217ea24 100644
>> --- a/include/linux/irq.h
>> +++ b/include/linux/irq.h
>> @@ -157,6 +157,7 @@ struct irq_common_data {
>> void *handler_data;
>> struct msi_desc *msi_desc;
>> cpumask_var_t affinity;
>> + struct ipi_mask ipi_mask;
>> };
>
> This should be folded into patch 3, no?
For me they are 2 separate changes, hence the 2 commits. They could be
folded but I prefer the septation unless there's a strong opinion not to.
Thanks,
Qais
WARNING: multiple messages have this Message-ID (diff)
From: Qais Yousef <qais.yousef@imgtec.com>
To: Davidlohr Bueso <dave@stgolabs.net>
Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de,
jason@lakedaemon.net, marc.zyngier@arm.com,
jiang.liu@linux.intel.com, ralf@linux-mips.org,
linux-mips@linux-mips.org
Subject: Re: [RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data
Date: Wed, 14 Oct 2015 16:46:41 +0100 [thread overview]
Message-ID: <561E78E1.2020907@imgtec.com> (raw)
Message-ID: <20151014154641.9S9x_Pf-RKCKWOxpoPk6zZcEUmF_ChShbSzpOBfTc8A@z> (raw)
In-Reply-To: <20151014145017.GE3052@linux-uzut.site>
On 10/14/2015 03:50 PM, Davidlohr Bueso wrote:
> On Tue, 13 Oct 2015, Qais Yousef wrote:
>
>> It has a similar role to affinity mask, but tracks the IPI affinity
>> instead.
>>
>> Signed-off-by: Qais Yousef <qais.yousef@imgtec.com>
>> ---
>> include/linux/irq.h | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/include/linux/irq.h b/include/linux/irq.h
>> index 504133671985..b000b217ea24 100644
>> --- a/include/linux/irq.h
>> +++ b/include/linux/irq.h
>> @@ -157,6 +157,7 @@ struct irq_common_data {
>> void *handler_data;
>> struct msi_desc *msi_desc;
>> cpumask_var_t affinity;
>> + struct ipi_mask ipi_mask;
>> };
>
> This should be folded into patch 3, no?
For me they are 2 separate changes, hence the 2 commits. They could be
folded but I prefer the septation unless there's a strong opinion not to.
Thanks,
Qais
next prev parent reply other threads:[~2015-10-14 15:46 UTC|newest]
Thread overview: 73+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-13 10:16 [RFC v2 PATCH 00/14] Implement generic IPI support mechanism Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 01/14] irq: add new IRQ_DOMAIN_FLAGS_IPI Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 02/14] irq: add GENERIC_IRQ_IPI Kconfig symbol Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 03/14] irq: add new struct ipi_mask Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 13:26 ` Thomas Gleixner
2015-10-13 14:26 ` Qais Yousef
2015-10-13 14:26 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 04/14] irq: add a new irq_send_ipi() to irq_chip Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 05/14] irq: add struct ipi_mask to irq_data Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 12:36 ` kbuild test robot
2015-10-13 12:36 ` kbuild test robot
2015-10-14 14:50 ` Davidlohr Bueso
2015-10-14 15:46 ` Qais Yousef [this message]
2015-10-14 15:46 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 06/14] irq: add struct ipi_mapping and its helper functions Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 13:31 ` Thomas Gleixner
2015-10-13 14:30 ` Qais Yousef
2015-10-13 14:30 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 07/14] irq: add a new generic IPI reservation code to irq core Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 10:56 ` kbuild test robot
2015-10-13 10:56 ` kbuild test robot
2015-10-13 10:56 ` kbuild test robot
2015-10-13 10:56 ` kbuild test robot
2015-10-13 13:37 ` Thomas Gleixner
2015-10-13 14:38 ` Qais Yousef
2015-10-13 14:38 ` Qais Yousef
2015-10-28 15:46 ` Qais Yousef
2015-10-28 15:46 ` Qais Yousef
2015-10-29 10:39 ` Qais Yousef
2015-10-29 10:39 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 08/14] irq: implement irq_send_ipi Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 11:12 ` kbuild test robot
2015-10-13 11:12 ` kbuild test robot
2015-10-13 11:29 ` kbuild test robot
2015-10-13 11:29 ` kbuild test robot
2015-10-13 13:40 ` Thomas Gleixner
2015-10-13 14:41 ` Qais Yousef
2015-10-13 14:41 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 09/14] MIPS: add support for generic SMP IPI support Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 13:48 ` Thomas Gleixner
2015-10-13 14:43 ` Qais Yousef
2015-10-13 14:43 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 10/14] MIPS: make smp CMP, CPS and MT use the new generic IPI functions Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 13:49 ` Thomas Gleixner
2015-10-13 14:46 ` Qais Yousef
2015-10-13 14:46 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 11/14] MIPS: delete smp-gic.c Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 12/14] irqchip: mips-gic: add a IPI hierarchy domain Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 13/14] irqchip: mips-gic: implement the new irq_send_ipi Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 10:16 ` [RFC v2 PATCH 14/14] irqchip: mips-gic: remove IPI init code Qais Yousef
2015-10-13 10:16 ` Qais Yousef
2015-10-13 13:53 ` [RFC v2 PATCH 00/14] Implement generic IPI support mechanism Thomas Gleixner
2015-10-13 14:48 ` Qais Yousef
2015-10-13 14:48 ` Qais Yousef
2015-10-13 17:24 ` Sergei Shtylyov
2015-10-13 17:27 ` Thomas Gleixner
2015-10-14 15:04 ` Davidlohr Bueso
2015-10-14 15:49 ` Qais Yousef
2015-10-14 15:49 ` Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=561E78E1.2020907@imgtec.com \
--to=qais.yousef@imgtec.com \
--cc=dave@stgolabs.net \
--cc=jason@lakedaemon.net \
--cc=jiang.liu@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=marc.zyngier@arm.com \
--cc=ralf@linux-mips.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.