Re: [PATCH 2/2] qla2xxx: fix rwlock recursion

[Bart Van Assche <bart.vanassche@sandisk.com>]

On 10/14/2015 08:57 AM, Himanshu Madhani wrote:
> -qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong off_in,
> -			     void __iomem **off_out)
> +qla82xx_pci_set_crbwindow_2M(struct qla_hw_data *ha, ulong *off)
>   {

Hello Himanshu,

Do you think it would be possible to keep the input and output offset as 
separate arguments ? Something that is very unfortunate about this patch 
is that it converts the qla82xx_pci_set_crbwindow_2M() function again 
into a function that expects an unsigned long in *off and writes an I/O 
memory address into *off. It is impossible to avoid that source code 
does not trigger any sparse warning if such functions occur.

Thanks,

Bart.