All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xose Vazquez Perez <xose.vazquez@gmail.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>,
	Himanshu Madhani <himanshu.madhani@qlogic.com>,
	linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH 2/2] qla2xxx: fix rwlock recursion
Date: Mon, 16 Nov 2015 23:57:32 +0100	[thread overview]
Message-ID: <564A5F5C.4050209@gmail.com> (raw)

Bart Van Assche wrote:

> [PATCH] qla2xxx: Fix rwlock recursion
> 
> Fixes: 8dfa4b5a9b44 ("qla2xxx: Fix sparse annotation")
> Signed-off-by: Bart Van Assche <bart.vanassche@sandisk.com>
> Reported-by: Himanshu Madhani <himanshu.madhani@qlogic.com>
> Cc: Giridhar Malavali <giridhar.malavali@qlogic.com>
> ---
>   drivers/scsi/qla2xxx/qla_nx.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_nx.c b/drivers/scsi/qla2xxx/qla_nx.c
> index eb0cc54..b6b4cfd 100644
> --- a/drivers/scsi/qla2xxx/qla_nx.c
> +++ b/drivers/scsi/qla2xxx/qla_nx.c
> @@ -433,7 +433,7 @@ qla82xx_pci_get_crb_addr_2M(struct qla_hw_data *ha, 
> ulong off_in,
>   	if (off_in < QLA82XX_PCI_CRBSPACE)
>   		return -1;
> 
> -	*off_out = (void __iomem *)(off_in - QLA82XX_PCI_CRBSPACE);
> +	off_in -= QLA82XX_PCI_CRBSPACE;
> 
>   	/* Try direct map */
>   	m = &crb_128M_2M_map[CRB_BLK(off_in)].sub_block[CRB_SUBBLK(off_in)];
> @@ -443,6 +443,7 @@ qla82xx_pci_get_crb_addr_2M(struct qla_hw_data *ha, 
> ulong off_in,
>   		return 0;
>   	}
>   	/* Not in direct map, use crb window */
> +	*off_out = (void __iomem *)off_in;
>   	return 1;
>   }
> 
> -- 
> 2.1.4

This patch is still pending or it was lost, could you please resend it ?

-thanks-

             reply	other threads:[~2015-11-16 22:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-16 22:57 Xose Vazquez Perez [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-10-14 15:57 [PATCH 0/2] qla2xxx: Patches for 4.3.0-rc5+ scsi "misc" branch Himanshu Madhani
2015-10-14 15:57 ` [PATCH 2/2] qla2xxx: fix rwlock recursion Himanshu Madhani
2015-10-14 16:53   ` Bart Van Assche
2015-10-14 17:33   ` Bart Van Assche
2015-10-14 21:07     ` Himanshu Madhani
2015-10-26 20:34       ` Himanshu Madhani
2015-10-15  7:50   ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=564A5F5C.4050209@gmail.com \
    --to=xose.vazquez@gmail.com \
    --cc=bart.vanassche@sandisk.com \
    --cc=himanshu.madhani@qlogic.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.